[INFO] updating cached repository cbranch/aoc2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cbranch/aoc2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cbranch/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/cbranch/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cbranch/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cbranch/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbranch/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbranch/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2aa8d341bdf0187136bb6362c42f1412d1e51a1d
[INFO] sha for GitHub repo cbranch/aoc2018: 2aa8d341bdf0187136bb6362c42f1412d1e51a1d
[INFO] validating manifest of cbranch/aoc2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cbranch/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cbranch/aoc2018
[INFO] finished frobbing cbranch/aoc2018
[INFO] frobbed toml for cbranch/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/cbranch/aoc2018/Cargo.toml
[INFO] started frobbing cbranch/aoc2018
[INFO] finished frobbing cbranch/aoc2018
[INFO] frobbed toml for cbranch/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cbranch/aoc2018/Cargo.toml
[INFO] crate cbranch/aoc2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cbranch/aoc2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cbranch/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 176c10522c0b176b451eeea8bb630280250f8161d8ada5757da9914043bab790
[INFO] running `"docker" "start" "-a" "176c10522c0b176b451eeea8bb630280250f8161d8ada5757da9914043bab790"`
[INFO] [stderr]     Checking aoc2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     reader
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:9:18
[INFO] [stderr]    |
[INFO] [stderr] 9  |     let reader = BufReader::new(input_file);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     reader
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:9:18
[INFO] [stderr]    |
[INFO] [stderr] 9  |     let reader = BufReader::new(input_file);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day2.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn find_prototype_box_ids(box_ids: &Vec<String>) -> String {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day2.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn find_prototype_box_ids(box_ids: &Vec<String>) -> String {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.91s
[INFO] running `"docker" "inspect" "176c10522c0b176b451eeea8bb630280250f8161d8ada5757da9914043bab790"`
[INFO] running `"docker" "rm" "-f" "176c10522c0b176b451eeea8bb630280250f8161d8ada5757da9914043bab790"`
[INFO] [stdout] 176c10522c0b176b451eeea8bb630280250f8161d8ada5757da9914043bab790