[INFO] updating cached repository categulario/game_of_life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/categulario/game_of_life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/categulario/game_of_life" "work/ex/clippy-test-run/sources/stable/gh/categulario/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/categulario/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/categulario/game_of_life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/categulario/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/categulario/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9fd7caa59a8398daec3c68dda17a016adee65f3 [INFO] sha for GitHub repo categulario/game_of_life: c9fd7caa59a8398daec3c68dda17a016adee65f3 [INFO] validating manifest of categulario/game_of_life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of categulario/game_of_life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing categulario/game_of_life [INFO] finished frobbing categulario/game_of_life [INFO] frobbed toml for categulario/game_of_life written to work/ex/clippy-test-run/sources/stable/gh/categulario/game_of_life/Cargo.toml [INFO] started frobbing categulario/game_of_life [INFO] finished frobbing categulario/game_of_life [INFO] frobbed toml for categulario/game_of_life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/categulario/game_of_life/Cargo.toml [INFO] crate categulario/game_of_life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting categulario/game_of_life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/categulario/game_of_life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df106f40d8bb07e5f8b425601e7f4582dcee75af605d83371192728c82098371 [INFO] running `"docker" "start" "-a" "df106f40d8bb07e5f8b425601e7f4582dcee75af605d83371192728c82098371"` [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Compiling x11-dl v2.17.3 [INFO] [stderr] Checking crossbeam-epoch v0.3.0 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rusttype v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return arr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return arr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | / match data[(h*width + w) as usize] { [INFO] [stderr] 58 | | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] 59 | | _ => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellType::Alive = data[(h*width + w) as usize] { rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:77 [INFO] [stderr] | [INFO] [stderr] 58 | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(w*10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:92 [INFO] [stderr] | [INFO] [stderr] 58 | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(h*10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | fn update(&mut self, args: &UpdateArgs, delay: f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | if self.seconds < delay as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(delay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | newdata.push(match cell { [INFO] [stderr] | __________________________^ [INFO] [stderr] 78 | | &CellType::Alive => match alive_neighbours(data, index, self.width) { [INFO] [stderr] 79 | | 0..=1 => CellType::Dead, // underpopulation [INFO] [stderr] 80 | | 2..=3 => CellType::Alive, // normal population [INFO] [stderr] ... | [INFO] [stderr] 87 | | }, [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | newdata.push(match *cell { [INFO] [stderr] 78 | CellType::Alive => match alive_neighbours(data, index, self.width) { [INFO] [stderr] 79 | 0..=1 => CellType::Dead, // underpopulation [INFO] [stderr] 80 | 2..=3 => CellType::Alive, // normal population [INFO] [stderr] 81 | 4..=8 => CellType::Dead, // overpopulation [INFO] [stderr] 82 | _ => CellType::Dead, // this doesn't really happen... [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | / match data[(h*width + w) as usize] { [INFO] [stderr] 58 | | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] 59 | | _ => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let CellType::Alive = data[(h*width + w) as usize] { rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:77 [INFO] [stderr] | [INFO] [stderr] 58 | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(w*10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:92 [INFO] [stderr] | [INFO] [stderr] 58 | CellType::Alive => rectangle([0.0, 0.0, 0.0, 1.0], [(w*10) as f64, (h*10) as f64, 10.0, 10.0], context.transform, graphics), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(h*10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | fn update(&mut self, args: &UpdateArgs, delay: f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | if self.seconds < delay as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(delay)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | newdata.push(match cell { [INFO] [stderr] | __________________________^ [INFO] [stderr] 78 | | &CellType::Alive => match alive_neighbours(data, index, self.width) { [INFO] [stderr] 79 | | 0..=1 => CellType::Dead, // underpopulation [INFO] [stderr] 80 | | 2..=3 => CellType::Alive, // normal population [INFO] [stderr] ... | [INFO] [stderr] 87 | | }, [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | newdata.push(match *cell { [INFO] [stderr] 78 | CellType::Alive => match alive_neighbours(data, index, self.width) { [INFO] [stderr] 79 | 0..=1 => CellType::Dead, // underpopulation [INFO] [stderr] 80 | 2..=3 => CellType::Alive, // normal population [INFO] [stderr] 81 | 4..=8 => CellType::Dead, // overpopulation [INFO] [stderr] 82 | _ => CellType::Dead, // this doesn't really happen... [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.73s [INFO] running `"docker" "inspect" "df106f40d8bb07e5f8b425601e7f4582dcee75af605d83371192728c82098371"` [INFO] running `"docker" "rm" "-f" "df106f40d8bb07e5f8b425601e7f4582dcee75af605d83371192728c82098371"` [INFO] [stdout] df106f40d8bb07e5f8b425601e7f4582dcee75af605d83371192728c82098371