[INFO] updating cached repository cat-in-136/rust-bocu1tst [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cat-in-136/rust-bocu1tst [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cat-in-136/rust-bocu1tst" "work/ex/clippy-test-run/sources/stable/gh/cat-in-136/rust-bocu1tst"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cat-in-136/rust-bocu1tst'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cat-in-136/rust-bocu1tst" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cat-in-136/rust-bocu1tst"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cat-in-136/rust-bocu1tst'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31964cc3d4f498fc7a67324ae898587dd5db02b6 [INFO] sha for GitHub repo cat-in-136/rust-bocu1tst: 31964cc3d4f498fc7a67324ae898587dd5db02b6 [INFO] validating manifest of cat-in-136/rust-bocu1tst on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cat-in-136/rust-bocu1tst on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cat-in-136/rust-bocu1tst [INFO] finished frobbing cat-in-136/rust-bocu1tst [INFO] frobbed toml for cat-in-136/rust-bocu1tst written to work/ex/clippy-test-run/sources/stable/gh/cat-in-136/rust-bocu1tst/Cargo.toml [INFO] started frobbing cat-in-136/rust-bocu1tst [INFO] finished frobbing cat-in-136/rust-bocu1tst [INFO] frobbed toml for cat-in-136/rust-bocu1tst written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cat-in-136/rust-bocu1tst/Cargo.toml [INFO] crate cat-in-136/rust-bocu1tst has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cat-in-136/rust-bocu1tst against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cat-in-136/rust-bocu1tst:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d457ec1c6eda5fc54bef93b42b1ab43275248a5fc3aa382ff5a267d994ba8a97 [INFO] running `"docker" "start" "-a" "d457ec1c6eda5fc54bef93b42b1ab43275248a5fc3aa382ff5a267d994ba8a97"` [INFO] [stderr] Checking rust-bocu1tst v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/bocu1.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/bocu1.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/bocu1.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/bocu1.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | return 0x01000000 | (BOCU1_MIDDLE + diff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | if c < 0 || c > 0x10ffff { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | 0x01000000 | c [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | 0...0x10ffff => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | if packed < 0x04000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | return 0x01000000 | (BOCU1_MIDDLE + diff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | if c < 0 || c > 0x10ffff { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | 0x01000000 | c [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | 0...0x10ffff => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bocu1.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | if packed < 0x04000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BOCU1_MAX_LEAD` [INFO] [stderr] --> src/bocu1.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const BOCU1_MAX_LEAD: i32 = 0xfe; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: constant item is never used: `BOCU1_MAX_LEAD` [INFO] [stderr] | [INFO] [stderr] --> src/bocu1.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const BOCU1_MAX_LEAD: i32 = 0xfe; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BOCU1_COUNT` [INFO] [stderr] --> src/bocu1.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const BOCU1_COUNT: i32 = (BOCU1_MAX_LEAD - BOCU1_MIN + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BOCU1_LEAD_4` [INFO] [stderr] --> src/bocu1.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const BOCU1_LEAD_4: i32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BOCU1_COUNT` [INFO] [stderr] --> src/bocu1.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const BOCU1_COUNT: i32 = (BOCU1_MAX_LEAD - BOCU1_MIN + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BOCU1_LEAD_4` [INFO] [stderr] --> src/bocu1.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const BOCU1_LEAD_4: i32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bocu1.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | t = BOCU1_BYTE_TO_TRAIL[b as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BOCU1_BYTE_TO_TRAIL[b as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bocu1.rs:301:17 [INFO] [stderr] | [INFO] [stderr] 301 | let b = b as i32; [INFO] [stderr] --> src/bocu1.rs:253:17 [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] 253 | t = BOCU1_BYTE_TO_TRAIL[b as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BOCU1_BYTE_TO_TRAIL[b as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bocu1.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | BOCU1_TRAIL_TO_BYTE[t as usize] as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BOCU1_TRAIL_TO_BYTE[t as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bocu1.rs:301:17 [INFO] [stderr] | [INFO] [stderr] 301 | let b = b as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bocu1.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | BOCU1_TRAIL_TO_BYTE[t as usize] as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(BOCU1_TRAIL_TO_BYTE[t as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | fout.write(&bytes[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | fn main_encode(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | fout.write(&bytes[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | fn main_decode(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | fn main_encode(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | fn main_decode(filename: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-bocu1tst`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `rust-bocu1tst`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d457ec1c6eda5fc54bef93b42b1ab43275248a5fc3aa382ff5a267d994ba8a97"` [INFO] running `"docker" "rm" "-f" "d457ec1c6eda5fc54bef93b42b1ab43275248a5fc3aa382ff5a267d994ba8a97"` [INFO] [stdout] d457ec1c6eda5fc54bef93b42b1ab43275248a5fc3aa382ff5a267d994ba8a97