[INFO] updating cached repository cassava/aoc18.rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cassava/aoc18.rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cassava/aoc18.rs" "work/ex/clippy-test-run/sources/stable/gh/cassava/aoc18.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cassava/aoc18.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cassava/aoc18.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cassava/aoc18.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cassava/aoc18.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4197dbfc1d222d22d0ac55bbe100f4b69871d048
[INFO] sha for GitHub repo cassava/aoc18.rs: 4197dbfc1d222d22d0ac55bbe100f4b69871d048
[INFO] validating manifest of cassava/aoc18.rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cassava/aoc18.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cassava/aoc18.rs
[INFO] finished frobbing cassava/aoc18.rs
[INFO] frobbed toml for cassava/aoc18.rs written to work/ex/clippy-test-run/sources/stable/gh/cassava/aoc18.rs/Cargo.toml
[INFO] started frobbing cassava/aoc18.rs
[INFO] finished frobbing cassava/aoc18.rs
[INFO] frobbed toml for cassava/aoc18.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cassava/aoc18.rs/Cargo.toml
[INFO] crate cassava/aoc18.rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cassava/aoc18.rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cassava/aoc18.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6a89d267c309d124f579f1da35b1dd6cee7471272543d1428c599614cd213d58
[INFO] running `"docker" "start" "-a" "6a89d267c309d124f579f1da35b1dd6cee7471272543d1428c599614cd213d58"`
[INFO] [stderr]     Checking aoc18 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn to_str(&mut self) -> &str {
[INFO] [stderr]    |                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn to_str(&mut self) -> &str {
[INFO] [stderr]    |                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/bin/03_sliceit.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/bin/03_sliceit.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/05_reduction.rs:142:16
[INFO] [stderr]     |
[INFO] [stderr] 142 | const PUZZLE: &'static str = "Alchemical Reduction";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/05_reduction.rs:143:15
[INFO] [stderr]     |
[INFO] [stderr] 143 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/bin/05_reduction.rs:126:14
[INFO] [stderr]     |
[INFO] [stderr] 126 |     for b in ('a' as u8)..=('z' as u8) {
[INFO] [stderr]     |              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/bin/05_reduction.rs:126:28
[INFO] [stderr]     |
[INFO] [stderr] 126 |     for b in ('a' as u8)..=('z' as u8) {
[INFO] [stderr]     |                            ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'z'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/01_calibration.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 | const PUZZLE: &'static str = "Chronal Calibration";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/01_calibration.rs:117:15
[INFO] [stderr]     |
[INFO] [stderr] 117 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/bin/01_calibration.rs:96:35
[INFO] [stderr]    |
[INFO] [stderr] 96 |     let frequency = changes.iter().fold(0, |acc, x| acc + x);
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/05_reduction.rs:142:16
[INFO] [stderr]     |
[INFO] [stderr] 142 | const PUZZLE: &'static str = "Alchemical Reduction";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/05_reduction.rs:143:15
[INFO] [stderr]     |
[INFO] [stderr] 143 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/03_sliceit.rs:276:16
[INFO] [stderr]     |
[INFO] [stderr] 276 | const PUZZLE: &'static str = "No Matter How You Slice It";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/03_sliceit.rs:277:15
[INFO] [stderr]     |
[INFO] [stderr] 277 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/bin/05_reduction.rs:126:14
[INFO] [stderr]     |
[INFO] [stderr] 126 |     for b in ('a' as u8)..=('z' as u8) {
[INFO] [stderr]     |              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'a'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/bin/05_reduction.rs:126:28
[INFO] [stderr]     |
[INFO] [stderr] 126 |     for b in ('a' as u8)..=('z' as u8) {
[INFO] [stderr]     |                            ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'z'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/01_calibration.rs:116:16
[INFO] [stderr]     |
[INFO] [stderr] 116 | const PUZZLE: &'static str = "Chronal Calibration";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/01_calibration.rs:117:15
[INFO] [stderr]     |
[INFO] [stderr] 117 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/bin/01_calibration.rs:96:35
[INFO] [stderr]    |
[INFO] [stderr] 96 |     let frequency = changes.iter().fold(0, |acc, x| acc + x);
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/02_inventory.rs:225:16
[INFO] [stderr]     |
[INFO] [stderr] 225 | const PUZZLE: &'static str = "Inventory Management System";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/02_inventory.rs:226:15
[INFO] [stderr]     |
[INFO] [stderr] 226 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/02_inventory.rs:225:16
[INFO] [stderr]     |
[INFO] [stderr] 225 | const PUZZLE: &'static str = "Inventory Management System";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/02_inventory.rs:226:15
[INFO] [stderr]     |
[INFO] [stderr] 226 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `collection`.
[INFO] [stderr]    --> src/bin/02_inventory.rs:104:18
[INFO] [stderr]     |
[INFO] [stderr] 104 |         for j in (i + 1)..n {
[INFO] [stderr]     |                  ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 104 |         for <item> in collection.iter().take(n).skip((i + 1)) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `collection`.
[INFO] [stderr]    --> src/bin/02_inventory.rs:104:18
[INFO] [stderr]     |
[INFO] [stderr] 104 |         for j in (i + 1)..n {
[INFO] [stderr]     |                  ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 104 |         for <item> in collection.iter().take(n).skip((i + 1)) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/03_sliceit.rs:276:16
[INFO] [stderr]     |
[INFO] [stderr] 276 | const PUZZLE: &'static str = "No Matter How You Slice It";
[INFO] [stderr]     |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/bin/03_sliceit.rs:277:15
[INFO] [stderr]     |
[INFO] [stderr] 277 | const INPUT: &'static str = r"
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.21s
[INFO] running `"docker" "inspect" "6a89d267c309d124f579f1da35b1dd6cee7471272543d1428c599614cd213d58"`
[INFO] running `"docker" "rm" "-f" "6a89d267c309d124f579f1da35b1dd6cee7471272543d1428c599614cd213d58"`
[INFO] [stdout] 6a89d267c309d124f579f1da35b1dd6cee7471272543d1428c599614cd213d58