[INFO] updating cached repository casperin/rust_jazz_reader [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/casperin/rust_jazz_reader [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/casperin/rust_jazz_reader" "work/ex/clippy-test-run/sources/stable/gh/casperin/rust_jazz_reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/casperin/rust_jazz_reader'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/casperin/rust_jazz_reader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casperin/rust_jazz_reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casperin/rust_jazz_reader'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ed07d0e14339548a51d66bcf01f0894a17e9f1c [INFO] sha for GitHub repo casperin/rust_jazz_reader: 3ed07d0e14339548a51d66bcf01f0894a17e9f1c [INFO] validating manifest of casperin/rust_jazz_reader on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of casperin/rust_jazz_reader on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing casperin/rust_jazz_reader [INFO] finished frobbing casperin/rust_jazz_reader [INFO] frobbed toml for casperin/rust_jazz_reader written to work/ex/clippy-test-run/sources/stable/gh/casperin/rust_jazz_reader/Cargo.toml [INFO] started frobbing casperin/rust_jazz_reader [INFO] finished frobbing casperin/rust_jazz_reader [INFO] frobbed toml for casperin/rust_jazz_reader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casperin/rust_jazz_reader/Cargo.toml [INFO] crate casperin/rust_jazz_reader has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting casperin/rust_jazz_reader against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/casperin/rust_jazz_reader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6bf6893645a8c8d49ff8a5a0731b06b0ca27eaa310d4be481fb76bd200393313 [INFO] running `"docker" "start" "-a" "6bf6893645a8c8d49ff8a5a0731b06b0ca27eaa310d4be481fb76bd200393313"` [INFO] [stderr] Compiling askama_shared v0.7.0 [INFO] [stderr] Checking socket2 v0.3.7 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling nom v4.0.0 [INFO] [stderr] Compiling serde_json v1.0.21 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.69 [INFO] [stderr] Compiling askama_derive v0.7.0 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.5 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking config v0.7.1 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Checking askama v0.7.0 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Compiling cargo_metadata v0.5.6 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling actix v0.5.8 [INFO] [stderr] Checking actix-web v0.6.14 [INFO] [stderr] Checking jazz_reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/feeds_.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/feeds_.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(feed) => go::render(&PreviewFeedsTpl { feed: feed }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `feed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/index_.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/middleware.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | MustBeLoggedIn { allowed: allowed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `allowed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/saved_.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/saved_.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | urls: urls, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `urls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rss/feed.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rss/feed.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/feeds_.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/feeds_.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(feed) => go::render(&PreviewFeedsTpl { feed: feed }), [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `feed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/index_.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/middleware.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | MustBeLoggedIn { allowed: allowed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `allowed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/saved_.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | posts: posts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `posts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handlers/saved_.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | urls: urls, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `urls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rss/feed.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rss/feed.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/handlers/saved_.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | (params, state): (Query>, State), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn saved( [INFO] [stderr] 33 | (params, state): (Query>, State), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/handlers/saved_.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | for id_str in params.ids.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/handlers/saved_.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | (params, state): (Query>, State), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn saved( [INFO] [stderr] 33 | (params, state): (Query>, State), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/handlers/saved_.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | for id_str in params.ids.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rss/feed.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn fetch(url: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rss/feed.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | fn to_post(feed_url: &String, item: &rss::Item) -> Post { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .unwrap_or(String::from("[No title]")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("[No title]"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(feed_url.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| feed_url.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .unwrap_or(format!("{}-{}", title, link)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}-{}", title, link))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/rss/feed.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | author: item.author() [INFO] [stderr] | _________________^ [INFO] [stderr] 46 | | .map(|s| s.to_string()) [INFO] [stderr] 47 | | .unwrap_or(String::new()), [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | author: item.author() [INFO] [stderr] 46 | .map(|s| s.to_string()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/rss/feed.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | content: item.content() [INFO] [stderr] | __________________^ [INFO] [stderr] 49 | | .or(item.description()) [INFO] [stderr] 50 | | .map(|s| s.to_string()) [INFO] [stderr] 51 | | .unwrap_or(String::new()), [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | content: item.content() [INFO] [stderr] 49 | .or(item.description()) [INFO] [stderr] 50 | .map(|s| s.to_string()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .or(item.description()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| item.description())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rss/feed.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn fetch(url: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rss/feed.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | fn to_post(feed_url: &String, item: &rss::Item) -> Post { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | .unwrap_or(String::from("[No title]")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("[No title]"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(feed_url.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| feed_url.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .unwrap_or(format!("{}-{}", title, link)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}-{}", title, link))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/rss/feed.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | author: item.author() [INFO] [stderr] | _________________^ [INFO] [stderr] 46 | | .map(|s| s.to_string()) [INFO] [stderr] 47 | | .unwrap_or(String::new()), [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | author: item.author() [INFO] [stderr] 46 | .map(|s| s.to_string()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/rss/feed.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | content: item.content() [INFO] [stderr] | __________________^ [INFO] [stderr] 49 | | .or(item.description()) [INFO] [stderr] 50 | | .map(|s| s.to_string()) [INFO] [stderr] 51 | | .unwrap_or(String::new()), [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | content: item.content() [INFO] [stderr] 49 | .or(item.description()) [INFO] [stderr] 50 | .map(|s| s.to_string()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/rss/feed.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .or(item.description()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| item.description())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 26s [INFO] running `"docker" "inspect" "6bf6893645a8c8d49ff8a5a0731b06b0ca27eaa310d4be481fb76bd200393313"` [INFO] running `"docker" "rm" "-f" "6bf6893645a8c8d49ff8a5a0731b06b0ca27eaa310d4be481fb76bd200393313"` [INFO] [stdout] 6bf6893645a8c8d49ff8a5a0731b06b0ca27eaa310d4be481fb76bd200393313