[INFO] updating cached repository caspark/rocksy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/caspark/rocksy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/caspark/rocksy" "work/ex/clippy-test-run/sources/stable/gh/caspark/rocksy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/caspark/rocksy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/caspark/rocksy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caspark/rocksy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caspark/rocksy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 80511a4939c25324ac85f5bbc3be30529c094789 [INFO] sha for GitHub repo caspark/rocksy: 80511a4939c25324ac85f5bbc3be30529c094789 [INFO] validating manifest of caspark/rocksy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caspark/rocksy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caspark/rocksy [INFO] finished frobbing caspark/rocksy [INFO] frobbed toml for caspark/rocksy written to work/ex/clippy-test-run/sources/stable/gh/caspark/rocksy/Cargo.toml [INFO] started frobbing caspark/rocksy [INFO] finished frobbing caspark/rocksy [INFO] frobbed toml for caspark/rocksy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caspark/rocksy/Cargo.toml [INFO] crate caspark/rocksy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caspark/rocksy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/caspark/rocksy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b9f3aed8b89adc0c164646248961ed1f7a5636d1a33a577c4d0ae93c575b7f15 [INFO] running `"docker" "start" "-a" "b9f3aed8b89adc0c164646248961ed1f7a5636d1a33a577c4d0ae93c575b7f15"` [INFO] [stderr] Checking regex-syntax v0.5.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.13 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking regex v0.2.7 [INFO] [stderr] Checking hyper v0.11.22 [INFO] [stderr] Checking rocksy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | name.unwrap_or(address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| address.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/proxy.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / if let Some(target) = target_uri.parse::().ok() { [INFO] [stderr] 155 | | request.headers_mut().remove::(); [INFO] [stderr] 156 | | request.set_uri(target); [INFO] [stderr] 157 | | } else { [INFO] [stderr] 158 | | eprintln!("Failed to build request url for {:?}", &request) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(target)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/proxy.rs:204:57 [INFO] [stderr] | [INFO] [stderr] 204 | log_request_response(&incoming, target.name().as_ref(), response.status()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | name.unwrap_or(address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| address.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/proxy.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / if let Some(target) = target_uri.parse::().ok() { [INFO] [stderr] 155 | | request.headers_mut().remove::(); [INFO] [stderr] 156 | | request.set_uri(target); [INFO] [stderr] 157 | | } else { [INFO] [stderr] 158 | | eprintln!("Failed to build request url for {:?}", &request) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(target)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/proxy.rs:204:57 [INFO] [stderr] | [INFO] [stderr] 204 | log_request_response(&incoming, target.name().as_ref(), response.status()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `target.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.11s [INFO] running `"docker" "inspect" "b9f3aed8b89adc0c164646248961ed1f7a5636d1a33a577c4d0ae93c575b7f15"` [INFO] running `"docker" "rm" "-f" "b9f3aed8b89adc0c164646248961ed1f7a5636d1a33a577c4d0ae93c575b7f15"` [INFO] [stdout] b9f3aed8b89adc0c164646248961ed1f7a5636d1a33a577c4d0ae93c575b7f15