[INFO] updating cached repository casey/just [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/casey/just [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/casey/just" "work/ex/clippy-test-run/sources/stable/gh/casey/just"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/casey/just'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/casey/just" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casey/just"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casey/just'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d67786aaf7d8794b1977bba188b8b8602d28790 [INFO] sha for GitHub repo casey/just: 3d67786aaf7d8794b1977bba188b8b8602d28790 [INFO] validating manifest of casey/just on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of casey/just on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing casey/just [INFO] finished frobbing casey/just [INFO] frobbed toml for casey/just written to work/ex/clippy-test-run/sources/stable/gh/casey/just/Cargo.toml [INFO] started frobbing casey/just [INFO] finished frobbing casey/just [INFO] frobbed toml for casey/just written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/casey/just/Cargo.toml [INFO] crate casey/just has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting casey/just against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/casey/just:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d04fd41ece56e3a631554aaf98ce9b65701e5f5a03fb61a07d9f74588c03677e [INFO] running `"docker" "start" "-a" "d04fd41ece56e3a631554aaf98ce9b65701e5f5a03fb61a07d9f74588c03677e"` [INFO] [stderr] Checking target v1.0.0 [INFO] [stderr] Checking executable-path v1.0.0 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking brev v0.1.14 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking just v0.3.13 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/justfile.rs:448:9 [INFO] [stderr] | [INFO] [stderr] 448 | code: _, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Code { line_number, recipe, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:324:29 [INFO] [stderr] | [INFO] [stderr] 324 | (prefix, &self.rest[start..content_end + 1], StringToken) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start..=content_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/recipe.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | self.min_arguments()..self.max_arguments() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.min_arguments()..=self.max_arguments()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:324:29 [INFO] [stderr] | [INFO] [stderr] 324 | (prefix, &self.rest[start..content_end + 1], StringToken) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start..=content_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/recipe.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | self.min_arguments()..self.max_arguments() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.min_arguments()..=self.max_arguments()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.05s [INFO] running `"docker" "inspect" "d04fd41ece56e3a631554aaf98ce9b65701e5f5a03fb61a07d9f74588c03677e"` [INFO] running `"docker" "rm" "-f" "d04fd41ece56e3a631554aaf98ce9b65701e5f5a03fb61a07d9f74588c03677e"` [INFO] [stdout] d04fd41ece56e3a631554aaf98ce9b65701e5f5a03fb61a07d9f74588c03677e