[INFO] updating cached repository carols10cents/harvey-holt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/carols10cents/harvey-holt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/carols10cents/harvey-holt" "work/ex/clippy-test-run/sources/stable/gh/carols10cents/harvey-holt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carols10cents/harvey-holt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/carols10cents/harvey-holt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carols10cents/harvey-holt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carols10cents/harvey-holt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0166ca051e8c4a8a0011b543955f7106361350a5 [INFO] sha for GitHub repo carols10cents/harvey-holt: 0166ca051e8c4a8a0011b543955f7106361350a5 [INFO] validating manifest of carols10cents/harvey-holt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carols10cents/harvey-holt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carols10cents/harvey-holt [INFO] finished frobbing carols10cents/harvey-holt [INFO] frobbed toml for carols10cents/harvey-holt written to work/ex/clippy-test-run/sources/stable/gh/carols10cents/harvey-holt/Cargo.toml [INFO] started frobbing carols10cents/harvey-holt [INFO] finished frobbing carols10cents/harvey-holt [INFO] frobbed toml for carols10cents/harvey-holt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carols10cents/harvey-holt/Cargo.toml [INFO] crate carols10cents/harvey-holt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carols10cents/harvey-holt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carols10cents/harvey-holt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46743ef05bd1495a8aa083fed340bb04b6cd1e452273fece69498cedfa82a659 [INFO] running `"docker" "start" "-a" "46743ef05bd1495a8aa083fed340bb04b6cd1e452273fece69498cedfa82a659"` [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking libflate v0.1.5 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Compiling derive-error-chain v0.10.0 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking hyper v0.10.9 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Checking dotenv v0.10.0 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking reqwest v0.5.2 [INFO] [stderr] Checking mammut v0.6.0 [INFO] [stderr] Checking harvey-holt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 195 | | if city.longitude < 0.0 { [INFO] [stderr] 196 | | Either::Right(city) [INFO] [stderr] 197 | | } else { [INFO] [stderr] 198 | | Either::Left(city) [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | } else if city.longitude < 0.0 { [INFO] [stderr] 195 | Either::Right(city) [INFO] [stderr] 196 | } else { [INFO] [stderr] 197 | Either::Left(city) [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | cities [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | let cities = sort_easterly(cities, longitude); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | cities [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | let cities = sort_northerly(cities, latitude, longitude); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 195 | | if city.longitude < 0.0 { [INFO] [stderr] 196 | | Either::Right(city) [INFO] [stderr] 197 | | } else { [INFO] [stderr] 198 | | Either::Left(city) [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | } else if city.longitude < 0.0 { [INFO] [stderr] 195 | Either::Right(city) [INFO] [stderr] 196 | } else { [INFO] [stderr] 197 | Either::Left(city) [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | cities [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | let cities = sort_easterly(cities, longitude); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | cities [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | let cities = sort_northerly(cities, latitude, longitude); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | let lat = 40.4299986; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | let lat = 40.4299986; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:300:19 [INFO] [stderr] | [INFO] [stderr] 300 | let lat = 40.4299986; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:301:21 [INFO] [stderr] | [INFO] [stderr] 301 | let long = -79.99998539; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | latitude: 40.4299986, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | longitude: -79.99998539, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:338:23 [INFO] [stderr] | [INFO] [stderr] 338 | latitude: 7.518958353, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `7.518_958_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:339:25 [INFO] [stderr] | [INFO] [stderr] 339 | longitude: -78.16601465, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `78.166_014_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:355:21 [INFO] [stderr] | [INFO] [stderr] 355 | let long = -79.99998539; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | 100.00001461 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `100.000_014_61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | -100.00001461 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `100.000_014_61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | let long = -79.99998539; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | let long = -79.99998539; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:397:19 [INFO] [stderr] | [INFO] [stderr] 397 | let lat = 40.4299986; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | let long = -79.99998539; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:416:23 [INFO] [stderr] | [INFO] [stderr] 416 | latitude: 40.4299986, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:417:25 [INFO] [stderr] | [INFO] [stderr] 417 | longitude: -79.99998539, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:435:23 [INFO] [stderr] | [INFO] [stderr] 435 | latitude: 7.518958353, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `7.518_958_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:436:25 [INFO] [stderr] | [INFO] [stderr] 436 | longitude: -78.16601465, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `78.166_014_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:454:23 [INFO] [stderr] | [INFO] [stderr] 454 | latitude: 40.4299986, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `40.429_998_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:455:25 [INFO] [stderr] | [INFO] [stderr] 455 | longitude: -79.99998539, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79.999_985_39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:478:23 [INFO] [stderr] | [INFO] [stderr] 478 | latitude: 7.518958353, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `7.518_958_353` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:479:25 [INFO] [stderr] | [INFO] [stderr] 479 | longitude: -78.16601465, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `78.166_014_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.85s [INFO] running `"docker" "inspect" "46743ef05bd1495a8aa083fed340bb04b6cd1e452273fece69498cedfa82a659"` [INFO] running `"docker" "rm" "-f" "46743ef05bd1495a8aa083fed340bb04b6cd1e452273fece69498cedfa82a659"` [INFO] [stdout] 46743ef05bd1495a8aa083fed340bb04b6cd1e452273fece69498cedfa82a659