[INFO] updating cached repository carlosmn/aoc2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/carlosmn/aoc2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/carlosmn/aoc2017" "work/ex/clippy-test-run/sources/stable/gh/carlosmn/aoc2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carlosmn/aoc2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/carlosmn/aoc2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosmn/aoc2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosmn/aoc2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d979c2476d911aad546d92c9d02d10b14a5f0788 [INFO] sha for GitHub repo carlosmn/aoc2017: d979c2476d911aad546d92c9d02d10b14a5f0788 [INFO] validating manifest of carlosmn/aoc2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carlosmn/aoc2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carlosmn/aoc2017 [INFO] finished frobbing carlosmn/aoc2017 [INFO] frobbed toml for carlosmn/aoc2017 written to work/ex/clippy-test-run/sources/stable/gh/carlosmn/aoc2017/Cargo.toml [INFO] started frobbing carlosmn/aoc2017 [INFO] finished frobbing carlosmn/aoc2017 [INFO] frobbed toml for carlosmn/aoc2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosmn/aoc2017/Cargo.toml [INFO] crate carlosmn/aoc2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carlosmn/aoc2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carlosmn/aoc2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86f1c36ab04a0fd190dacee6f06e244d7a0c75db3044a32a899d13ede606e218 [INFO] running `"docker" "start" "-a" "86f1c36ab04a0fd190dacee6f06e244d7a0c75db3044a32a899d13ede606e218"` [INFO] [stderr] Checking aoc2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | reg: reg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc12.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc13.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc13.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/aoc10.rs:43:43 [INFO] [stderr] | [INFO] [stderr] 43 | reverse_range(&mut list, pos, len.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | fn to_u8(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | fn dense_hash(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | fn to_hex(v: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc12.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc13.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | const SAMPLE_INPUT: &'static str = r#"0: 3 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] | -^^^^^^^------------------------- help: consider removing `'static`: `&[&'static [Option]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:2:38 [INFO] [stderr] | [INFO] [stderr] 2 | const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static [u64]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | const INPUT: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static [u64]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const INPUT: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/aoc13.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | for (_k, v) in f { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 89 | for v in f.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/aoc13.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(3, f.get(&0).unwrap().range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&f[&0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/aoc13.rs:120:23 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(2, f.get(&1).unwrap().range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&f[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/aoc13.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(4, f.get(&4).unwrap().range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&f[&4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/aoc13.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(4, f.get(&6).unwrap().range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&f[&6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_SPREADSHEET` [INFO] [stderr] --> src/bin/aoc2.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] 3 | | &[Some(5), Some(1), Some(9), Some(5)], [INFO] [stderr] 4 | | &[Some(7), Some(5), Some(3), None], [INFO] [stderr] 5 | | &[Some(2), Some(4), Some(6), Some(8)], [INFO] [stderr] 6 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_SPREADSHEET1` [INFO] [stderr] --> src/bin/aoc2.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] 9 | | &[5, 9, 2, 8], [INFO] [stderr] 10 | | &[9, 4, 7, 3], [INFO] [stderr] 11 | | &[3, 8, 6, 5], [INFO] [stderr] 12 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `row`. [INFO] [stderr] --> src/bin/aoc2.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for j in i+1..row.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in row.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/bin/aoc3.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let r = ring_number(m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc7.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc7.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | above: above, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `above` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] | -^^^^^^^------------------------- help: consider removing `'static`: `&[&'static [Option]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:2:38 [INFO] [stderr] | [INFO] [stderr] 2 | const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static [u64]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | const INPUT: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static [u64]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/aoc2.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const INPUT: &'static [&'static [u64]] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `words`. [INFO] [stderr] --> src/bin/aoc4.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for j in i+1..words.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in words.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `words`. [INFO] [stderr] --> src/bin/aoc4.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for j in i+1..words.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in words.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc6.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc6.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_SPREADSHEET` [INFO] [stderr] --> src/bin/aoc2.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / const SAMPLE_SPREADSHEET: &'static [&'static [Option]] = &[ [INFO] [stderr] 3 | | &[Some(5), Some(1), Some(9), Some(5)], [INFO] [stderr] 4 | | &[Some(7), Some(5), Some(3), None], [INFO] [stderr] 5 | | &[Some(2), Some(4), Some(6), Some(8)], [INFO] [stderr] 6 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SAMPLE_SPREADSHEET1` [INFO] [stderr] --> src/bin/aoc2.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / const SAMPLE_SPREADSHEET1: &'static [&'static [u64]] = &[ [INFO] [stderr] 9 | | &[5, 9, 2, 8], [INFO] [stderr] 10 | | &[9, 4, 7, 3], [INFO] [stderr] 11 | | &[3, 8, 6, 5], [INFO] [stderr] 12 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `row`. [INFO] [stderr] --> src/bin/aoc2.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | for j in i+1..row.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in row.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | reg: reg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc8.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc7.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc7.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | above: above, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `above` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/bin/aoc6.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if cycles.iter().find(|&v| next == *v).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&v| next == *v).is_some()` with `any(|&v| next == *v)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/aoc6.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | i = i % c.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `i %= c.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `words`. [INFO] [stderr] --> src/bin/aoc4.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for j in i+1..words.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in words.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `words`. [INFO] [stderr] --> src/bin/aoc4.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for j in i+1..words.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in words.iter().skip(i+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc3.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return b - a [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `b - a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc3.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return a - b [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `a - b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/bin/aoc3.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let r = ring_number(m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc6.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc6.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/aoc1.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|(i, _ch)| u64::from_str_radix(&input[i..i+1], 10).expect("an integer")) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/aoc10.rs:43:43 [INFO] [stderr] | [INFO] [stderr] 43 | reverse_range(&mut list, pos, len.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | fn to_u8(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | fn dense_hash(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/aoc10.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | fn to_hex(v: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/bin/aoc6.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if cycles.iter().find(|&v| next == *v).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&v| next == *v).is_some()` with `any(|&v| next == *v)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/aoc6.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | i = i % c.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `i %= c.len()` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc13.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoc13.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/aoc7.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | for ref above in &p.above { [INFO] [stderr] | ^^^^^^^^^ -------- help: try: `let above = &&p.above;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc3.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return b - a [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `b - a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/aoc3.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return a - b [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `a - b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/aoc7.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | for ref above in &p.above { [INFO] [stderr] | ^^^^^^^^^ -------- help: try: `let above = &&p.above;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/aoc13.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | for (_k, v) in f { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 89 | for v in f.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{}"` [INFO] [stderr] ... [INFO] [stderr] 60 | count_string!(1, "{}"); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{{}}}"` [INFO] [stderr] ... [INFO] [stderr] 61 | count_string!(6, "{{{}}}"); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{{},{},{{}}}}"` [INFO] [stderr] ... [INFO] [stderr] 62 | count_string!(16, "{{{},{},{{}}}}"); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{,,,}"` [INFO] [stderr] ... [INFO] [stderr] 63 | count_string!(1, "{,,,}"); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{},{},{},{}}"` [INFO] [stderr] ... [INFO] [stderr] 64 | count_string!(9, "{{},{},{},{}}"); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{},{},{},{}}"` [INFO] [stderr] ... [INFO] [stderr] 65 | count_string!(9, "{{},{},{},{}}"); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{{},{},{},{}}"` [INFO] [stderr] ... [INFO] [stderr] 66 | count_string!(3, "{{},{},{},{}}"); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"<>"` [INFO] [stderr] ... [INFO] [stderr] 72 | count_noncancelled_string!(0, "<>"); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 73 | count_noncancelled_string!(17, ""); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"<<<<>"` [INFO] [stderr] ... [INFO] [stderr] 74 | count_noncancelled_string!(3, "<<<<>"); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"<{!>}>"` [INFO] [stderr] ... [INFO] [stderr] 75 | count_noncancelled_string!(2, "<{!>}>"); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 76 | count_noncancelled_string!(0, ""); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">"` [INFO] [stderr] ... [INFO] [stderr] 77 | count_noncancelled_string!(0, ">"); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/aoc9.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!($x, count_score(Cursor::new($y.as_bytes())).1) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br#"<{o"i!a,<{i"#` [INFO] [stderr] ... [INFO] [stderr] 78 | count_noncancelled_string!(10, r#"<{o"i!a,<{i"#); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/aoc1.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|(i, _ch)| u64::from_str_radix(&input[i..i+1], 10).expect("an integer")) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.48s [INFO] running `"docker" "inspect" "86f1c36ab04a0fd190dacee6f06e244d7a0c75db3044a32a899d13ede606e218"` [INFO] running `"docker" "rm" "-f" "86f1c36ab04a0fd190dacee6f06e244d7a0c75db3044a32a899d13ede606e218"` [INFO] [stdout] 86f1c36ab04a0fd190dacee6f06e244d7a0c75db3044a32a899d13ede606e218