[INFO] updating cached repository carlosgaldino/emacs-error [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/carlosgaldino/emacs-error [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/carlosgaldino/emacs-error" "work/ex/clippy-test-run/sources/stable/gh/carlosgaldino/emacs-error"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carlosgaldino/emacs-error'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/carlosgaldino/emacs-error" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosgaldino/emacs-error"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosgaldino/emacs-error'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d3676e90e4822c8912967d9c73e34b730595d1de [INFO] sha for GitHub repo carlosgaldino/emacs-error: d3676e90e4822c8912967d9c73e34b730595d1de [INFO] validating manifest of carlosgaldino/emacs-error on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carlosgaldino/emacs-error on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carlosgaldino/emacs-error [INFO] finished frobbing carlosgaldino/emacs-error [INFO] frobbed toml for carlosgaldino/emacs-error written to work/ex/clippy-test-run/sources/stable/gh/carlosgaldino/emacs-error/Cargo.toml [INFO] started frobbing carlosgaldino/emacs-error [INFO] finished frobbing carlosgaldino/emacs-error [INFO] frobbed toml for carlosgaldino/emacs-error written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlosgaldino/emacs-error/Cargo.toml [INFO] crate carlosgaldino/emacs-error has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carlosgaldino/emacs-error against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carlosgaldino/emacs-error:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e270da26fdfaa9f4723b877895b8068d565a77fe718c95f9c0fa7517029af2a [INFO] running `"docker" "start" "-a" "5e270da26fdfaa9f4723b877895b8068d565a77fe718c95f9c0fa7517029af2a"` [INFO] [stderr] Checking emacs-error v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/utils.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | let file = File::open(path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | new_path [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | let new_path = match prefix { [INFO] [stderr] | ____________________^ [INFO] [stderr] 48 | | Some(p) => base.join(p).join(file_name), [INFO] [stderr] 49 | | None => base.join(relativized_path), [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | let file_name = path.file_name().unwrap_or(OsStr::new("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/utils.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | let file = File::open(path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | new_path [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | let new_path = match prefix { [INFO] [stderr] | ____________________^ [INFO] [stderr] 48 | | Some(p) => base.join(p).join(file_name), [INFO] [stderr] 49 | | None => base.join(relativized_path), [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | let file_name = path.file_name().unwrap_or(OsStr::new("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "5e270da26fdfaa9f4723b877895b8068d565a77fe718c95f9c0fa7517029af2a"` [INFO] running `"docker" "rm" "-f" "5e270da26fdfaa9f4723b877895b8068d565a77fe718c95f9c0fa7517029af2a"` [INFO] [stdout] 5e270da26fdfaa9f4723b877895b8068d565a77fe718c95f9c0fa7517029af2a