[INFO] updating cached repository carlmw/birbs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/carlmw/birbs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/carlmw/birbs" "work/ex/clippy-test-run/sources/stable/gh/carlmw/birbs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carlmw/birbs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/carlmw/birbs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlmw/birbs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlmw/birbs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef1f8f2b5b525fe766553ddaecdc18fd1f3ecfeb [INFO] sha for GitHub repo carlmw/birbs: ef1f8f2b5b525fe766553ddaecdc18fd1f3ecfeb [INFO] validating manifest of carlmw/birbs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carlmw/birbs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carlmw/birbs [INFO] finished frobbing carlmw/birbs [INFO] frobbed toml for carlmw/birbs written to work/ex/clippy-test-run/sources/stable/gh/carlmw/birbs/Cargo.toml [INFO] started frobbing carlmw/birbs [INFO] finished frobbing carlmw/birbs [INFO] frobbed toml for carlmw/birbs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlmw/birbs/Cargo.toml [INFO] crate carlmw/birbs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carlmw/birbs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carlmw/birbs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 935b018d4abec3097aee7aa50b418c61e8abc4bf4fd229ae725a5bb0c0fa8b99 [INFO] running `"docker" "start" "-a" "935b018d4abec3097aee7aa50b418c61e8abc4bf4fd229ae725a5bb0c0fa8b99"` [INFO] [stderr] Checking ntree v0.1.0 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling serde_json v1.0.17 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.25 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.25 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.25 [INFO] [stderr] Checking wasm-bindgen v0.2.25 [INFO] [stderr] Checking birbs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boid.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | QuadTreeRegion { x: x, y: y, width: wh, height: wh } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | QuadTreeRegion { x: x, y: y, width: wh, height: wh } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:214:36 [INFO] [stderr] | [INFO] [stderr] 214 | Boid { position: Vector2 { x: x, y: y }, velocity: Vector2 { x: 0.0, y: 0.0 }, color: "#ff0000".to_string() } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:214:42 [INFO] [stderr] | [INFO] [stderr] 214 | Boid { position: Vector2 { x: x, y: y }, velocity: Vector2 { x: 0.0, y: 0.0 }, color: "#ff0000".to_string() } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `boids` [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | QuadTreeRegion { x: x, y: y, width: wh, height: wh } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | QuadTreeRegion { x: x, y: y, width: wh, height: wh } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:214:36 [INFO] [stderr] | [INFO] [stderr] 214 | Boid { position: Vector2 { x: x, y: y }, velocity: Vector2 { x: 0.0, y: 0.0 }, color: "#ff0000".to_string() } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:214:42 [INFO] [stderr] | [INFO] [stderr] 214 | Boid { position: Vector2 { x: x, y: y }, velocity: Vector2 { x: 0.0, y: 0.0 }, color: "#ff0000".to_string() } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `boids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `all` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | BoidManager { boids: boids, all: all, count: count } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/boid.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | fn align(neighbours: &Vec<&Boid>) -> Vector2 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Boid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/boid.rs:82:41 [INFO] [stderr] | [INFO] [stderr] 82 | fn separate(current: &Boid, neighbours: &Vec<&Boid>) -> Vector2 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/boid.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | fn cohede(current: &Boid, neighbours: &Vec<&Boid>) -> Vector2 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error[E0560]: struct `boid::Boid` has no field named `color` [INFO] [stderr] --> src/tree.rs:214:88 [INFO] [stderr] | [INFO] [stderr] 214 | Boid { position: Vector2 { x: x, y: y }, velocity: Vector2 { x: 0.0, y: 0.0 }, color: "#ff0000".to_string() } [INFO] [stderr] | ^^^^^ `boid::Boid` does not have this field [INFO] [stderr] | [INFO] [stderr] = note: available fields are: `position`, `velocity` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0560`. [INFO] [stderr] error: Could not compile `birbs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "935b018d4abec3097aee7aa50b418c61e8abc4bf4fd229ae725a5bb0c0fa8b99"` [INFO] running `"docker" "rm" "-f" "935b018d4abec3097aee7aa50b418c61e8abc4bf4fd229ae725a5bb0c0fa8b99"` [INFO] [stdout] 935b018d4abec3097aee7aa50b418c61e8abc4bf4fd229ae725a5bb0c0fa8b99