[INFO] updating cached repository carlgreen/raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/carlgreen/raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/carlgreen/raytracer" "work/ex/clippy-test-run/sources/stable/gh/carlgreen/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carlgreen/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/carlgreen/raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlgreen/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlgreen/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7fb6a69357bb863c36fb0ffe9c189c56a1be5681 [INFO] sha for GitHub repo carlgreen/raytracer: 7fb6a69357bb863c36fb0ffe9c189c56a1be5681 [INFO] validating manifest of carlgreen/raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of carlgreen/raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing carlgreen/raytracer [INFO] finished frobbing carlgreen/raytracer [INFO] frobbed toml for carlgreen/raytracer written to work/ex/clippy-test-run/sources/stable/gh/carlgreen/raytracer/Cargo.toml [INFO] started frobbing carlgreen/raytracer [INFO] finished frobbing carlgreen/raytracer [INFO] frobbed toml for carlgreen/raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carlgreen/raytracer/Cargo.toml [INFO] crate carlgreen/raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting carlgreen/raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carlgreen/raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df99ea2e61a1b2db46aed755f735cec68e14ba04b9d5c127f9b252d2cffd8fc6 [INFO] running `"docker" "start" "-a" "df99ea2e61a1b2db46aed755f735cec68e14ba04b9d5c127f9b252d2cffd8fc6"` [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | u: u, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | lens_radius: lens_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lens_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | u: u, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | lens_radius: lens_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lens_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let delta = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if depth < 50 { [INFO] [stderr] 31 | | if yes { [INFO] [stderr] 32 | | return &attenuation * &color(scattered, hitable, depth + 1); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if depth < 50 && yes { [INFO] [stderr] 31 | return &attenuation * &color(scattered, hitable, depth + 1); [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let delta = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | r: 0.033333, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.033_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | g: 0.066666, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.066_666` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if depth < 50 { [INFO] [stderr] 31 | | if yes { [INFO] [stderr] 32 | | return &attenuation * &color(scattered, hitable, depth + 1); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if depth < 50 && yes { [INFO] [stderr] 31 | return &attenuation * &color(scattered, hitable, depth + 1); [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | let u = (i as f64 + rand::random::()) / nx as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:62 [INFO] [stderr] | [INFO] [stderr] 181 | let u = (i as f64 + rand::random::()) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | let v = (j as f64 + rand::random::()) / ny as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:62 [INFO] [stderr] | [INFO] [stderr] 182 | let v = (j as f64 + rand::random::()) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | col = col / ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | let ref mut fout = File::create(&Path::new("target/image.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("target/image.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | let u = (i as f64 + rand::random::()) / nx as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:62 [INFO] [stderr] | [INFO] [stderr] 181 | let u = (i as f64 + rand::random::()) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | let v = (j as f64 + rand::random::()) / ny as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:62 [INFO] [stderr] | [INFO] [stderr] 182 | let v = (j as f64 + rand::random::()) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | col = col / ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | let ref mut fout = File::create(&Path::new("target/image.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("target/image.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.86s [INFO] running `"docker" "inspect" "df99ea2e61a1b2db46aed755f735cec68e14ba04b9d5c127f9b252d2cffd8fc6"` [INFO] running `"docker" "rm" "-f" "df99ea2e61a1b2db46aed755f735cec68e14ba04b9d5c127f9b252d2cffd8fc6"` [INFO] [stdout] df99ea2e61a1b2db46aed755f735cec68e14ba04b9d5c127f9b252d2cffd8fc6