[INFO] updating cached repository cardil/rust-guessing-game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cardil/rust-guessing-game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cardil/rust-guessing-game" "work/ex/clippy-test-run/sources/stable/gh/cardil/rust-guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cardil/rust-guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cardil/rust-guessing-game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cardil/rust-guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cardil/rust-guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f326f0a23b4726d2590e83a7a98cafb08042b6b5 [INFO] sha for GitHub repo cardil/rust-guessing-game: f326f0a23b4726d2590e83a7a98cafb08042b6b5 [INFO] validating manifest of cardil/rust-guessing-game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cardil/rust-guessing-game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cardil/rust-guessing-game [INFO] finished frobbing cardil/rust-guessing-game [INFO] frobbed toml for cardil/rust-guessing-game written to work/ex/clippy-test-run/sources/stable/gh/cardil/rust-guessing-game/Cargo.toml [INFO] started frobbing cardil/rust-guessing-game [INFO] finished frobbing cardil/rust-guessing-game [INFO] frobbed toml for cardil/rust-guessing-game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cardil/rust-guessing-game/Cargo.toml [INFO] crate cardil/rust-guessing-game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cardil/rust-guessing-game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cardil/rust-guessing-game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b69be35b0ccc856009f0d514ca3ca02617bf27e4318e4ca901f471e08f05381a [INFO] running `"docker" "start" "-a" "b69be35b0ccc856009f0d514ca3ca02617bf27e4318e4ca901f471e08f05381a"` [INFO] [stderr] Checking guessing_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/secret.rs:5:3 [INFO] [stderr] | [INFO] [stderr] 5 | / return rand::thread_rng() [INFO] [stderr] 6 | | .gen_range(1, high) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 5 | rand::thread_rng() [INFO] [stderr] 6 | .gen_range(1, high) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/secret.rs:5:3 [INFO] [stderr] | [INFO] [stderr] 5 | / return rand::thread_rng() [INFO] [stderr] 6 | | .gen_range(1, high) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 5 | rand::thread_rng() [INFO] [stderr] 6 | .gen_range(1, high) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::View` [INFO] [stderr] --> src/view.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | use super::View; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | self.steps = self.steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.steps += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `out` [INFO] [stderr] --> src/view.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut out = String::new(); [INFO] [stderr] | ^^^ help: consider using `_out` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/view.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let mut out = String::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | self.steps = self.steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.steps += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "b69be35b0ccc856009f0d514ca3ca02617bf27e4318e4ca901f471e08f05381a"` [INFO] running `"docker" "rm" "-f" "b69be35b0ccc856009f0d514ca3ca02617bf27e4318e4ca901f471e08f05381a"` [INFO] [stdout] b69be35b0ccc856009f0d514ca3ca02617bf27e4318e4ca901f471e08f05381a