[INFO] updating cached repository carcharo/Chip8Emulator-Rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/carcharo/Chip8Emulator-Rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/carcharo/Chip8Emulator-Rust" "work/ex/clippy-test-run/sources/stable/gh/carcharo/Chip8Emulator-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/carcharo/Chip8Emulator-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/carcharo/Chip8Emulator-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carcharo/Chip8Emulator-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carcharo/Chip8Emulator-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 417572ec4456f958ce4a378e0c0657a11d48fa13
[INFO] sha for GitHub repo carcharo/Chip8Emulator-Rust: 417572ec4456f958ce4a378e0c0657a11d48fa13
[INFO] validating manifest of carcharo/Chip8Emulator-Rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of carcharo/Chip8Emulator-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing carcharo/Chip8Emulator-Rust
[INFO] finished frobbing carcharo/Chip8Emulator-Rust
[INFO] frobbed toml for carcharo/Chip8Emulator-Rust written to work/ex/clippy-test-run/sources/stable/gh/carcharo/Chip8Emulator-Rust/Cargo.toml
[INFO] started frobbing carcharo/Chip8Emulator-Rust
[INFO] finished frobbing carcharo/Chip8Emulator-Rust
[INFO] frobbed toml for carcharo/Chip8Emulator-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/carcharo/Chip8Emulator-Rust/Cargo.toml
[INFO] crate carcharo/Chip8Emulator-Rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting carcharo/Chip8Emulator-Rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/carcharo/Chip8Emulator-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c6cce0ec80919a81c5158935824bdad641bb4a8c82524c2b045c670e8a6fbf43
[INFO] running `"docker" "start" "-a" "c6cce0ec80919a81c5158935824bdad641bb4a8c82524c2b045c670e8a6fbf43"`
[INFO] [stderr]     Checking chip8_emulator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `address`
[INFO] [stderr]   --> src/memory.rs:42:34
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn write_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                  ^^^^^^^ help: consider using `_address` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]   --> src/memory.rs:42:48
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn write_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                                ^^^^^ help: consider using `_value` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `address`
[INFO] [stderr]   --> src/memory.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                 ^^^^^^^ help: consider using `_address` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]   --> src/memory.rs:46:47
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                               ^^^^^ help: consider using `_value` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `mem`
[INFO] [stderr]   --> src/memory.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     mem: [u8; 4096],
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_byte`
[INFO] [stderr]   --> src/memory.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chip8.rs:14:38
[INFO] [stderr]    |
[INFO] [stderr] 14 |     pub fn load_rom(&mut self, data: &Vec<u8>) {
[INFO] [stderr]    |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]   --> src/chip8.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         for i in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 16 |         for (i, <item>) in data.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `address`
[INFO] [stderr]   --> src/memory.rs:42:34
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn write_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                  ^^^^^^^ help: consider using `_address` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]   --> src/memory.rs:42:48
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn write_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                                ^^^^^ help: consider using `_value` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `address`
[INFO] [stderr]   --> src/memory.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                 ^^^^^^^ help: consider using `_address` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]   --> src/memory.rs:46:47
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |                                               ^^^^^ help: consider using `_value` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `mem`
[INFO] [stderr]   --> src/memory.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     mem: [u8; 4096],
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_byte`
[INFO] [stderr]   --> src/memory.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn read_byte(&mut self, address: u16, value: u8) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chip8.rs:14:38
[INFO] [stderr]    |
[INFO] [stderr] 14 |     pub fn load_rom(&mut self, data: &Vec<u8>) {
[INFO] [stderr]    |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]   --> src/chip8.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         for i in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 16 |         for (i, <item>) in data.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.68s
[INFO] running `"docker" "inspect" "c6cce0ec80919a81c5158935824bdad641bb4a8c82524c2b045c670e8a6fbf43"`
[INFO] running `"docker" "rm" "-f" "c6cce0ec80919a81c5158935824bdad641bb4a8c82524c2b045c670e8a6fbf43"`
[INFO] [stdout] c6cce0ec80919a81c5158935824bdad641bb4a8c82524c2b045c670e8a6fbf43