[INFO] updating cached repository camjackson/conway_rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/camjackson/conway_rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/camjackson/conway_rs" "work/ex/clippy-test-run/sources/stable/gh/camjackson/conway_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/camjackson/conway_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/camjackson/conway_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/camjackson/conway_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/camjackson/conway_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a5895769b2e96b41ef45f8cccc20b59c27dae3d8
[INFO] sha for GitHub repo camjackson/conway_rs: a5895769b2e96b41ef45f8cccc20b59c27dae3d8
[INFO] validating manifest of camjackson/conway_rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of camjackson/conway_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing camjackson/conway_rs
[INFO] finished frobbing camjackson/conway_rs
[INFO] frobbed toml for camjackson/conway_rs written to work/ex/clippy-test-run/sources/stable/gh/camjackson/conway_rs/Cargo.toml
[INFO] started frobbing camjackson/conway_rs
[INFO] finished frobbing camjackson/conway_rs
[INFO] frobbed toml for camjackson/conway_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/camjackson/conway_rs/Cargo.toml
[INFO] crate camjackson/conway_rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting camjackson/conway_rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/camjackson/conway_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d1e77da5dc4636db333f88b7a6917510d1bae375526c6c73964edb3be645f58f
[INFO] running `"docker" "start" "-a" "d1e77da5dc4636db333f88b7a6917510d1bae375526c6c73964edb3be645f58f"`
[INFO] [stderr]     Checking winapi v0.2.6
[INFO] [stderr]    Compiling bitflags v0.6.0
[INFO] [stderr]    Compiling libloading v0.2.2
[INFO] [stderr]     Checking libc v0.2.11
[INFO] [stderr]    Compiling gcc v0.3.28
[INFO] [stderr]     Checking crossbeam v0.2.9
[INFO] [stderr]     Checking byteorder v0.5.1
[INFO] [stderr]     Checking debug-builders v0.1.0
[INFO] [stderr]     Checking smallvec v0.1.7
[INFO] [stderr]    Compiling xml-rs v0.3.2
[INFO] [stderr]    Compiling tempfile v2.1.3
[INFO] [stderr]     Checking kernel32-sys v0.2.2
[INFO] [stderr]     Checking dbghelp-sys v0.2.0
[INFO] [stderr]     Checking rand v0.3.14
[INFO] [stderr]     Checking dylib v0.0.1
[INFO] [stderr]     Checking shared_library v0.1.4
[INFO] [stderr]     Checking fs2 v0.2.4
[INFO] [stderr]     Checking x11-dl v2.4.0
[INFO] [stderr]    Compiling backtrace-sys v0.1.4
[INFO] [stderr]     Checking memmap v0.2.3
[INFO] [stderr]     Checking dlib v0.3.0
[INFO] [stderr]     Checking osmesa-sys v0.0.5
[INFO] [stderr]     Checking wayland-sys v0.5.11
[INFO] [stderr]     Checking backtrace v0.1.8
[INFO] [stderr]    Compiling wayland-scanner v0.5.11
[INFO] [stderr]    Compiling gl_generator v0.5.1
[INFO] [stderr]    Compiling wayland-client v0.5.11
[INFO] [stderr]    Compiling glutin v0.5.1
[INFO] [stderr]    Compiling glium v0.14.0
[INFO] [stderr]     Checking wayland-window v0.2.3
[INFO] [stderr]     Checking wayland-kbd v0.3.5
[INFO] [stderr]     Checking conway_rs v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             cells: cells,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cell.rs:25:65
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Cell { x: 0., y: 0., scale: 1., neighbours: Vec::new(), alive: alive }
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^ help: replace it with: `alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             cells: cells,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cell.rs:25:65
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Cell { x: 0., y: 0., scale: 1., neighbours: Vec::new(), alive: alive }
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^ help: replace it with: `alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:1:22
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const FRAGMENT: &'static str = include_str!("../shaders/fragment.glsl");
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:2:20
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const VERTEX: &'static str = include_str!("../shaders/vertex.glsl");
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/square.rs:47:43
[INFO] [stderr]    |
[INFO] [stderr] 47 | pub fn instances(display: &Display, grid: &Vec<Cell>) -> VertexBufferAny {
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: change this to: `&[Cell]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     x: (x as f32 * square_size + square_size / 2.),
[INFO] [stderr]    |                         ^^^^^^^^ help: try: `f32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                     y: -(y as f32 * square_size + square_size / 2.),
[INFO] [stderr]    |                          ^^^^^^^^ help: try: `f32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:35:21
[INFO] [stderr]    |
[INFO] [stderr] 35 |         .with_title(format!("Hello, world!"))
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world!".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:1:22
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const FRAGMENT: &'static str = include_str!("../shaders/fragment.glsl");
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:2:20
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const VERTEX: &'static str = include_str!("../shaders/vertex.glsl");
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/square.rs:47:43
[INFO] [stderr]    |
[INFO] [stderr] 47 | pub fn instances(display: &Display, grid: &Vec<Cell>) -> VertexBufferAny {
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: change this to: `&[Cell]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     x: (x as f32 * square_size + square_size / 2.),
[INFO] [stderr]    |                         ^^^^^^^^ help: try: `f32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                     y: -(y as f32 * square_size + square_size / 2.),
[INFO] [stderr]    |                          ^^^^^^^^ help: try: `f32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/cell.rs:32:17
[INFO] [stderr]    |
[INFO] [stderr] 32 |         assert!(cell.alive == false);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/cell.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |         assert!(cell.alive == false);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/cell.rs:46:17
[INFO] [stderr]    |
[INFO] [stderr] 46 |         assert!(cell.alive == true);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/cell.rs:48:17
[INFO] [stderr]    |
[INFO] [stderr] 48 |         assert!(cell.alive == true);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/cell.rs:55:17
[INFO] [stderr]    |
[INFO] [stderr] 55 |         assert!(cell.alive == true);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/cell.rs:62:17
[INFO] [stderr]    |
[INFO] [stderr] 62 |         assert!(cell.alive == false);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/cell.rs:69:17
[INFO] [stderr]    |
[INFO] [stderr] 69 |         assert!(cell.alive == false);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!cell.alive`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:35:21
[INFO] [stderr]    |
[INFO] [stderr] 35 |         .with_title(format!("Hello, world!"))
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello, world!".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 41.83s
[INFO] running `"docker" "inspect" "d1e77da5dc4636db333f88b7a6917510d1bae375526c6c73964edb3be645f58f"`
[INFO] running `"docker" "rm" "-f" "d1e77da5dc4636db333f88b7a6917510d1bae375526c6c73964edb3be645f58f"`
[INFO] [stdout] d1e77da5dc4636db333f88b7a6917510d1bae375526c6c73964edb3be645f58f