[INFO] updating cached repository calum/rust_reddit_scraper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/calum/rust_reddit_scraper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/calum/rust_reddit_scraper" "work/ex/clippy-test-run/sources/stable/gh/calum/rust_reddit_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/calum/rust_reddit_scraper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/calum/rust_reddit_scraper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calum/rust_reddit_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calum/rust_reddit_scraper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb3f59a462830fbf73eef23761d261bc914c749f [INFO] sha for GitHub repo calum/rust_reddit_scraper: cb3f59a462830fbf73eef23761d261bc914c749f [INFO] validating manifest of calum/rust_reddit_scraper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of calum/rust_reddit_scraper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing calum/rust_reddit_scraper [INFO] finished frobbing calum/rust_reddit_scraper [INFO] frobbed toml for calum/rust_reddit_scraper written to work/ex/clippy-test-run/sources/stable/gh/calum/rust_reddit_scraper/Cargo.toml [INFO] started frobbing calum/rust_reddit_scraper [INFO] finished frobbing calum/rust_reddit_scraper [INFO] frobbed toml for calum/rust_reddit_scraper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calum/rust_reddit_scraper/Cargo.toml [INFO] crate calum/rust_reddit_scraper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting calum/rust_reddit_scraper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/calum/rust_reddit_scraper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c93ca7042d7bcd8e4c9b7f8cca9ba2cc03895027776531bda9ed9f5a2afd396e [INFO] running `"docker" "start" "-a" "c93ca7042d7bcd8e4c9b7f8cca9ba2cc03895027776531bda9ed9f5a2afd396e"` [INFO] [stderr] Compiling version_check v0.1.3 [INFO] [stderr] Compiling serde_derive_internals v0.18.0 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.24 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking mime v0.3.5 [INFO] [stderr] Checking hyper v0.11.9 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking rust_reddit_user_scraper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/api.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | api_method: api_method, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/api.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | access_token: access_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/authenticate.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requester.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/api.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | api_method: api_method, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/api.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | access_token: access_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reddit/authenticate.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/requester.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/requester.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | got [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/requester.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let got = core.run(get).expect("Failed to make get request"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/requester.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | posted [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/requester.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let posted = core.run(post).expect("Failed to make POST request"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/requester.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | got [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/requester.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let got = core.run(get).expect("Failed to make get request"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/requester.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | posted [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/requester.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | let posted = core.run(post).expect("Failed to make POST request"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `url` [INFO] [stderr] --> src/reddit/authenticate.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | url: String, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `posts`. [INFO] [stderr] --> src/reddit/mod.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for in posts.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `comments`. [INFO] [stderr] --> src/reddit/mod.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in comments.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `url` [INFO] [stderr] --> src/reddit/authenticate.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | url: String, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `posts`. [INFO] [stderr] --> src/reddit/mod.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for in posts.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `comments`. [INFO] [stderr] --> src/reddit/mod.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for in comments.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.64s [INFO] running `"docker" "inspect" "c93ca7042d7bcd8e4c9b7f8cca9ba2cc03895027776531bda9ed9f5a2afd396e"` [INFO] running `"docker" "rm" "-f" "c93ca7042d7bcd8e4c9b7f8cca9ba2cc03895027776531bda9ed9f5a2afd396e"` [INFO] [stdout] c93ca7042d7bcd8e4c9b7f8cca9ba2cc03895027776531bda9ed9f5a2afd396e