[INFO] updating cached repository calebzulawski/abi-helper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/calebzulawski/abi-helper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/calebzulawski/abi-helper" "work/ex/clippy-test-run/sources/stable/gh/calebzulawski/abi-helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/calebzulawski/abi-helper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/calebzulawski/abi-helper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calebzulawski/abi-helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calebzulawski/abi-helper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9cee7633d84658dca5dc5e6618e81645a9144a12 [INFO] sha for GitHub repo calebzulawski/abi-helper: 9cee7633d84658dca5dc5e6618e81645a9144a12 [INFO] validating manifest of calebzulawski/abi-helper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of calebzulawski/abi-helper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing calebzulawski/abi-helper [INFO] finished frobbing calebzulawski/abi-helper [INFO] frobbed toml for calebzulawski/abi-helper written to work/ex/clippy-test-run/sources/stable/gh/calebzulawski/abi-helper/Cargo.toml [INFO] started frobbing calebzulawski/abi-helper [INFO] finished frobbing calebzulawski/abi-helper [INFO] frobbed toml for calebzulawski/abi-helper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/calebzulawski/abi-helper/Cargo.toml [INFO] crate calebzulawski/abi-helper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting calebzulawski/abi-helper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/calebzulawski/abi-helper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a070331d8e29adf45606f1c984f5bbb2445178705e14bb3035f70ea470a64187 [INFO] running `"docker" "start" "-a" "a070331d8e29adf45606f1c984f5bbb2445178705e14bb3035f70ea470a64187"` [INFO] [stderr] Checking custom_error v1.3.0 [INFO] [stderr] Compiling scroll_derive v0.9.5 [INFO] [stderr] Checking scroll v0.9.2 [INFO] [stderr] Checking goblin v0.0.19 [INFO] [stderr] Checking abi-helper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/abi_reader.rs:234:21 [INFO] [stderr] | [INFO] [stderr] 234 | export_matching: export_matching, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_matching` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/abi_reader.rs:234:21 [INFO] [stderr] | [INFO] [stderr] 234 | export_matching: export_matching, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_matching` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | writeln!(f, "Exported:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | writeln!(f, "\t{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | writeln!(f, "Stripped:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | writeln!(f, "\t{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | writeln!(f, "Exported:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | writeln!(f, "\t{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | writeln!(f, "Stripped:"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/abi_reader.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | writeln!(f, "\t{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/abi_reader.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / loop { [INFO] [stderr] 249 | | if let Some(symbol) = symbols.pop() { [INFO] [stderr] 250 | | if self.regex.is_match(&symbol) { [INFO] [stderr] 251 | | matched.push(symbol); [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(symbol) = symbols.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/abi_reader.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / loop { [INFO] [stderr] 249 | | if let Some(symbol) = symbols.pop() { [INFO] [stderr] 250 | | if self.regex.is_match(&symbol) { [INFO] [stderr] 251 | | matched.push(symbol); [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(symbol) = symbols.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.98s [INFO] running `"docker" "inspect" "a070331d8e29adf45606f1c984f5bbb2445178705e14bb3035f70ea470a64187"` [INFO] running `"docker" "rm" "-f" "a070331d8e29adf45606f1c984f5bbb2445178705e14bb3035f70ea470a64187"` [INFO] [stdout] a070331d8e29adf45606f1c984f5bbb2445178705e14bb3035f70ea470a64187