[INFO] updating cached repository caldwell/http-log-to-statsd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/caldwell/http-log-to-statsd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/caldwell/http-log-to-statsd" "work/ex/clippy-test-run/sources/stable/gh/caldwell/http-log-to-statsd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/caldwell/http-log-to-statsd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/caldwell/http-log-to-statsd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caldwell/http-log-to-statsd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caldwell/http-log-to-statsd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] edfe746898eb08df083bbe37790808df39c3d165 [INFO] sha for GitHub repo caldwell/http-log-to-statsd: edfe746898eb08df083bbe37790808df39c3d165 [INFO] validating manifest of caldwell/http-log-to-statsd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caldwell/http-log-to-statsd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caldwell/http-log-to-statsd [INFO] finished frobbing caldwell/http-log-to-statsd [INFO] frobbed toml for caldwell/http-log-to-statsd written to work/ex/clippy-test-run/sources/stable/gh/caldwell/http-log-to-statsd/Cargo.toml [INFO] started frobbing caldwell/http-log-to-statsd [INFO] finished frobbing caldwell/http-log-to-statsd [INFO] frobbed toml for caldwell/http-log-to-statsd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caldwell/http-log-to-statsd/Cargo.toml [INFO] crate caldwell/http-log-to-statsd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caldwell/http-log-to-statsd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/caldwell/http-log-to-statsd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7f2b48a774b17f8b55dd211e15a708a00f77dfd1da5c1fa5fe5d29bf8e38494 [INFO] running `"docker" "start" "-a" "c7f2b48a774b17f8b55dd211e15a708a00f77dfd1da5c1fa5fe5d29bf8e38494"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking cadence v0.8.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking http-log-to-statsd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Parser` [INFO] [stderr] --> http-log-to-statsd.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> Parser { [INFO] [stderr] 82 | | Parser{suffix: "".to_string()} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> http-log-to-statsd.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if field.len() == 0 { return Ok(None) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | if s.starts_with("'") && s.ends_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:158:42 [INFO] [stderr] | [INFO] [stderr] 158 | if s.starts_with("'") && s.ends_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | if value.contains("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Parser` [INFO] [stderr] --> http-log-to-statsd.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> Parser { [INFO] [stderr] 82 | | Parser{suffix: "".to_string()} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> http-log-to-statsd.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if field.len() == 0 { return Ok(None) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | if s.starts_with("'") && s.ends_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:158:42 [INFO] [stderr] | [INFO] [stderr] 158 | if s.starts_with("'") && s.ends_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> http-log-to-statsd.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | if value.contains("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.99s [INFO] running `"docker" "inspect" "c7f2b48a774b17f8b55dd211e15a708a00f77dfd1da5c1fa5fe5d29bf8e38494"` [INFO] running `"docker" "rm" "-f" "c7f2b48a774b17f8b55dd211e15a708a00f77dfd1da5c1fa5fe5d29bf8e38494"` [INFO] [stdout] c7f2b48a774b17f8b55dd211e15a708a00f77dfd1da5c1fa5fe5d29bf8e38494