[INFO] updating cached repository caameron/Pixel-Converter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/caameron/Pixel-Converter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/caameron/Pixel-Converter" "work/ex/clippy-test-run/sources/stable/gh/caameron/Pixel-Converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/caameron/Pixel-Converter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/caameron/Pixel-Converter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caameron/Pixel-Converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caameron/Pixel-Converter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] daf0bb1ccb4fb8e861915cc7c734ff1521190310 [INFO] sha for GitHub repo caameron/Pixel-Converter: daf0bb1ccb4fb8e861915cc7c734ff1521190310 [INFO] validating manifest of caameron/Pixel-Converter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of caameron/Pixel-Converter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing caameron/Pixel-Converter [INFO] finished frobbing caameron/Pixel-Converter [INFO] frobbed toml for caameron/Pixel-Converter written to work/ex/clippy-test-run/sources/stable/gh/caameron/Pixel-Converter/Cargo.toml [INFO] started frobbing caameron/Pixel-Converter [INFO] finished frobbing caameron/Pixel-Converter [INFO] frobbed toml for caameron/Pixel-Converter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/caameron/Pixel-Converter/Cargo.toml [INFO] crate caameron/Pixel-Converter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting caameron/Pixel-Converter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/caameron/Pixel-Converter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c69147e8eb14913aaeeaaeb5561a94b8eb572299823963500a545e3351e40fc3 [INFO] running `"docker" "start" "-a" "c69147e8eb14913aaeeaaeb5561a94b8eb572299823963500a545e3351e40fc3"` [INFO] [stderr] Checking pixel-converter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/imagestruct.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return_image [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/imagestruct.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let return_image = MainImage { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 38 | | img: new_image, [INFO] [stderr] 39 | | width: img_width, [INFO] [stderr] 40 | | height: img_height, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/imagestruct.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return_self [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/imagestruct.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | let return_self = match degree.as_ref() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 124 | | "90" => self.rotate90_image(), [INFO] [stderr] 125 | | "180" => self.rotate180_image(), [INFO] [stderr] 126 | | "270" => self.rotate270_image(), [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/imagestruct.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return_image [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/imagestruct.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let return_image = MainImage { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 38 | | img: new_image, [INFO] [stderr] 39 | | width: img_width, [INFO] [stderr] 40 | | height: img_height, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/imagestruct.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return_self [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/imagestruct.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | let return_self = match degree.as_ref() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 124 | | "90" => self.rotate90_image(), [INFO] [stderr] 125 | | "180" => self.rotate180_image(), [INFO] [stderr] 126 | | "270" => self.rotate270_image(), [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/pixelate.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | big_pix = big_pix * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `big_pix *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:104:44 [INFO] [stderr] | [INFO] [stderr] 104 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:202:44 [INFO] [stderr] | [INFO] [stderr] 202 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | while continue_menu == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `continue_menu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/pixelate.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | big_pix = big_pix * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `big_pix *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:104:44 [INFO] [stderr] | [INFO] [stderr] 104 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:153:44 [INFO] [stderr] | [INFO] [stderr] 153 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | for neighbor_width in wid..wid + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `wid..=wid + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pixelate.rs:202:44 [INFO] [stderr] | [INFO] [stderr] 202 | for neighbor_height in hei..hei + big_pix + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `hei..=hei + big_pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | while continue_menu == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `continue_menu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.74s [INFO] running `"docker" "inspect" "c69147e8eb14913aaeeaaeb5561a94b8eb572299823963500a545e3351e40fc3"` [INFO] running `"docker" "rm" "-f" "c69147e8eb14913aaeeaaeb5561a94b8eb572299823963500a545e3351e40fc3"` [INFO] [stdout] c69147e8eb14913aaeeaaeb5561a94b8eb572299823963500a545e3351e40fc3