[INFO] updating cached repository c2hub/pebble-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/c2hub/pebble-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/c2hub/pebble-server" "work/ex/clippy-test-run/sources/stable/gh/c2hub/pebble-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/c2hub/pebble-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/c2hub/pebble-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c2hub/pebble-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c2hub/pebble-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f7c63698e9c109f68ccabae38c588aab4a0d584f [INFO] sha for GitHub repo c2hub/pebble-server: f7c63698e9c109f68ccabae38c588aab4a0d584f [INFO] validating manifest of c2hub/pebble-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of c2hub/pebble-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing c2hub/pebble-server [INFO] finished frobbing c2hub/pebble-server [INFO] frobbed toml for c2hub/pebble-server written to work/ex/clippy-test-run/sources/stable/gh/c2hub/pebble-server/Cargo.toml [INFO] started frobbing c2hub/pebble-server [INFO] finished frobbing c2hub/pebble-server [INFO] frobbed toml for c2hub/pebble-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c2hub/pebble-server/Cargo.toml [INFO] crate c2hub/pebble-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting c2hub/pebble-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/c2hub/pebble-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d71946edfd289f58c12064bfd027293d00f4cfd37c1d0df48c58b032e5de0e1 [INFO] running `"docker" "start" "-a" "0d71946edfd289f58c12064bfd027293d00f4cfd37c1d0df48c58b032e5de0e1"` [INFO] [stderr] Checking version-compare v0.0.4 [INFO] [stderr] Checking serde_bytes v0.10.0 [INFO] [stderr] Checking serde_cbor v0.6.0 [INFO] [stderr] Checking pebble-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:97:4 [INFO] [stderr] | [INFO] [stderr] 97 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | part: part, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/publish.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/register.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/upload.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:97:4 [INFO] [stderr] | [INFO] [stderr] 97 | parts: parts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:109:4 [INFO] [stderr] | [INFO] [stderr] 109 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:116:4 [INFO] [stderr] | [INFO] [stderr] 116 | part: part, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/publish.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/register.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/upload.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/data.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/register.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/register.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/data.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/data.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/register.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/register.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/data.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | let path = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/fehler.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(&(*addr).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(&A::clone(addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/find.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | && ent.versions [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | .iter() [INFO] [stderr] 39 | | .find(|ref ver| version == Version::from(ver).unwrap() || is_any) [INFO] [stderr] 40 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ref ver| version == Version::from(ver).unwrap() || is_any).is_some()` with `any(|ref ver| version == Version::from(ver).unwrap() || is_any)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/login.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | if user_db [INFO] [stderr] | ____________^ [INFO] [stderr] 19 | | .users [INFO] [stderr] 20 | | .unwrap() [INFO] [stderr] 21 | | .iter() [INFO] [stderr] 22 | | .find(|x| x.name == name && x.hash == hash) [INFO] [stderr] 23 | | .is_some() [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|x| x.name == name && x.hash == hash).is_some()` with `any(|x| x.name == name && x.hash == hash)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/fehler.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(&(*addr).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 33 | Packet::error(msg).send(&A::clone(addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/find.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | && ent.versions [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | .iter() [INFO] [stderr] 39 | | .find(|ref ver| version == Version::from(ver).unwrap() || is_any) [INFO] [stderr] 40 | | .is_some() [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ref ver| version == Version::from(ver).unwrap() || is_any).is_some()` with `any(|ref ver| version == Version::from(ver).unwrap() || is_any)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upload.rs:118:6 [INFO] [stderr] | [INFO] [stderr] 118 | socket.local_addr().unwrap().port() as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(socket.local_addr().unwrap().port())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] --> src/login.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | if user_db [INFO] [stderr] | ____________^ [INFO] [stderr] 19 | | .users [INFO] [stderr] 20 | | .unwrap() [INFO] [stderr] 21 | | .iter() [INFO] [stderr] 22 | | .find(|x| x.name == name && x.hash == hash) [INFO] [stderr] 23 | | .is_some() [INFO] [stderr] | |______________________^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|x| x.name == name && x.hash == hash).is_some()` with `any(|x| x.name == name && x.hash == hash)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/upload.rs:145:6 [INFO] [stderr] | [INFO] [stderr] 145 | match packet { [INFO] [stderr] | _____________________^ [INFO] [stderr] 146 | | Packet::Transfer { part, mut bytes } => { [INFO] [stderr] 147 | | if part != current_part { [INFO] [stderr] 148 | | Packet::error("file transfer failed, part lost").send(src); [INFO] [stderr] ... | [INFO] [stderr] 155 | | _ => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Packet::Transfer { part, mut bytes } = packet { [INFO] [stderr] 146 | if part != current_part { [INFO] [stderr] 147 | Packet::error("file transfer failed, part lost").send(src); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | current_part += 1; [INFO] [stderr] 150 | file.append(&mut bytes); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:58:10 [INFO] [stderr] | [INFO] [stderr] 58 | if let Err(_) = create_dir("data") { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 59 | | println!(" error: failed to create data folder"); [INFO] [stderr] 60 | | exit(-1); [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________- help: try this: `if create_dir("data").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pebble-server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/upload.rs:118:6 [INFO] [stderr] | [INFO] [stderr] 118 | socket.local_addr().unwrap().port() as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(socket.local_addr().unwrap().port())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/upload.rs:145:6 [INFO] [stderr] | [INFO] [stderr] 145 | match packet { [INFO] [stderr] | _____________________^ [INFO] [stderr] 146 | | Packet::Transfer { part, mut bytes } => { [INFO] [stderr] 147 | | if part != current_part { [INFO] [stderr] 148 | | Packet::error("file transfer failed, part lost").send(src); [INFO] [stderr] ... | [INFO] [stderr] 155 | | _ => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Packet::Transfer { part, mut bytes } = packet { [INFO] [stderr] 146 | if part != current_part { [INFO] [stderr] 147 | Packet::error("file transfer failed, part lost").send(src); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | current_part += 1; [INFO] [stderr] 150 | file.append(&mut bytes); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:58:10 [INFO] [stderr] | [INFO] [stderr] 58 | if let Err(_) = create_dir("data") { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 59 | | println!(" error: failed to create data folder"); [INFO] [stderr] 60 | | exit(-1); [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________- help: try this: `if create_dir("data").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pebble-server`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0d71946edfd289f58c12064bfd027293d00f4cfd37c1d0df48c58b032e5de0e1"` [INFO] running `"docker" "rm" "-f" "0d71946edfd289f58c12064bfd027293d00f4cfd37c1d0df48c58b032e5de0e1"` [INFO] [stdout] 0d71946edfd289f58c12064bfd027293d00f4cfd37c1d0df48c58b032e5de0e1