[INFO] updating cached repository c0va23/highloadcup_round_1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/c0va23/highloadcup_round_1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/c0va23/highloadcup_round_1" "work/ex/clippy-test-run/sources/stable/gh/c0va23/highloadcup_round_1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/c0va23/highloadcup_round_1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/c0va23/highloadcup_round_1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c0va23/highloadcup_round_1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c0va23/highloadcup_round_1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a3142df17a4e452edfdba445cd6669976fe94d9a [INFO] sha for GitHub repo c0va23/highloadcup_round_1: a3142df17a4e452edfdba445cd6669976fe94d9a [INFO] validating manifest of c0va23/highloadcup_round_1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of c0va23/highloadcup_round_1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing c0va23/highloadcup_round_1 [INFO] finished frobbing c0va23/highloadcup_round_1 [INFO] frobbed toml for c0va23/highloadcup_round_1 written to work/ex/clippy-test-run/sources/stable/gh/c0va23/highloadcup_round_1/Cargo.toml [INFO] started frobbing c0va23/highloadcup_round_1 [INFO] finished frobbing c0va23/highloadcup_round_1 [INFO] frobbed toml for c0va23/highloadcup_round_1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/c0va23/highloadcup_round_1/Cargo.toml [INFO] crate c0va23/highloadcup_round_1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting c0va23/highloadcup_round_1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/c0va23/highloadcup_round_1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb9a219dc2246ec83e7ec52623a0ba604bf7f4a6c6a9b515459a56623d3b56d2 [INFO] running `"docker" "start" "-a" "fb9a219dc2246ec83e7ec52623a0ba604bf7f4a6c6a9b515459a56623d3b56d2"` [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking zip v0.2.6 [INFO] [stderr] Checking hlcup1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | now: now, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | now: now, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/loader.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | const JSON_SUFIX: &'static str = ".json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:364:24 [INFO] [stderr] | [INFO] [stderr] 364 | const DEFAULT_LISTEN: &'static str = "127.0.0.1:9999"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:365:25 [INFO] [stderr] | [INFO] [stderr] 365 | const DEFAULT_BACKLOG: &'static str = "1024"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:366:27 [INFO] [stderr] | [INFO] [stderr] 366 | const DEFAULT_DATA_PATH: &'static str = "data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:367:25 [INFO] [stderr] | [INFO] [stderr] 367 | const DEFAULT_THREADS: &'static str = "4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/loader.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | const JSON_SUFIX: &'static str = ".json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:364:24 [INFO] [stderr] | [INFO] [stderr] 364 | const DEFAULT_LISTEN: &'static str = "127.0.0.1:9999"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:365:25 [INFO] [stderr] | [INFO] [stderr] 365 | const DEFAULT_BACKLOG: &'static str = "1024"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:366:27 [INFO] [stderr] | [INFO] [stderr] 366 | const DEFAULT_DATA_PATH: &'static str = "data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:367:25 [INFO] [stderr] | [INFO] [stderr] 367 | const DEFAULT_THREADS: &'static str = "4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/store.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / self.visits.get(&visit_id) [INFO] [stderr] 153 | | .map(|v| v.clone()) [INFO] [stderr] | |_______________________________^ help: Consider calling the dedicated `cloned` method: `self.visits.get(&visit_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:417:73 [INFO] [stderr] | [INFO] [stderr] 417 | .fold((0u64, 0u64), |(sum, count), &(ref v, ref _v)| (sum + v.mark as u64, count + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.mark)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:154:12 [INFO] [stderr] | [INFO] [stderr] 154 | if map.values().find(|v| **v == serde_json::value::Value::Null).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|v| **v == serde_json::value::Value::Null).is_some()` with `any(|v| **v == serde_json::value::Value::Null)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:422:37 [INFO] [stderr] | [INFO] [stderr] 422 | address: env::var("LISTEN").unwrap_or(DEFAULT_LISTEN.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_LISTEN.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:424:38 [INFO] [stderr] | [INFO] [stderr] 424 | backlog: env::var("BACKLOG").unwrap_or(DEFAULT_BACKLOG.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_BACKLOG.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:426:42 [INFO] [stderr] | [INFO] [stderr] 426 | data_path: env::var("DATA_PATH").unwrap_or(DEFAULT_DATA_PATH.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_DATA_PATH.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:427:38 [INFO] [stderr] | [INFO] [stderr] 427 | threads: env::var("THREADS").unwrap_or(DEFAULT_THREADS.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_THREADS.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/store.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / self.visits.get(&visit_id) [INFO] [stderr] 153 | | .map(|v| v.clone()) [INFO] [stderr] | |_______________________________^ help: Consider calling the dedicated `cloned` method: `self.visits.get(&visit_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:417:73 [INFO] [stderr] | [INFO] [stderr] 417 | .fold((0u64, 0u64), |(sum, count), &(ref v, ref _v)| (sum + v.mark as u64, count + 1)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.mark)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:630:36 [INFO] [stderr] | [INFO] [stderr] 630 | Ok(LocationRate { avg: visit_data.mark.unwrap() as f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(visit_data.mark.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:687:36 [INFO] [stderr] | [INFO] [stderr] 687 | Ok(LocationRate { avg: visit_data.mark.unwrap() as f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(visit_data.mark.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:749:36 [INFO] [stderr] | [INFO] [stderr] 749 | Ok(LocationRate { avg: visit.mark as f64 }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(visit.mark)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/store.rs:964:22 [INFO] [stderr] | [INFO] [stderr] 964 | avg: visit_data.mark.unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(visit_data.mark.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:154:12 [INFO] [stderr] | [INFO] [stderr] 154 | if map.values().find(|v| **v == serde_json::value::Value::Null).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|v| **v == serde_json::value::Value::Null).is_some()` with `any(|v| **v == serde_json::value::Value::Null)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:422:37 [INFO] [stderr] | [INFO] [stderr] 422 | address: env::var("LISTEN").unwrap_or(DEFAULT_LISTEN.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_LISTEN.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:424:38 [INFO] [stderr] | [INFO] [stderr] 424 | backlog: env::var("BACKLOG").unwrap_or(DEFAULT_BACKLOG.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_BACKLOG.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:426:42 [INFO] [stderr] | [INFO] [stderr] 426 | data_path: env::var("DATA_PATH").unwrap_or(DEFAULT_DATA_PATH.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_DATA_PATH.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:427:38 [INFO] [stderr] | [INFO] [stderr] 427 | threads: env::var("THREADS").unwrap_or(DEFAULT_THREADS.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_THREADS.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.02s [INFO] running `"docker" "inspect" "fb9a219dc2246ec83e7ec52623a0ba604bf7f4a6c6a9b515459a56623d3b56d2"` [INFO] running `"docker" "rm" "-f" "fb9a219dc2246ec83e7ec52623a0ba604bf7f4a6c6a9b515459a56623d3b56d2"` [INFO] [stdout] fb9a219dc2246ec83e7ec52623a0ba604bf7f4a6c6a9b515459a56623d3b56d2