[INFO] updating cached repository bytebuddha/Columbus [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bytebuddha/Columbus [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bytebuddha/Columbus" "work/ex/clippy-test-run/sources/stable/gh/bytebuddha/Columbus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bytebuddha/Columbus'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bytebuddha/Columbus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bytebuddha/Columbus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bytebuddha/Columbus'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cfb170328f4a05fbb026c5ab5c531f959a2396d1 [INFO] sha for GitHub repo bytebuddha/Columbus: cfb170328f4a05fbb026c5ab5c531f959a2396d1 [INFO] validating manifest of bytebuddha/Columbus on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bytebuddha/Columbus on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bytebuddha/Columbus [INFO] finished frobbing bytebuddha/Columbus [INFO] frobbed toml for bytebuddha/Columbus written to work/ex/clippy-test-run/sources/stable/gh/bytebuddha/Columbus/Cargo.toml [INFO] started frobbing bytebuddha/Columbus [INFO] finished frobbing bytebuddha/Columbus [INFO] frobbed toml for bytebuddha/Columbus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bytebuddha/Columbus/Cargo.toml [INFO] crate bytebuddha/Columbus has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bytebuddha/Columbus against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bytebuddha/Columbus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b72d67cbe1b4364093bae48c42b40d7387516d2a342602684efc300f6159304b [INFO] running `"docker" "start" "-a" "b72d67cbe1b4364093bae48c42b40d7387516d2a342602684efc300f6159304b"` [INFO] [stderr] Compiling plist v0.2.2 [INFO] [stderr] Checking serde v1.0.10 [INFO] [stderr] Checking cassowary v0.2.1 [INFO] [stderr] Compiling cmake v0.1.24 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking termion v1.4.0 [INFO] [stderr] Checking xml-rs v0.4.1 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Compiling onig_sys v64.0.1 [INFO] [stderr] Checking tui v0.1.3 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking onig v1.4.1 [INFO] [stderr] Checking syntect v1.7.1 [INFO] [stderr] Checking columbus v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui/source.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui/source.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | gutter_color: gutter_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gutter_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui/source.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui/source.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | gutter_color: gutter_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gutter_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/ui/source.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if y >= height+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 88 | if y > height { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/ui/source.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if y >= height+1 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 88 | if y > height { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.57s [INFO] running `"docker" "inspect" "b72d67cbe1b4364093bae48c42b40d7387516d2a342602684efc300f6159304b"` [INFO] running `"docker" "rm" "-f" "b72d67cbe1b4364093bae48c42b40d7387516d2a342602684efc300f6159304b"` [INFO] [stdout] b72d67cbe1b4364093bae48c42b40d7387516d2a342602684efc300f6159304b