[INFO] updating cached repository bwhetherington/rust-2048 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bwhetherington/rust-2048 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bwhetherington/rust-2048" "work/ex/clippy-test-run/sources/stable/gh/bwhetherington/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bwhetherington/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bwhetherington/rust-2048" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwhetherington/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwhetherington/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c80aad95941ca1f8797613d73ab44044c3178f40 [INFO] sha for GitHub repo bwhetherington/rust-2048: c80aad95941ca1f8797613d73ab44044c3178f40 [INFO] validating manifest of bwhetherington/rust-2048 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bwhetherington/rust-2048 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bwhetherington/rust-2048 [INFO] finished frobbing bwhetherington/rust-2048 [INFO] frobbed toml for bwhetherington/rust-2048 written to work/ex/clippy-test-run/sources/stable/gh/bwhetherington/rust-2048/Cargo.toml [INFO] started frobbing bwhetherington/rust-2048 [INFO] finished frobbing bwhetherington/rust-2048 [INFO] frobbed toml for bwhetherington/rust-2048 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwhetherington/rust-2048/Cargo.toml [INFO] crate bwhetherington/rust-2048 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bwhetherington/rust-2048 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bwhetherington/rust-2048:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a624113b2d46c81de1027b047f11c2d51b1e5695e787565476b3eec34586b63 [INFO] running `"docker" "start" "-a" "9a624113b2d46c81de1027b047f11c2d51b1e5695e787565476b3eec34586b63"` [INFO] [stderr] Checking rust-2048-2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/matrix/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | write!(f, "|\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/matrix/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | write!(f, "|\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `game::*` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use game::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/game/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 0..source.cols() { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | fn slide_left(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | fn slide_right(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | fn slide_right(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | fn slide_up(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | fn slide_up(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | fn slide_down(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | fn slide_down(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let d: Matrix<_> = m.diag().into(); [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `col_widths` [INFO] [stderr] --> src/matrix/mod.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | for j in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 171 | for (j, ) in col_widths.iter().enumerate().take(cols) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vec`. [INFO] [stderr] --> src/matrix/mod.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..rows { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in vec.iter().take(rows) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/game/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | row[1]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused import: `game::*` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use game::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/game/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | for j in 0..source.cols() { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:70:37 [INFO] [stderr] | [INFO] [stderr] 70 | fn slide_left(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | fn slide_right(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | fn slide_right(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | fn slide_up(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | fn slide_up(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/game/mod.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | fn slide_down(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dest` [INFO] [stderr] --> src/game/mod.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | fn slide_down(source: &Matrix, dest: &mut Matrix) { [INFO] [stderr] | ^^^^ help: consider using `_dest` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let d: Matrix<_> = m.diag().into(); [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `col_widths` [INFO] [stderr] --> src/matrix/mod.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | for j in 0..cols { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 171 | for (j, ) in col_widths.iter().enumerate().take(cols) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vec`. [INFO] [stderr] --> src/matrix/mod.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..rows { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in vec.iter().take(rows) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/game/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | row[1]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "9a624113b2d46c81de1027b047f11c2d51b1e5695e787565476b3eec34586b63"` [INFO] running `"docker" "rm" "-f" "9a624113b2d46c81de1027b047f11c2d51b1e5695e787565476b3eec34586b63"` [INFO] [stdout] 9a624113b2d46c81de1027b047f11c2d51b1e5695e787565476b3eec34586b63