[INFO] updating cached repository bwasty/learn-opengl-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bwasty/learn-opengl-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bwasty/learn-opengl-rs" "work/ex/clippy-test-run/sources/stable/gh/bwasty/learn-opengl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bwasty/learn-opengl-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bwasty/learn-opengl-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwasty/learn-opengl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwasty/learn-opengl-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5618d130c173cbbaac7e29f504427dc4edc07000 [INFO] sha for GitHub repo bwasty/learn-opengl-rs: 5618d130c173cbbaac7e29f504427dc4edc07000 [INFO] validating manifest of bwasty/learn-opengl-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bwasty/learn-opengl-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bwasty/learn-opengl-rs [INFO] finished frobbing bwasty/learn-opengl-rs [INFO] frobbed toml for bwasty/learn-opengl-rs written to work/ex/clippy-test-run/sources/stable/gh/bwasty/learn-opengl-rs/Cargo.toml [INFO] started frobbing bwasty/learn-opengl-rs [INFO] finished frobbing bwasty/learn-opengl-rs [INFO] frobbed toml for bwasty/learn-opengl-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bwasty/learn-opengl-rs/Cargo.toml [INFO] crate bwasty/learn-opengl-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bwasty/learn-opengl-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bwasty/learn-opengl-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e4a3302c2ab6665181d2fb3347fce5f52238bc27e92828a87c6f1e43ef243a6 [INFO] running `"docker" "start" "-a" "0e4a3302c2ab6665181d2fb3347fce5f52238bc27e92828a87c6f1e43ef243a6"` [INFO] [stderr] Compiling cmake v0.1.33 [INFO] [stderr] Compiling log v0.4.4 [INFO] [stderr] Checking num-bigint v0.2.0 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking glfw v0.23.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking learn-opengl-rs v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/_1_getting_started/_7_2_camera_keyboard_dt.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | #[allow(single_match)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/_1_getting_started/_7_3_camera_mouse_zoom.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/_1_getting_started/_7_2_camera_keyboard_dt.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | #[allow(single_match)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/_1_getting_started/_7_3_camera_mouse_zoom.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | for y in 0..Y_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=Y_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:225:26 [INFO] [stderr] | [INFO] [stderr] 225 | for x in (0..X_SEGMENTS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=X_SEGMENTS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:220:18 [INFO] [stderr] | [INFO] [stderr] 220 | for y in 0..Y_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=Y_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:221:22 [INFO] [stderr] | [INFO] [stderr] 221 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | for x in (0..X_SEGMENTS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=X_SEGMENTS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | for y in 0..Y_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=Y_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_1_lighting.rs:225:26 [INFO] [stderr] | [INFO] [stderr] 225 | for x in (0..X_SEGMENTS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=X_SEGMENTS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:220:18 [INFO] [stderr] | [INFO] [stderr] 220 | for y in 0..Y_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=Y_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:221:22 [INFO] [stderr] | [INFO] [stderr] 221 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | for x in 0..X_SEGMENTS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=X_SEGMENTS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/_6_pbr/_1_2_lighting_textured.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | for x in (0..X_SEGMENTS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=X_SEGMENTS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.01s [INFO] running `"docker" "inspect" "0e4a3302c2ab6665181d2fb3347fce5f52238bc27e92828a87c6f1e43ef243a6"` [INFO] running `"docker" "rm" "-f" "0e4a3302c2ab6665181d2fb3347fce5f52238bc27e92828a87c6f1e43ef243a6"` [INFO] [stdout] 0e4a3302c2ab6665181d2fb3347fce5f52238bc27e92828a87c6f1e43ef243a6