[INFO] updating cached repository bvtsang/kosuzu.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bvtsang/kosuzu.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bvtsang/kosuzu.rs" "work/ex/clippy-test-run/sources/stable/gh/bvtsang/kosuzu.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bvtsang/kosuzu.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bvtsang/kosuzu.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvtsang/kosuzu.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvtsang/kosuzu.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c02790a589a122ca351f9444542340a2d6de01d0 [INFO] sha for GitHub repo bvtsang/kosuzu.rs: c02790a589a122ca351f9444542340a2d6de01d0 [INFO] validating manifest of bvtsang/kosuzu.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bvtsang/kosuzu.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bvtsang/kosuzu.rs [INFO] finished frobbing bvtsang/kosuzu.rs [INFO] frobbed toml for bvtsang/kosuzu.rs written to work/ex/clippy-test-run/sources/stable/gh/bvtsang/kosuzu.rs/Cargo.toml [INFO] started frobbing bvtsang/kosuzu.rs [INFO] finished frobbing bvtsang/kosuzu.rs [INFO] frobbed toml for bvtsang/kosuzu.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvtsang/kosuzu.rs/Cargo.toml [INFO] crate bvtsang/kosuzu.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bvtsang/kosuzu.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bvtsang/kosuzu.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aaea1430080a46f1b808910b7f7d4867a6d163490f1552287d00fbec50e357c6 [INFO] running `"docker" "start" "-a" "aaea1430080a46f1b808910b7f7d4867a6d163490f1552287d00fbec50e357c6"` [INFO] [stderr] Checking kosuzu-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/formatter.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/formatter.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/parser.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return String::from("Comiket ") + num_split.last().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Comiket ") + num_split.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return String::from("Autumn Reitaisai") + &returned_num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Autumn Reitaisai") + &returned_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return String::from("Comiket ") + num_split.last().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Comiket ") + num_split.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return String::from("Autumn Reitaisai") + &returned_num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Autumn Reitaisai") + &returned_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | fn format_to_group(orgs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Organization]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let ref ja_name = org.names.ja; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let ja_name = &org.names.ja;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | fn format_to_group_cat(orgs: &Vec, n: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Organization]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | fn format_to_convention(events: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let ref name = events[0].name; [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let name = &events[0].name;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | let num_split: Vec<&str> = name.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | let num_split: Vec<&str> = name.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | let returned_num = match num { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 72 | | &"1" => String::new(), [INFO] [stderr] 73 | | _ => String::from(" ") + num, [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | let returned_num = match *num { [INFO] [stderr] 72 | "1" => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | fn format_to_tracks(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | fn format_to_length(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | if discs[0].disc_length.find(":").is_none() { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/formatter.rs:102:11 [INFO] [stderr] | [INFO] [stderr] 102 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 103 | | .fold(0, |a, b| a + b); [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:98:61 [INFO] [stderr] | [INFO] [stderr] 98 | let m_and_s: Vec<&str> = disc.disc_length.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | fn format_to_list_of_people(people: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Person]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if length.find(":").is_none() { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:142:43 [INFO] [stderr] | [INFO] [stderr] 142 | let m_and_s: Vec<&str> = length.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | fn format_to_tracklist(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let title = match track.names.japanese.is_empty() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 160 | | true => { [INFO] [stderr] 161 | | if track.names.english.is_empty() && !track.names.romaji.is_empty() { [INFO] [stderr] 162 | | track.names.romaji.clone() [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 159 | let title = if track.names.japanese.is_empty() { [INFO] [stderr] 160 | if track.names.english.is_empty() && !track.names.romaji.is_empty() { [INFO] [stderr] 161 | track.names.romaji.clone() [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | track.names.english.clone() [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:176:35 [INFO] [stderr] | [INFO] [stderr] 176 | let translation = match !track.names.japanese.is_empty() && [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 177 | | !track.names.english.is_empty() && [INFO] [stderr] 178 | | track.names.japanese != track.names.english { [INFO] [stderr] 179 | | true => format!("\n** ''{}''", track.names.english), [INFO] [stderr] 180 | | false => String::new(), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 176 | let translation = if !track.names.japanese.is_empty() && [INFO] [stderr] 177 | !track.names.english.is_empty() && [INFO] [stderr] 178 | track.names.japanese != track.names.english { format!("\n** ''{}''", track.names.english) } else { String::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | let ref title_ja = album.names.ja; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let title_ja = &album.names.ja;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | let ref title_jprom = album.names.ja_latn; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------- help: try: `let title_jprom = &album.names.ja_latn;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let ref title_en = album.names.en; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let title_en = &album.names.en;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | let ref orgs = album.organizations; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let orgs = &album.organizations;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let ref release_date = album.release_date; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------------------- help: try: `let release_date = &album.release_date;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | let ref release_events = album.release_events; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^------------------------ help: try: `let release_events = &album.release_events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | let ref discs = album.discs; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let discs = &album.discs;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | let ref catalog = album.catalog; [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let catalog = &album.catalog;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | let ref websites = album.websites; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let websites = &album.websites;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | let ref arrangers = album.arrangers; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------- help: try: `let arrangers = &album.arrangers;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | let ref lyricists = album.lyricists; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------- help: try: `let lyricists = &album.lyricists;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | let ref performers = album.performers; [INFO] [stderr] | ----^^^^^^^^^^^^^^-------------------- help: try: `let performers = &album.performers;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | let ref notes = album.notes; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let notes = &album.notes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | fn format_to_group(orgs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Organization]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let ref ja_name = org.names.ja; [INFO] [stderr] | ----^^^^^^^^^^^---------------- help: try: `let ja_name = &org.names.ja;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | fn format_to_group_cat(orgs: &Vec, n: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Organization]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | fn format_to_convention(events: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Event]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | let ref name = events[0].name; [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let name = &events[0].name;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | let num_split: Vec<&str> = name.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | let num_split: Vec<&str> = name.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | let returned_num = match num { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 72 | | &"1" => String::new(), [INFO] [stderr] 73 | | _ => String::from(" ") + num, [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | let returned_num = match *num { [INFO] [stderr] 72 | "1" => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | fn format_to_tracks(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | fn format_to_length(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | if discs[0].disc_length.find(":").is_none() { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/formatter.rs:102:11 [INFO] [stderr] | [INFO] [stderr] 102 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 103 | | .fold(0, |a, b| a + b); [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:98:61 [INFO] [stderr] | [INFO] [stderr] 98 | let m_and_s: Vec<&str> = disc.disc_length.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | fn format_to_list_of_people(people: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Person]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if length.find(":").is_none() { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/formatter.rs:142:43 [INFO] [stderr] | [INFO] [stderr] 142 | let m_and_s: Vec<&str> = length.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/formatter.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | fn format_to_tracklist(discs: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Disc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let title = match track.names.japanese.is_empty() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 160 | | true => { [INFO] [stderr] 161 | | if track.names.english.is_empty() && !track.names.romaji.is_empty() { [INFO] [stderr] 162 | | track.names.romaji.clone() [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 159 | let title = if track.names.japanese.is_empty() { [INFO] [stderr] 160 | if track.names.english.is_empty() && !track.names.romaji.is_empty() { [INFO] [stderr] 161 | track.names.romaji.clone() [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | track.names.english.clone() [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/formatter.rs:176:35 [INFO] [stderr] | [INFO] [stderr] 176 | let translation = match !track.names.japanese.is_empty() && [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 177 | | !track.names.english.is_empty() && [INFO] [stderr] 178 | | track.names.japanese != track.names.english { [INFO] [stderr] 179 | | true => format!("\n** ''{}''", track.names.english), [INFO] [stderr] 180 | | false => String::new(), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 176 | let translation = if !track.names.japanese.is_empty() && [INFO] [stderr] 177 | !track.names.english.is_empty() && [INFO] [stderr] 178 | track.names.japanese != track.names.english { format!("\n** ''{}''", track.names.english) } else { String::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | let ref title_ja = album.names.ja; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let title_ja = &album.names.ja;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | let ref title_jprom = album.names.ja_latn; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------------- help: try: `let title_jprom = &album.names.ja_latn;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let ref title_en = album.names.en; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let title_en = &album.names.en;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | let ref orgs = album.organizations; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let orgs = &album.organizations;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let ref release_date = album.release_date; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------------------- help: try: `let release_date = &album.release_date;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | let ref release_events = album.release_events; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^------------------------ help: try: `let release_events = &album.release_events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | let ref discs = album.discs; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let discs = &album.discs;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | let ref catalog = album.catalog; [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let catalog = &album.catalog;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | let ref websites = album.websites; [INFO] [stderr] | ----^^^^^^^^^^^^------------------ help: try: `let websites = &album.websites;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | let ref arrangers = album.arrangers; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------- help: try: `let arrangers = &album.arrangers;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | let ref lyricists = album.lyricists; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------- help: try: `let lyricists = &album.lyricists;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | let ref performers = album.performers; [INFO] [stderr] | ----^^^^^^^^^^^^^^-------------------- help: try: `let performers = &album.performers;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/formatter.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | let ref notes = album.notes; [INFO] [stderr] | ----^^^^^^^^^--------------- help: try: `let notes = &album.notes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.63s [INFO] running `"docker" "inspect" "aaea1430080a46f1b808910b7f7d4867a6d163490f1552287d00fbec50e357c6"` [INFO] running `"docker" "rm" "-f" "aaea1430080a46f1b808910b7f7d4867a6d163490f1552287d00fbec50e357c6"` [INFO] [stdout] aaea1430080a46f1b808910b7f7d4867a6d163490f1552287d00fbec50e357c6