[INFO] updating cached repository bvanrijn/freitag [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bvanrijn/freitag [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bvanrijn/freitag" "work/ex/clippy-test-run/sources/stable/gh/bvanrijn/freitag"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bvanrijn/freitag'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bvanrijn/freitag" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvanrijn/freitag"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvanrijn/freitag'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7af1dd7ab486d27d34d77f367b503370539e36a0 [INFO] sha for GitHub repo bvanrijn/freitag: 7af1dd7ab486d27d34d77f367b503370539e36a0 [INFO] validating manifest of bvanrijn/freitag on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bvanrijn/freitag on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bvanrijn/freitag [INFO] finished frobbing bvanrijn/freitag [INFO] frobbed toml for bvanrijn/freitag written to work/ex/clippy-test-run/sources/stable/gh/bvanrijn/freitag/Cargo.toml [INFO] started frobbing bvanrijn/freitag [INFO] finished frobbing bvanrijn/freitag [INFO] frobbed toml for bvanrijn/freitag written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bvanrijn/freitag/Cargo.toml [INFO] crate bvanrijn/freitag has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bvanrijn/freitag against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bvanrijn/freitag:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9006422dd0722ccf710c45ae971553f10f8859705bd7e64a127ab8fd11137fe4 [INFO] running `"docker" "start" "-a" "9006422dd0722ccf710c45ae971553f10f8859705bd7e64a127ab8fd11137fe4"` [INFO] [stderr] Checking encode_unicode v0.3.5 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking toml v0.4.9 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking freitag v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(cd); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(cd)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return details; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `details` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(cd); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(cd)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return details; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `details` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotFound` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | NotFound, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ParseError` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ParseError, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotFound` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | NotFound, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ParseError` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ParseError, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.21s [INFO] running `"docker" "inspect" "9006422dd0722ccf710c45ae971553f10f8859705bd7e64a127ab8fd11137fe4"` [INFO] running `"docker" "rm" "-f" "9006422dd0722ccf710c45ae971553f10f8859705bd7e64a127ab8fd11137fe4"` [INFO] [stdout] 9006422dd0722ccf710c45ae971553f10f8859705bd7e64a127ab8fd11137fe4