[INFO] updating cached repository buttercup/crypto
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/buttercup/crypto
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/buttercup/crypto" "work/ex/clippy-test-run/sources/stable/gh/buttercup/crypto"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/buttercup/crypto'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/buttercup/crypto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buttercup/crypto"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buttercup/crypto'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 58f4e97841148a4a373372e2db060acc83c1c28f
[INFO] sha for GitHub repo buttercup/crypto: 58f4e97841148a4a373372e2db060acc83c1c28f
[INFO] validating manifest of buttercup/crypto on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of buttercup/crypto on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing buttercup/crypto
[INFO] finished frobbing buttercup/crypto
[INFO] frobbed toml for buttercup/crypto written to work/ex/clippy-test-run/sources/stable/gh/buttercup/crypto/Cargo.toml
[INFO] started frobbing buttercup/crypto
[INFO] finished frobbing buttercup/crypto
[INFO] frobbed toml for buttercup/crypto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/buttercup/crypto/Cargo.toml
[INFO] crate buttercup/crypto has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting buttercup/crypto against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/buttercup/crypto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7049de6780cdb69cc43c404ee46d87ccbadfb1766052e7a84cf00c71c2b465b0
[INFO] running `"docker" "start" "-a" "7049de6780cdb69cc43c404ee46d87ccbadfb1766052e7a84cf00c71c2b465b0"`
[INFO] [stderr]     Checking block-padding v0.1.0
[INFO] [stderr]     Checking crypto-mac v0.6.0
[INFO] [stderr]     Checking block-cipher-trait v0.5.0
[INFO] [stderr]     Checking hmac v0.6.2
[INFO] [stderr]     Checking pbkdf2 v0.2.0
[INFO] [stderr]     Checking block-modes v0.1.0
[INFO] [stderr]     Checking aes-soft v0.1.0
[INFO] [stderr]     Checking buttercup-crypto v0.4.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/encryption/cbc.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     return Ok((
[INFO] [stderr] 53 | |         base64_result,
[INFO] [stderr] 54 | |         hmac_code.to_vec(),
[INFO] [stderr] 55 | |         iv.to_vec(),
[INFO] [stderr] 56 | |         salt.to_vec(),
[INFO] [stderr] 57 | |     ));
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |     Ok((
[INFO] [stderr] 53 |         base64_result,
[INFO] [stderr] 54 |         hmac_code.to_vec(),
[INFO] [stderr] 55 |         iv.to_vec(),
[INFO] [stderr] 56 |         salt.to_vec(),
[INFO] [stderr] 57 |     ))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/encryption/cbc.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     return Ok((
[INFO] [stderr] 53 | |         base64_result,
[INFO] [stderr] 54 | |         hmac_code.to_vec(),
[INFO] [stderr] 55 | |         iv.to_vec(),
[INFO] [stderr] 56 | |         salt.to_vec(),
[INFO] [stderr] 57 | |     ));
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |     Ok((
[INFO] [stderr] 53 |         base64_result,
[INFO] [stderr] 54 |         hmac_code.to_vec(),
[INFO] [stderr] 55 |         iv.to_vec(),
[INFO] [stderr] 56 |         salt.to_vec(),
[INFO] [stderr] 57 |     ))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/encryption/cbc.rs:127:21
[INFO] [stderr]     |
[INFO] [stderr] 127 |       let decrypted = decrypt(
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 128 | |         encrypted,
[INFO] [stderr] 129 | |         key,
[INFO] [stderr] 130 | |         iv.as_slice(),
[INFO] [stderr] ...   |
[INFO] [stderr] 133 | |         hmac.as_slice(),
[INFO] [stderr] 134 | |     ).unwrap_or(Vec::new());
[INFO] [stderr]     | |___________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 127 |     let decrypted = decrypt(
[INFO] [stderr] 128 |         encrypted,
[INFO] [stderr] 129 |         key,
[INFO] [stderr] 130 |         iv.as_slice(),
[INFO] [stderr] 131 |         salt,
[INFO] [stderr] 132 |         hmac_key,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.32s
[INFO] running `"docker" "inspect" "7049de6780cdb69cc43c404ee46d87ccbadfb1766052e7a84cf00c71c2b465b0"`
[INFO] running `"docker" "rm" "-f" "7049de6780cdb69cc43c404ee46d87ccbadfb1766052e7a84cf00c71c2b465b0"`
[INFO] [stdout] 7049de6780cdb69cc43c404ee46d87ccbadfb1766052e7a84cf00c71c2b465b0