[INFO] updating cached repository burtonageo/gfx_tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/burtonageo/gfx_tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/burtonageo/gfx_tutorial" "work/ex/clippy-test-run/sources/stable/gh/burtonageo/gfx_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/burtonageo/gfx_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/burtonageo/gfx_tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtonageo/gfx_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtonageo/gfx_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 507c123fd48ecd3c08bbbadaa49a2d659bdb8059 [INFO] sha for GitHub repo burtonageo/gfx_tutorial: 507c123fd48ecd3c08bbbadaa49a2d659bdb8059 [INFO] validating manifest of burtonageo/gfx_tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of burtonageo/gfx_tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing burtonageo/gfx_tutorial [INFO] finished frobbing burtonageo/gfx_tutorial [INFO] frobbed toml for burtonageo/gfx_tutorial written to work/ex/clippy-test-run/sources/stable/gh/burtonageo/gfx_tutorial/Cargo.toml [INFO] started frobbing burtonageo/gfx_tutorial [INFO] finished frobbing burtonageo/gfx_tutorial [INFO] frobbed toml for burtonageo/gfx_tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burtonageo/gfx_tutorial/Cargo.toml [INFO] crate burtonageo/gfx_tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting burtonageo/gfx_tutorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/burtonageo/gfx_tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ff28531cd305f3aa433f84363a8f90bd4c7e86cd12e17a5c8570687548383c8 [INFO] running `"docker" "start" "-a" "2ff28531cd305f3aa433f84363a8f90bd4c7e86cd12e17a5c8570687548383c8"` [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Checking lazy_static v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking token_store v0.1.2 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling pkg-config v0.3.12 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling rayon v1.0.2 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking xi-unicode v0.1.0 [INFO] [stderr] Checking wavefront_obj v5.1.0 [INFO] [stderr] Checking apply v0.2.2 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling x11-dl v2.18.1 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking twox-hash v1.1.1 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking ang v0.2.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.13.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.11.3 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx_window_glutin v0.21.0 [INFO] [stderr] Checking gfx_glyph v0.9.1 [INFO] [stderr] Checking gfx_tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `lazy_load::Asset` [INFO] [stderr] --> src/graphics/model.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use lazy_load::Asset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | const GLSL_VERT_SRC: &'static [u8] = include_bytes!("../data/shader/glsl/standard.vs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | const GLSL_FRAG_SRC: &'static [u8] = include_bytes!("../data/shader/glsl/standard.fs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | const MSL_VERT_SRC: &'static [u8] = include_bytes!("../data/shader/msl/standard.vs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | const MSL_FRAG_SRC: &'static [u8] = include_bytes!("../data/shader/msl/standard.fs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `lazy_load::Asset` [INFO] [stderr] --> src/graphics/model.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use lazy_load::Asset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | const GLSL_VERT_SRC: &'static [u8] = include_bytes!("../data/shader/glsl/standard.vs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | const GLSL_FRAG_SRC: &'static [u8] = include_bytes!("../data/shader/glsl/standard.fs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | const MSL_VERT_SRC: &'static [u8] = include_bytes!("../data/shader/msl/standard.vs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | const MSL_FRAG_SRC: &'static [u8] = include_bytes!("../data/shader/msl/standard.fs"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/model.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | backend: &Backend, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Backend` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/graphics/platform/gl.rs:44:6 [INFO] [stderr] | [INFO] [stderr] 44 | ) -> Result< [INFO] [stderr] | ______^ [INFO] [stderr] 45 | | (Backend, [INFO] [stderr] 46 | | GlWindow, [INFO] [stderr] 47 | | Device, [INFO] [stderr] ... | [INFO] [stderr] 51 | | Void, [INFO] [stderr] 52 | | > [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/graphics/platform/mod.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | ..self [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn is_gl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn is_metal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn is_d3d11(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | .unwrap_or(Duration::zero()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Duration::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | / match event { [INFO] [stderr] 369 | | Event::WindowEvent { event, .. } => { [INFO] [stderr] 370 | | match event { [INFO] [stderr] 371 | | WindowEvent::Closed | [INFO] [stderr] ... | [INFO] [stderr] 420 | | _ => (), [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 368 | if let Event::WindowEvent { event, .. } = event { [INFO] [stderr] 369 | match event { [INFO] [stderr] 370 | WindowEvent::Closed | [INFO] [stderr] 371 | WindowEvent::KeyboardInput { [INFO] [stderr] 372 | input: KeyboardInput { [INFO] [stderr] 373 | virtual_keycode: Some(VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | / match input { [INFO] [stderr] 394 | | KeyboardInput { [INFO] [stderr] 395 | | state, [INFO] [stderr] 396 | | virtual_keycode: Some(vk_code), [INFO] [stderr] ... | [INFO] [stderr] 411 | | _ => {} [INFO] [stderr] 412 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 393 | if let KeyboardInput { [INFO] [stderr] 394 | state, [INFO] [stderr] 395 | virtual_keycode: Some(vk_code), [INFO] [stderr] 396 | .. [INFO] [stderr] 397 | } = input { [INFO] [stderr] 398 | let is_pressed = state == ElementState::Pressed; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:494:25 [INFO] [stderr] | [INFO] [stderr] 494 | cast(x).unwrap_or(Zero::zero()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:495:25 [INFO] [stderr] | [INFO] [stderr] 495 | cast(y).unwrap_or(Zero::zero()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | / self.get_inner_size().map(cast_pair).unwrap_or( [INFO] [stderr] 500 | | Default::default(), [INFO] [stderr] 501 | | ) [INFO] [stderr] | |_________^ help: try this: `self.get_inner_size().map(cast_pair).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/model.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | backend: &Backend, [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Backend` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/graphics/platform/gl.rs:44:6 [INFO] [stderr] | [INFO] [stderr] 44 | ) -> Result< [INFO] [stderr] | ______^ [INFO] [stderr] 45 | | (Backend, [INFO] [stderr] 46 | | GlWindow, [INFO] [stderr] 47 | | Device, [INFO] [stderr] ... | [INFO] [stderr] 51 | | Void, [INFO] [stderr] 52 | | > [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/graphics/platform/mod.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | ..self [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn is_gl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn is_metal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/platform/mod.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn is_d3d11(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | .unwrap_or(Duration::zero()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Duration::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | / match event { [INFO] [stderr] 369 | | Event::WindowEvent { event, .. } => { [INFO] [stderr] 370 | | match event { [INFO] [stderr] 371 | | WindowEvent::Closed | [INFO] [stderr] ... | [INFO] [stderr] 420 | | _ => (), [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 368 | if let Event::WindowEvent { event, .. } = event { [INFO] [stderr] 369 | match event { [INFO] [stderr] 370 | WindowEvent::Closed | [INFO] [stderr] 371 | WindowEvent::KeyboardInput { [INFO] [stderr] 372 | input: KeyboardInput { [INFO] [stderr] 373 | virtual_keycode: Some(VirtualKeyCode::Escape), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:393:29 [INFO] [stderr] | [INFO] [stderr] 393 | / match input { [INFO] [stderr] 394 | | KeyboardInput { [INFO] [stderr] 395 | | state, [INFO] [stderr] 396 | | virtual_keycode: Some(vk_code), [INFO] [stderr] ... | [INFO] [stderr] 411 | | _ => {} [INFO] [stderr] 412 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 393 | if let KeyboardInput { [INFO] [stderr] 394 | state, [INFO] [stderr] 395 | virtual_keycode: Some(vk_code), [INFO] [stderr] 396 | .. [INFO] [stderr] 397 | } = input { [INFO] [stderr] 398 | let is_pressed = state == ElementState::Pressed; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:494:25 [INFO] [stderr] | [INFO] [stderr] 494 | cast(x).unwrap_or(Zero::zero()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:495:25 [INFO] [stderr] | [INFO] [stderr] 495 | cast(y).unwrap_or(Zero::zero()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Zero::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/main.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | / self.get_inner_size().map(cast_pair).unwrap_or( [INFO] [stderr] 500 | | Default::default(), [INFO] [stderr] 501 | | ) [INFO] [stderr] | |_________^ help: try this: `self.get_inner_size().map(cast_pair).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 4m 59s [INFO] running `"docker" "inspect" "2ff28531cd305f3aa433f84363a8f90bd4c7e86cd12e17a5c8570687548383c8"` [INFO] running `"docker" "rm" "-f" "2ff28531cd305f3aa433f84363a8f90bd4c7e86cd12e17a5c8570687548383c8"` [INFO] [stdout] 2ff28531cd305f3aa433f84363a8f90bd4c7e86cd12e17a5c8570687548383c8