[INFO] updating cached repository burberger/rusty_terrain
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/burberger/rusty_terrain
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/burberger/rusty_terrain" "work/ex/clippy-test-run/sources/stable/gh/burberger/rusty_terrain"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/burberger/rusty_terrain'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/burberger/rusty_terrain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burberger/rusty_terrain"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burberger/rusty_terrain'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 19643fc014a64fb00a31411e43fc2442677a270a
[INFO] sha for GitHub repo burberger/rusty_terrain: 19643fc014a64fb00a31411e43fc2442677a270a
[INFO] validating manifest of burberger/rusty_terrain on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of burberger/rusty_terrain on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing burberger/rusty_terrain
[INFO] finished frobbing burberger/rusty_terrain
[INFO] frobbed toml for burberger/rusty_terrain written to work/ex/clippy-test-run/sources/stable/gh/burberger/rusty_terrain/Cargo.toml
[INFO] started frobbing burberger/rusty_terrain
[INFO] finished frobbing burberger/rusty_terrain
[INFO] frobbed toml for burberger/rusty_terrain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/burberger/rusty_terrain/Cargo.toml
[INFO] crate burberger/rusty_terrain has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting burberger/rusty_terrain against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/burberger/rusty_terrain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 676b05a7ea56256289b6bf535e942e4126c801e414f45b7be348c652bf36659e
[INFO] running `"docker" "start" "-a" "676b05a7ea56256289b6bf535e942e4126c801e414f45b7be348c652bf36659e"`
[INFO] [stderr]     Checking rayon-core v1.0.0
[INFO] [stderr]     Checking ndarray v0.9.1
[INFO] [stderr]     Checking rayon v0.7.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.12
[INFO] [stderr]     Checking image v0.13.0
[INFO] [stderr]     Checking rusty_terrain v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the loop variable `i` is used to index `corner_values`
[INFO] [stderr]   --> src/grid.rs:42:14
[INFO] [stderr]    |
[INFO] [stderr] 42 |     for i in 0..4 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 42 |     for (i, <item>) in corner_values.iter().enumerate().take(4) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/grid.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let ref mut grid_view = grid.view_mut();
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^^^------------------- help: try: `let grid_view = &mut grid.view_mut();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max = max / (max_val as f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max /= (max_val as f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max = max / (max_val as f64);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     min = min / (min_val as f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min /= (min_val as f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |     min = min / (min_val as f64);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: try: `f64::from(min_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             *elem = *elem / max;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*elem /= max`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             *elem = *elem / min;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*elem /= min`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:109:47
[INFO] [stderr]     |
[INFO] [stderr] 109 |         diamond_square(&mut grid.slice_mut(s![..center+1, ..center+1]), rng);
[INFO] [stderr]     |                                               ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:109:59
[INFO] [stderr]     |
[INFO] [stderr] 109 |         diamond_square(&mut grid.slice_mut(s![..center+1, ..center+1]), rng);
[INFO] [stderr]     |                                                           ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 |         diamond_square(&mut grid.slice_mut(s![center.., ..center+1]), rng);
[INFO] [stderr]     |                                                         ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:113:47
[INFO] [stderr]     |
[INFO] [stderr] 113 |         diamond_square(&mut grid.slice_mut(s![..center+1, center..]), rng);
[INFO] [stderr]     |                                               ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let ref mut fout = File::create(&Path::new("test.png")).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^^^^^------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("test.png")).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let ref mut get_sample = || normal.ind_sample(&mut rng);
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^^---------------------------------- help: try: `let get_sample = &mut (|| normal.ind_sample(&mut rng));`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let ref mut grid_view = grid.view_mut();
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^------------------- help: try: `let grid_view = &mut grid.view_mut();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `corner_values`
[INFO] [stderr]   --> src/grid.rs:42:14
[INFO] [stderr]    |
[INFO] [stderr] 42 |     for i in 0..4 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 42 |     for (i, <item>) in corner_values.iter().enumerate().take(4) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/grid.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let ref mut grid_view = grid.view_mut();
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^^^------------------- help: try: `let grid_view = &mut grid.view_mut();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max = max / (max_val as f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max /= (max_val as f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 |     max = max / (max_val as f64);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     min = min / (min_val as f64);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min /= (min_val as f64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/grid.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |     min = min / (min_val as f64);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^ help: try: `f64::from(min_val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             *elem = *elem / max;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*elem /= max`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/grid.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             *elem = *elem / min;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*elem /= min`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:109:47
[INFO] [stderr]     |
[INFO] [stderr] 109 |         diamond_square(&mut grid.slice_mut(s![..center+1, ..center+1]), rng);
[INFO] [stderr]     |                                               ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:109:59
[INFO] [stderr]     |
[INFO] [stderr] 109 |         diamond_square(&mut grid.slice_mut(s![..center+1, ..center+1]), rng);
[INFO] [stderr]     |                                                           ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 |         diamond_square(&mut grid.slice_mut(s![center.., ..center+1]), rng);
[INFO] [stderr]     |                                                         ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grid.rs:113:47
[INFO] [stderr]     |
[INFO] [stderr] 113 |         diamond_square(&mut grid.slice_mut(s![..center+1, center..]), rng);
[INFO] [stderr]     |                                               ^^^^^^^^^^ help: use: `..=center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let ref mut fout = File::create(&Path::new("test.png")).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^^^^^------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("test.png")).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |     let ref mut get_sample = || normal.ind_sample(&mut rng);
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^^---------------------------------- help: try: `let get_sample = &mut (|| normal.ind_sample(&mut rng));`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let ref mut grid_view = grid.view_mut();
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^------------------- help: try: `let grid_view = &mut grid.view_mut();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.09s
[INFO] running `"docker" "inspect" "676b05a7ea56256289b6bf535e942e4126c801e414f45b7be348c652bf36659e"`
[INFO] running `"docker" "rm" "-f" "676b05a7ea56256289b6bf535e942e4126c801e414f45b7be348c652bf36659e"`
[INFO] [stdout] 676b05a7ea56256289b6bf535e942e4126c801e414f45b7be348c652bf36659e