[INFO] updating cached repository bundai223/nes-sprite-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bundai223/nes-sprite-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bundai223/nes-sprite-rust" "work/ex/clippy-test-run/sources/stable/gh/bundai223/nes-sprite-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bundai223/nes-sprite-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bundai223/nes-sprite-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bundai223/nes-sprite-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bundai223/nes-sprite-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ebea6adebea57290ea26474b636e3bed69759144
[INFO] sha for GitHub repo bundai223/nes-sprite-rust: ebea6adebea57290ea26474b636e3bed69759144
[INFO] validating manifest of bundai223/nes-sprite-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bundai223/nes-sprite-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bundai223/nes-sprite-rust
[INFO] finished frobbing bundai223/nes-sprite-rust
[INFO] frobbed toml for bundai223/nes-sprite-rust written to work/ex/clippy-test-run/sources/stable/gh/bundai223/nes-sprite-rust/Cargo.toml
[INFO] started frobbing bundai223/nes-sprite-rust
[INFO] finished frobbing bundai223/nes-sprite-rust
[INFO] frobbed toml for bundai223/nes-sprite-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bundai223/nes-sprite-rust/Cargo.toml
[INFO] crate bundai223/nes-sprite-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bundai223/nes-sprite-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bundai223/nes-sprite-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b239e48b5713b592f2cb6d33cf996ff5c540269b8e0fce2fc0a2393b0eb3cec1
[INFO] running `"docker" "start" "-a" "b239e48b5713b592f2cb6d33cf996ff5c540269b8e0fce2fc0a2393b0eb3cec1"`
[INFO] [stderr]     Checking bmp v0.3.0
[INFO] [stderr]     Checking nes-rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `bmp::Image`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use bmp::Image;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return tmpvec.into_boxed_slice();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tmpvec.into_boxed_slice()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     return Header{
[INFO] [stderr] 36 | |         signature: vec![(*rom)[0].into(), (*rom)[1].into(), (*rom)[2].into(), (*rom)[3].into()],
[INFO] [stderr] 37 | |         prg_rom: Page{ start: prg_page_start, end: prg_page_end, num: prg_page},
[INFO] [stderr] 38 | |         chr_rom: Page{ start: chr_page_start, end: chr_page_end, num: chr_page}
[INFO] [stderr] 39 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 35 |     Header{
[INFO] [stderr] 36 |         signature: vec![(*rom)[0].into(), (*rom)[1].into(), (*rom)[2].into(), (*rom)[3].into()],
[INFO] [stderr] 37 |         prg_rom: Page{ start: prg_page_start, end: prg_page_end, num: prg_page},
[INFO] [stderr] 38 |         chr_rom: Page{ start: chr_page_start, end: chr_page_end, num: chr_page}
[INFO] [stderr] 39 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `NES_HEADER_SIZE`
[INFO] [stderr]  --> src/main.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | const NES_HEADER_SIZE: usize = 6;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: local variable doesn't need to be boxed here
[INFO] [stderr]   --> src/main.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 | fn header_dump(rom: Box<[u8]>) -> Header {
[INFO] [stderr]    |                ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::boxed_local)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `NES_HEADER_SIGNATURE_SIZE`
[INFO] [stderr]   --> src/main.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let prg_page = (*rom)[NES_HEADER_SIGNATURE_SIZE + 0] as usize;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `NES_HEADER_SIGNATURE_SIZE`
[INFO] [stderr]   --> src/main.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let prg_page_start = NES_HEADER_SIGNATURE_SIZE + 0;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `bmp::Image`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use bmp::Image;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return tmpvec.into_boxed_slice();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tmpvec.into_boxed_slice()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     return Header{
[INFO] [stderr] 36 | |         signature: vec![(*rom)[0].into(), (*rom)[1].into(), (*rom)[2].into(), (*rom)[3].into()],
[INFO] [stderr] 37 | |         prg_rom: Page{ start: prg_page_start, end: prg_page_end, num: prg_page},
[INFO] [stderr] 38 | |         chr_rom: Page{ start: chr_page_start, end: chr_page_end, num: chr_page}
[INFO] [stderr] 39 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 35 |     Header{
[INFO] [stderr] 36 |         signature: vec![(*rom)[0].into(), (*rom)[1].into(), (*rom)[2].into(), (*rom)[3].into()],
[INFO] [stderr] 37 |         prg_rom: Page{ start: prg_page_start, end: prg_page_end, num: prg_page},
[INFO] [stderr] 38 |         chr_rom: Page{ start: chr_page_start, end: chr_page_end, num: chr_page}
[INFO] [stderr] 39 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `NES_HEADER_SIZE`
[INFO] [stderr]  --> src/main.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | const NES_HEADER_SIZE: usize = 6;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: local variable doesn't need to be boxed here
[INFO] [stderr]   --> src/main.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 | fn header_dump(rom: Box<[u8]>) -> Header {
[INFO] [stderr]    |                ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::boxed_local)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `NES_HEADER_SIGNATURE_SIZE`
[INFO] [stderr]   --> src/main.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let prg_page = (*rom)[NES_HEADER_SIGNATURE_SIZE + 0] as usize;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `NES_HEADER_SIGNATURE_SIZE`
[INFO] [stderr]   --> src/main.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let prg_page_start = NES_HEADER_SIGNATURE_SIZE + 0;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.28s
[INFO] running `"docker" "inspect" "b239e48b5713b592f2cb6d33cf996ff5c540269b8e0fce2fc0a2393b0eb3cec1"`
[INFO] running `"docker" "rm" "-f" "b239e48b5713b592f2cb6d33cf996ff5c540269b8e0fce2fc0a2393b0eb3cec1"`
[INFO] [stdout] b239e48b5713b592f2cb6d33cf996ff5c540269b8e0fce2fc0a2393b0eb3cec1