[INFO] updating cached repository budgebi/syntax [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/budgebi/syntax [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/budgebi/syntax" "work/ex/clippy-test-run/sources/stable/gh/budgebi/syntax"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/budgebi/syntax'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/budgebi/syntax" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/budgebi/syntax"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/budgebi/syntax'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2341c1b1cc19c923b52cfa6ec6065581bdd5fbe2 [INFO] sha for GitHub repo budgebi/syntax: 2341c1b1cc19c923b52cfa6ec6065581bdd5fbe2 [INFO] validating manifest of budgebi/syntax on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of budgebi/syntax on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing budgebi/syntax [INFO] finished frobbing budgebi/syntax [INFO] frobbed toml for budgebi/syntax written to work/ex/clippy-test-run/sources/stable/gh/budgebi/syntax/Cargo.toml [INFO] started frobbing budgebi/syntax [INFO] finished frobbing budgebi/syntax [INFO] frobbed toml for budgebi/syntax written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/budgebi/syntax/Cargo.toml [INFO] crate budgebi/syntax has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting budgebi/syntax against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/budgebi/syntax:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86561d70277083f882dd38469c492ad8a86f1748a20f6297204a2bd67f856d52 [INFO] running `"docker" "start" "-a" "86561d70277083f882dd38469c492ad8a86f1748a20f6297204a2bd67f856d52"` [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Checking glib-sys v0.7.0 [INFO] [stderr] Checking gobject-sys v0.7.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking gio-sys v0.7.0 [INFO] [stderr] Checking pango-sys v0.7.0 [INFO] [stderr] Checking atk-sys v0.7.0 [INFO] [stderr] Checking gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Checking cairo-sys-rs v0.7.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking gdk-sys v0.7.0 [INFO] [stderr] Checking cairo-rs v0.5.0 [INFO] [stderr] Checking gtk-sys v0.7.0 [INFO] [stderr] Checking gdk-pixbuf v0.5.0 [INFO] [stderr] Checking gdk v0.9.0 [INFO] [stderr] Checking gtk v0.5.0 [INFO] [stderr] Checking syntax v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bricks.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | self.get_style_context().map(|c| c.add_class(css_class)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = self.get_style_context() { c.add_class(css_class) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match syntax.left_file { [INFO] [stderr] 34 | | Some(f) => { [INFO] [stderr] 35 | | let contents = fs::read_to_string(f); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(f) = syntax.left_file { [INFO] [stderr] 34 | let contents = fs::read_to_string(f); [INFO] [stderr] 35 | [INFO] [stderr] 36 | match contents { [INFO] [stderr] 37 | Ok(c) => { [INFO] [stderr] 38 | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match contents { [INFO] [stderr] 38 | | Ok(c) => { [INFO] [stderr] 39 | | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | Err(..) => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Ok(c) = contents { [INFO] [stderr] 38 | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bricks.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | self.get_style_context().map(|c| c.add_class(css_class)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = self.get_style_context() { c.add_class(css_class) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match syntax.left_file { [INFO] [stderr] 34 | | Some(f) => { [INFO] [stderr] 35 | | let contents = fs::read_to_string(f); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 45 | | None => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(f) = syntax.left_file { [INFO] [stderr] 34 | let contents = fs::read_to_string(f); [INFO] [stderr] 35 | [INFO] [stderr] 36 | match contents { [INFO] [stderr] 37 | Ok(c) => { [INFO] [stderr] 38 | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match contents { [INFO] [stderr] 38 | | Ok(c) => { [INFO] [stderr] 39 | | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | Err(..) => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Ok(c) = contents { [INFO] [stderr] 38 | syntax.left_editor.get_buffer().unwrap().set_text(&c); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 49s [INFO] running `"docker" "inspect" "86561d70277083f882dd38469c492ad8a86f1748a20f6297204a2bd67f856d52"` [INFO] running `"docker" "rm" "-f" "86561d70277083f882dd38469c492ad8a86f1748a20f6297204a2bd67f856d52"` [INFO] [stdout] 86561d70277083f882dd38469c492ad8a86f1748a20f6297204a2bd67f856d52