[INFO] updating cached repository bstrydo/xconf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bstrydo/xconf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bstrydo/xconf" "work/ex/clippy-test-run/sources/stable/gh/bstrydo/xconf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bstrydo/xconf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bstrydo/xconf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bstrydo/xconf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bstrydo/xconf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1ab32ad4d6e1445ed7f04c3050400f90cca067d3
[INFO] sha for GitHub repo bstrydo/xconf: 1ab32ad4d6e1445ed7f04c3050400f90cca067d3
[INFO] validating manifest of bstrydo/xconf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bstrydo/xconf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bstrydo/xconf
[INFO] finished frobbing bstrydo/xconf
[INFO] frobbed toml for bstrydo/xconf written to work/ex/clippy-test-run/sources/stable/gh/bstrydo/xconf/Cargo.toml
[INFO] started frobbing bstrydo/xconf
[INFO] finished frobbing bstrydo/xconf
[INFO] frobbed toml for bstrydo/xconf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bstrydo/xconf/Cargo.toml
[INFO] crate bstrydo/xconf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bstrydo/xconf against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bstrydo/xconf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fb2e57259d5edab00c05babaeaebf7c91177a6dd6b8a03cd82a7fb7a5975185b
[INFO] running `"docker" "start" "-a" "fb2e57259d5edab00c05babaeaebf7c91177a6dd6b8a03cd82a7fb7a5975185b"`
[INFO] [stderr]     Checking idna v0.1.2
[INFO] [stderr]     Checking url v1.5.1
[INFO] [stderr]     Checking hyper v0.10.12
[INFO] [stderr]     Checking iron v0.5.1
[INFO] [stderr]     Checking router v0.5.1
[INFO] [stderr]     Checking xconf v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: variable `weird` is assigned to, but never used
[INFO] [stderr]   --> src/bin/lifetimes.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let weird; //starts living here
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_weird` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `weird` is never read
[INFO] [stderr]   --> src/bin/lifetimes.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         weird = do_something_weird(&my_v1, 3, my_v2);
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]  --> src/bin/factorial.rs:2:13
[INFO] [stderr]   |
[INFO] [stderr] 2 |     (1..n+1).fold(1, |fac, x| fac *x)
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/bin/factorial.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 |     (1..n+1).fold(1, |fac, x| fac *x)
[INFO] [stderr]   |     ^^^^^^^^ help: use: `(1..=n)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: variable `weird` is assigned to, but never used
[INFO] [stderr]   --> src/bin/lifetimes.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let weird; //starts living here
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_weird` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `weird` is never read
[INFO] [stderr]   --> src/bin/lifetimes.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         weird = do_something_weird(&my_v1, 3, my_v2);
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/thread_example.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let mut handles = vec![
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/bin/thread_example.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         handle.join();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/thread_example.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let mut handles = vec![
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/bin/thread_example.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         handle.join();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]  --> src/bin/factorial.rs:2:13
[INFO] [stderr]   |
[INFO] [stderr] 2 |     (1..n+1).fold(1, |fac, x| fac *x)
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/bin/factorial.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 |     (1..n+1).fold(1, |fac, x| fac *x)
[INFO] [stderr]   |     ^^^^^^^^ help: use: `(1..=n)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.26s
[INFO] running `"docker" "inspect" "fb2e57259d5edab00c05babaeaebf7c91177a6dd6b8a03cd82a7fb7a5975185b"`
[INFO] running `"docker" "rm" "-f" "fb2e57259d5edab00c05babaeaebf7c91177a6dd6b8a03cd82a7fb7a5975185b"`
[INFO] [stdout] fb2e57259d5edab00c05babaeaebf7c91177a6dd6b8a03cd82a7fb7a5975185b