[INFO] updating cached repository bss/muni-schedule [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bss/muni-schedule [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bss/muni-schedule" "work/ex/clippy-test-run/sources/stable/gh/bss/muni-schedule"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bss/muni-schedule'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bss/muni-schedule" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bss/muni-schedule"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bss/muni-schedule'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b6bbd1c48db479d96fdbe2df1e09353bbbea1e1 [INFO] sha for GitHub repo bss/muni-schedule: 1b6bbd1c48db479d96fdbe2df1e09353bbbea1e1 [INFO] validating manifest of bss/muni-schedule on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bss/muni-schedule on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bss/muni-schedule [INFO] finished frobbing bss/muni-schedule [INFO] frobbed toml for bss/muni-schedule written to work/ex/clippy-test-run/sources/stable/gh/bss/muni-schedule/Cargo.toml [INFO] started frobbing bss/muni-schedule [INFO] finished frobbing bss/muni-schedule [INFO] frobbed toml for bss/muni-schedule written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bss/muni-schedule/Cargo.toml [INFO] crate bss/muni-schedule has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bss/muni-schedule against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bss/muni-schedule:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5335984052fb4db0e014dcf082682d4e552eefe2646c7adf71d4d666dd428d2d [INFO] running `"docker" "start" "-a" "5335984052fb4db0e014dcf082682d4e552eefe2646c7adf71d4d666dd428d2d"` [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking encoding_rs v0.8.10 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking conrod v0.61.1 [INFO] [stderr] Checking muni-schedule-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | inbound: inbound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inbound` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | outbound: outbound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outbound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/prediction.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | route_title: route_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/prediction.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | route_tag: route_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/vehicle.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | route_tag: route_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/vehicle.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/vehicle_icon.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | latitude: latitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `latitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | longitude: longitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `longitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | latitude: latitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `latitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | longitude: longitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `longitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | secs_since_report: secs_since_report, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secs_since_report` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | path_start: path_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | path_end: path_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `path_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | static_data: static_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `static_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | overlay_items: overlay_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overlay_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route_overview.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:22 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | inbound: inbound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inbound` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | outbound: outbound, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outbound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/route.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/prediction.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | route_title: route_title, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/prediction.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | route_tag: route_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/vehicle.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | route_tag: route_tag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `route_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nextbus/vehicle.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/vehicle_icon.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | latitude: latitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `latitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | longitude: longitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `longitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | latitude: latitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `latitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | longitude: longitude, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `longitude` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/util.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | icon: icon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `icon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | secs_since_report: secs_since_report, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secs_since_report` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | path_start: path_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | path_end: path_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `path_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | static_data: static_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `static_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapbox/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | overlay_items: overlay_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overlay_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route_overview.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:22 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/gui.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | let (h, s, l) = conrod::color::rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mapbox/api.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const MAPBOX_TOKEN : &'static str = "pk.eyJ1IjoiYnNzZGsiLCJhIjoiY2prYW42NWFlMjZkNzNra3lnYnB6djRscCJ9.KEJKmTjzzjtKVMyxS_Y93A"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `Borderable` [INFO] [stderr] --> src/mapbox/vehicle_icon.rs:5:64 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{color, Sizeable, Widget, Positionable, Colorable, Borderable}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/app_config.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | latitude: 37.775483, [INFO] [stderr] | ^^^^^^^^^ help: consider: `37.775_483` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/app_config.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | longitude: -122.418777, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `122.418_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | (|tx| std::thread::spawn(move || redraw_thread(tx)) )(event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | (|line, tx| { std::thread::spawn(move || route_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | (|line, tx| { std::thread::spawn(move || prediction_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | (|line, tx| { std::thread::spawn(move || vehicle_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mapbox/api.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const MAPBOX_TOKEN : &'static str = "pk.eyJ1IjoiYnNzZGsiLCJhIjoiY2prYW42NWFlMjZkNzNra3lnYnB6djRscCJ9.KEJKmTjzzjtKVMyxS_Y93A"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `Borderable` [INFO] [stderr] --> src/mapbox/vehicle_icon.rs:5:64 [INFO] [stderr] | [INFO] [stderr] 5 | use conrod::{color, Sizeable, Widget, Positionable, Colorable, Borderable}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/app_config.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | latitude: 37.775483, [INFO] [stderr] | ^^^^^^^^^ help: consider: `37.775_483` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/app_config.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | longitude: -122.418777, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `122.418_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | (|tx| std::thread::spawn(move || redraw_thread(tx)) )(event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | (|line, tx| { std::thread::spawn(move || route_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | (|line, tx| { std::thread::spawn(move || prediction_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | (|line, tx| { std::thread::spawn(move || vehicle_fetcher_loop(line, tx)) })(line.clone(), event_tx.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | Err(err) => println!("Could not load tram icon, continueing without"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | Err(err) => println!("Could not load bus icon, continueing without"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | Err(err) => println!("Could not load tram icon, continueing without"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | Err(err) => println!("Could not load bus icon, continueing without"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nextbus/route.rs:147:8 [INFO] [stderr] | [INFO] [stderr] 147 | if json_route_path.point.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!json_route_path.point.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/route.rs:159:57 [INFO] [stderr] | [INFO] [stderr] 159 | fn from(json_direction: &JsonRouteDirection, stops: &Vec) -> Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[JsonRouteStop]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/route.rs:170:58 [INFO] [stderr] | [INFO] [stderr] 170 | fn from(stop_tag: &JsonRouteDirectionStopTag, stops: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[JsonRouteStop]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/nextbus/route.rs:147:8 [INFO] [stderr] | [INFO] [stderr] 147 | if json_route_path.point.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!json_route_path.point.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/route.rs:159:57 [INFO] [stderr] | [INFO] [stderr] 159 | fn from(json_direction: &JsonRouteDirection, stops: &Vec) -> Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[JsonRouteStop]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/route.rs:170:58 [INFO] [stderr] | [INFO] [stderr] 170 | fn from(stop_tag: &JsonRouteDirectionStopTag, stops: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[JsonRouteStop]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/prediction.rs:68:56 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn fetch(agency: &str, route: &str, stop_tags: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nextbus/prediction.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | Duration::new((self.minutes as u64) * 60 + (self.seconds as u64), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nextbus/prediction.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | Duration::new((self.minutes as u64) * 60 + (self.seconds as u64), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nextbus/prediction.rs:128:71 [INFO] [stderr] | [INFO] [stderr] 128 | .flat_map( |json| json.prediction.into_vec().into_iter().map( |jsp| DirectionPrediction::from(jsp) ) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DirectionPrediction::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/nextbus/prediction.rs:142:34 [INFO] [stderr] | [INFO] [stderr] 142 | affected_by_layover: json_direction_prediction.affected_by_layover.clone().map_or(None, |v| v.parse::().ok() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `json_direction_prediction.affected_by_layover.clone().and_then(|v| v.parse::().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/nextbus/prediction.rs:146:34 [INFO] [stderr] | [INFO] [stderr] 146 | vehicles_in_consist: json_direction_prediction.affected_by_layover.clone().map_or(None, |v| v.parse::().ok() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `json_direction_prediction.affected_by_layover.clone().and_then(|v| v.parse::().ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/nextbus/vehicle.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | let dir_tag = json_vehicle.dir_tag.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json_vehicle.dir_tag.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nextbus/prediction.rs:68:56 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn fetch(agency: &str, route: &str, stop_tags: &Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nextbus/prediction.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | Duration::new((self.minutes as u64) * 60 + (self.seconds as u64), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.minutes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nextbus/prediction.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | Duration::new((self.minutes as u64) * 60 + (self.seconds as u64), 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nextbus/prediction.rs:128:71 [INFO] [stderr] | [INFO] [stderr] 128 | .flat_map( |json| json.prediction.into_vec().into_iter().map( |jsp| DirectionPrediction::from(jsp) ) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DirectionPrediction::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/nextbus/prediction.rs:142:34 [INFO] [stderr] | [INFO] [stderr] 142 | affected_by_layover: json_direction_prediction.affected_by_layover.clone().map_or(None, |v| v.parse::().ok() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `json_direction_prediction.affected_by_layover.clone().and_then(|v| v.parse::().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/nextbus/prediction.rs:146:34 [INFO] [stderr] | [INFO] [stderr] 146 | vehicles_in_consist: json_direction_prediction.affected_by_layover.clone().map_or(None, |v| v.parse::().ok() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `json_direction_prediction.affected_by_layover.clone().and_then(|v| v.parse::().ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapbox/mod.rs:138:63 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn new(static_data: &'a StaticMapData, overlay_items: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OverlayItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mapbox/mod.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | let img_left_pad = ((background_image.width as f64) - img_w) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(background_image.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mapbox/mod.rs:212:24 [INFO] [stderr] | [INFO] [stderr] 212 | let img_top_pad = ((background_image.height as f64) - img_h) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(background_image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_overview.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if inbounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inbounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_overview.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if outbounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outbounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/gui.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn set_widgets(ref mut ui: conrod::UiCell, ids: &Ids, static_app: &StaticApp, dynamic_app: &App) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/nextbus/vehicle.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | let dir_tag = json_vehicle.dir_tag.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json_vehicle.dir_tag.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | RouteData(nextbus::Route), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 28 | RouteData(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out`. [INFO] [stderr] --> src/main.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for in &mut out { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapbox/mod.rs:138:63 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn new(static_data: &'a StaticMapData, overlay_items: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OverlayItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / let window; [INFO] [stderr] 194 | | if fullscreen { [INFO] [stderr] 195 | | window = glium::glutin::WindowBuilder::new() [INFO] [stderr] 196 | | .with_title("Muni Schedule") [INFO] [stderr] ... | [INFO] [stderr] 201 | | .with_dimensions((WIN_W, WIN_H).into()); [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 193 | let window = if fullscreen { glium::glutin::WindowBuilder::new() [INFO] [stderr] 194 | .with_title("Muni Schedule") [INFO] [stderr] 195 | .with_fullscreen(Some(events_loop.get_primary_monitor())) } else { glium::glutin::WindowBuilder::new() [INFO] [stderr] 196 | .with_title("Muni Schedule") [INFO] [stderr] 197 | .with_dimensions((WIN_W, WIN_H).into()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mapbox/mod.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | let img_left_pad = ((background_image.width as f64) - img_w) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(background_image.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mapbox/mod.rs:212:24 [INFO] [stderr] | [INFO] [stderr] 212 | let img_top_pad = ((background_image.height as f64) - img_h) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(background_image.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_overview.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if inbounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inbounds.is_empty()` [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:325:42 [INFO] [stderr] | [INFO] [stderr] 325 | let mut ui = conrod::UiBuilder::new([WIN_W as f64, WIN_H as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIN_W)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:325:56 [INFO] [stderr] | [INFO] [stderr] 325 | let mut ui = conrod::UiBuilder::new([WIN_W as f64, WIN_H as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIN_H)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_overview.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if outbounds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outbounds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/gui.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn set_widgets(ref mut ui: conrod::UiCell, ids: &Ids, static_app: &StaticApp, dynamic_app: &App) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | RouteData(nextbus::Route), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 28 | RouteData(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out`. [INFO] [stderr] --> src/main.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for in &mut out { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / let window; [INFO] [stderr] 194 | | if fullscreen { [INFO] [stderr] 195 | | window = glium::glutin::WindowBuilder::new() [INFO] [stderr] 196 | | .with_title("Muni Schedule") [INFO] [stderr] ... | [INFO] [stderr] 201 | | .with_dimensions((WIN_W, WIN_H).into()); [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 193 | let window = if fullscreen { glium::glutin::WindowBuilder::new() [INFO] [stderr] 194 | .with_title("Muni Schedule") [INFO] [stderr] 195 | .with_fullscreen(Some(events_loop.get_primary_monitor())) } else { glium::glutin::WindowBuilder::new() [INFO] [stderr] 196 | .with_title("Muni Schedule") [INFO] [stderr] 197 | .with_dimensions((WIN_W, WIN_H).into()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:325:42 [INFO] [stderr] | [INFO] [stderr] 325 | let mut ui = conrod::UiBuilder::new([WIN_W as f64, WIN_H as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIN_W)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:325:56 [INFO] [stderr] | [INFO] [stderr] 325 | let mut ui = conrod::UiBuilder::new([WIN_W as f64, WIN_H as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIN_H)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 47s [INFO] running `"docker" "inspect" "5335984052fb4db0e014dcf082682d4e552eefe2646c7adf71d4d666dd428d2d"` [INFO] running `"docker" "rm" "-f" "5335984052fb4db0e014dcf082682d4e552eefe2646c7adf71d4d666dd428d2d"` [INFO] [stdout] 5335984052fb4db0e014dcf082682d4e552eefe2646c7adf71d4d666dd428d2d