[INFO] updating cached repository bspride/wd-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bspride/wd-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bspride/wd-rust" "work/ex/clippy-test-run/sources/stable/gh/bspride/wd-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bspride/wd-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bspride/wd-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bspride/wd-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bspride/wd-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d0c90644df0527130816e3bcd48c7600cecdfe2 [INFO] sha for GitHub repo bspride/wd-rust: 3d0c90644df0527130816e3bcd48c7600cecdfe2 [INFO] validating manifest of bspride/wd-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bspride/wd-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bspride/wd-rust [INFO] finished frobbing bspride/wd-rust [INFO] frobbed toml for bspride/wd-rust written to work/ex/clippy-test-run/sources/stable/gh/bspride/wd-rust/Cargo.toml [INFO] started frobbing bspride/wd-rust [INFO] finished frobbing bspride/wd-rust [INFO] frobbed toml for bspride/wd-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bspride/wd-rust/Cargo.toml [INFO] crate bspride/wd-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bspride/wd-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bspride/wd-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f13415fed00e2c046c006525b330c911d0d216758fb760fd9a642466ae620f8f [INFO] running `"docker" "start" "-a" "f13415fed00e2c046c006525b330c911d0d216758fb760fd9a642466ae620f8f"` [INFO] [stderr] Compiling rustfmt v0.9.0 [INFO] [stderr] Checking diff v0.1.10 [INFO] [stderr] Checking strings v0.1.0 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Compiling extprim v1.4.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking wd_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cli/add.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | faves.insert(name.into(), path.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cli/warp.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let destination = warp_points.get(point).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&warp_points[point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Checking syntex_pos v0.59.1 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking toml v0.4.4 [INFO] [stderr] Checking syntex_errors v0.59.1 [INFO] [stderr] Checking syntex_syntax v0.59.1 [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cli/add.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | faves.insert(name.into(), path.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cli/warp.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let destination = warp_points.get(point).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&warp_points[point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.65s [INFO] running `"docker" "inspect" "f13415fed00e2c046c006525b330c911d0d216758fb760fd9a642466ae620f8f"` [INFO] running `"docker" "rm" "-f" "f13415fed00e2c046c006525b330c911d0d216758fb760fd9a642466ae620f8f"` [INFO] [stdout] f13415fed00e2c046c006525b330c911d0d216758fb760fd9a642466ae620f8f