[INFO] updating cached repository bryantheastronaut/r_dash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bryantheastronaut/r_dash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bryantheastronaut/r_dash" "work/ex/clippy-test-run/sources/stable/gh/bryantheastronaut/r_dash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bryantheastronaut/r_dash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bryantheastronaut/r_dash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bryantheastronaut/r_dash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bryantheastronaut/r_dash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dcc685cc93ebcbdc7bd072ec0f185b9664c09043 [INFO] sha for GitHub repo bryantheastronaut/r_dash: dcc685cc93ebcbdc7bd072ec0f185b9664c09043 [INFO] validating manifest of bryantheastronaut/r_dash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bryantheastronaut/r_dash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bryantheastronaut/r_dash [INFO] finished frobbing bryantheastronaut/r_dash [INFO] frobbed toml for bryantheastronaut/r_dash written to work/ex/clippy-test-run/sources/stable/gh/bryantheastronaut/r_dash/Cargo.toml [INFO] started frobbing bryantheastronaut/r_dash [INFO] finished frobbing bryantheastronaut/r_dash [INFO] frobbed toml for bryantheastronaut/r_dash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bryantheastronaut/r_dash/Cargo.toml [INFO] crate bryantheastronaut/r_dash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bryantheastronaut/r_dash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bryantheastronaut/r_dash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa9cc483331a2a568887356b7d59d566ff5e78cd7fa51b22b92a1c11b3dd6203 [INFO] running `"docker" "start" "-a" "aa9cc483331a2a568887356b7d59d566ff5e78cd7fa51b22b92a1c11b3dd6203"` [INFO] [stderr] Checking r_dash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/vec_utils.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vec_utils.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | if editing_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!editing_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/vec_utils.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if let None = v2.iter().position(|&i| i == item) { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 50 | | return_vec.push(item); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____- help: try this: `if v2.iter().position(|&i| i == item).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/vec_utils.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vec_utils.rs:26:6 [INFO] [stderr] | [INFO] [stderr] 26 | if editing_vec.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!editing_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/vec_utils.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if let None = v2.iter().position(|&i| i == item) { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 50 | | return_vec.push(item); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____- help: try this: `if v2.iter().position(|&i| i == item).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "aa9cc483331a2a568887356b7d59d566ff5e78cd7fa51b22b92a1c11b3dd6203"` [INFO] running `"docker" "rm" "-f" "aa9cc483331a2a568887356b7d59d566ff5e78cd7fa51b22b92a1c11b3dd6203"` [INFO] [stdout] aa9cc483331a2a568887356b7d59d566ff5e78cd7fa51b22b92a1c11b3dd6203