[INFO] updating cached repository brson/worklog-scan [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brson/worklog-scan [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brson/worklog-scan" "work/ex/clippy-test-run/sources/stable/gh/brson/worklog-scan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brson/worklog-scan'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brson/worklog-scan" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brson/worklog-scan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brson/worklog-scan'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5cc0a45fd99ac73bc512b33a0163ca102324e277 [INFO] sha for GitHub repo brson/worklog-scan: 5cc0a45fd99ac73bc512b33a0163ca102324e277 [INFO] validating manifest of brson/worklog-scan on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brson/worklog-scan on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brson/worklog-scan [INFO] finished frobbing brson/worklog-scan [INFO] frobbed toml for brson/worklog-scan written to work/ex/clippy-test-run/sources/stable/gh/brson/worklog-scan/Cargo.toml [INFO] started frobbing brson/worklog-scan [INFO] finished frobbing brson/worklog-scan [INFO] frobbed toml for brson/worklog-scan written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brson/worklog-scan/Cargo.toml [INFO] crate brson/worklog-scan has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brson/worklog-scan against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brson/worklog-scan:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 566f182ddfd137073e3ff6853e36e539d0afc1f1cb155238324670ee99ca5ec8 [INFO] running `"docker" "start" "-a" "566f182ddfd137073e3ff6853e36e539d0afc1f1cb155238324670ee99ca5ec8"` [INFO] [stderr] Compiling gcc v0.3.42 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking libc v0.2.20 [INFO] [stderr] Compiling backtrace v0.3.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking cfg-if v0.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.3 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking time v0.1.36 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Checking num-integer v0.1.33 [INFO] [stderr] Checking aho-corasick v0.6.1 [INFO] [stderr] Checking thread_local v0.3.2 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking worklog-scan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/time_reporting.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/time_reporting.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return RawEntry::Action(line.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RawEntry::Action(line.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return RawEntry::Action(line.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RawEntry::Action(line.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pleasure_and_pain.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let ref stats = week_stats.stats; [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let stats = &week_stats.stats;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | total_pr_pl += pr_pl as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pr_pl)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | total_pr_pn += pr_pn as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pr_pn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | total_ac_pl += ac_pl as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(ac_pl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | total_ac_pn += ac_pn as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(ac_pn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pleasure_and_pain.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let ref stats = week_stats.stats; [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let stats = &week_stats.stats;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:58:45 [INFO] [stderr] | [INFO] [stderr] 58 | let timestamp_to_minute_of_day = |h, m| (h as u32) * 60 + (m as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:58:63 [INFO] [stderr] | [INFO] [stderr] 58 | let timestamp_to_minute_of_day = |h, m| (h as u32) * 60 + (m as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | let minutes = minutes as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | total_pr_pl += pr_pl as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pr_pl)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | total_pr_pn += pr_pn as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pr_pn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | total_ac_pl += ac_pl as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(ac_pl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pleasure_and_pain.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | total_ac_pn += ac_pn as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(ac_pn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:58:45 [INFO] [stderr] | [INFO] [stderr] 58 | let timestamp_to_minute_of_day = |h, m| (h as u32) * 60 + (m as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:58:63 [INFO] [stderr] | [INFO] [stderr] 58 | let timestamp_to_minute_of_day = |h, m| (h as u32) * 60 + (m as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/time_reporting.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | let minutes = minutes as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | let file = env::args().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let mode = env::args().skip(2).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | let start = env::args().skip(3).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let end = env::args().skip(4).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | let file = env::args().skip(1).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let mode = env::args().skip(2).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | let start = env::args().skip(3).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let end = env::args().skip(4).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 20.85s [INFO] running `"docker" "inspect" "566f182ddfd137073e3ff6853e36e539d0afc1f1cb155238324670ee99ca5ec8"` [INFO] running `"docker" "rm" "-f" "566f182ddfd137073e3ff6853e36e539d0afc1f1cb155238324670ee99ca5ec8"` [INFO] [stdout] 566f182ddfd137073e3ff6853e36e539d0afc1f1cb155238324670ee99ca5ec8