[INFO] updating cached repository brooksmckinley/cups
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/brooksmckinley/cups
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/brooksmckinley/cups" "work/ex/clippy-test-run/sources/stable/gh/brooksmckinley/cups"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brooksmckinley/cups'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/brooksmckinley/cups" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brooksmckinley/cups"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brooksmckinley/cups'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3a6bf59431c0d3469d067182b32db459c07367d0
[INFO] sha for GitHub repo brooksmckinley/cups: 3a6bf59431c0d3469d067182b32db459c07367d0
[INFO] validating manifest of brooksmckinley/cups on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of brooksmckinley/cups on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing brooksmckinley/cups
[INFO] finished frobbing brooksmckinley/cups
[INFO] frobbed toml for brooksmckinley/cups written to work/ex/clippy-test-run/sources/stable/gh/brooksmckinley/cups/Cargo.toml
[INFO] started frobbing brooksmckinley/cups
[INFO] finished frobbing brooksmckinley/cups
[INFO] frobbed toml for brooksmckinley/cups written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brooksmckinley/cups/Cargo.toml
[INFO] crate brooksmckinley/cups has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting brooksmckinley/cups against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brooksmckinley/cups:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 36d8725e39fd885120f566700e6f89d6d7056c3fd8877fa41d747f28c025ef34
[INFO] running `"docker" "start" "-a" "36d8725e39fd885120f566700e6f89d6d7056c3fd8877fa41d747f28c025ef34"`
[INFO] [stderr]     Checking cups v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/cup.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 | /     pub fn new(name: String, serial_number: i32, color: String, handle: bool, max_fluid: f64) -> Mug {
[INFO] [stderr] 136 | |         Mug {
[INFO] [stderr] 137 | |             value_name: name,
[INFO] [stderr] 138 | |             value_serial: serial_number,
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |         }
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/cup.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 | /     pub fn new(name: String, serial_number: i32, color: String, max_fluid: f64) -> Mug {
[INFO] [stderr] 164 | |         Mug {
[INFO] [stderr] 165 | |             value_name: name,
[INFO] [stderr] 166 | |             value_serial: serial_number,
[INFO] [stderr] ...   |
[INFO] [stderr] 172 | |         }
[INFO] [stderr] 173 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in cups.as_slice().enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:88:16
[INFO] [stderr]    |
[INFO] [stderr] 88 |     for cup in cups.as_slice() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/cup.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 | /     pub fn new(name: String, serial_number: i32, color: String, handle: bool, max_fluid: f64) -> Mug {
[INFO] [stderr] 136 | |         Mug {
[INFO] [stderr] 137 | |             value_name: name,
[INFO] [stderr] 138 | |             value_serial: serial_number,
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |         }
[INFO] [stderr] 145 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/cup.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 | /     pub fn new(name: String, serial_number: i32, color: String, max_fluid: f64) -> Mug {
[INFO] [stderr] 164 | |         Mug {
[INFO] [stderr] 165 | |             value_name: name,
[INFO] [stderr] 166 | |             value_serial: serial_number,
[INFO] [stderr] ...   |
[INFO] [stderr] 172 | |         }
[INFO] [stderr] 173 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in cups.as_slice().enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:88:16
[INFO] [stderr]    |
[INFO] [stderr] 88 |     for cup in cups.as_slice() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:229:27
[INFO] [stderr]     |
[INFO] [stderr] 229 | fn inventory_report(cups: &Vec<Box<Cup>>) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^ help: change this to: `&[Box<Cup>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:229:27
[INFO] [stderr]     |
[INFO] [stderr] 229 | fn inventory_report(cups: &Vec<Box<Cup>>) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^ help: change this to: `&[Box<Cup>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `inventory_report` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:253:37
[INFO] [stderr]     |
[INFO] [stderr] 253 |             "4" => inventory_report(&mut cups),
[INFO] [stderr]     |                                     ^^^^^^^^^
[INFO] [stderr] warning: The function/method `inventory_report` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:253:37
[INFO] [stderr]     |
[INFO] [stderr] 253 |             "4" => inventory_report(&mut cups),
[INFO] [stderr]     |                                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.23s
[INFO] running `"docker" "inspect" "36d8725e39fd885120f566700e6f89d6d7056c3fd8877fa41d747f28c025ef34"`
[INFO] running `"docker" "rm" "-f" "36d8725e39fd885120f566700e6f89d6d7056c3fd8877fa41d747f28c025ef34"`
[INFO] [stdout] 36d8725e39fd885120f566700e6f89d6d7056c3fd8877fa41d747f28c025ef34