[INFO] updating cached repository brocode/fw [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brocode/fw [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brocode/fw" "work/ex/clippy-test-run/sources/stable/gh/brocode/fw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brocode/fw'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brocode/fw" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brocode/fw"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brocode/fw'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0366b3e0f9db23ea3f404fe120dcac88a05ce7c6 [INFO] sha for GitHub repo brocode/fw: 0366b3e0f9db23ea3f404fe120dcac88a05ce7c6 [INFO] validating manifest of brocode/fw on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brocode/fw on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brocode/fw [INFO] finished frobbing brocode/fw [INFO] frobbed toml for brocode/fw written to work/ex/clippy-test-run/sources/stable/gh/brocode/fw/Cargo.toml [INFO] started frobbing brocode/fw [INFO] finished frobbing brocode/fw [INFO] frobbed toml for brocode/fw written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brocode/fw/Cargo.toml [INFO] crate brocode/fw has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brocode/fw against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brocode/fw:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c2bf366a5e301d19b0c98e3d25cdce9e4bbb1d1791389bac8851c9626035c6a [INFO] running `"docker" "start" "-a" "6c2bf366a5e301d19b0c98e3d25cdce9e4bbb1d1791389bac8851c9626035c6a"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking libssh2-sys v0.2.11 [INFO] [stderr] Checking curl-sys v0.4.15 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking crossbeam-channel v0.3.1 [INFO] [stderr] Checking libgit2-sys v0.7.10 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking webpki v0.17.0 [INFO] [stderr] Checking sct v0.2.0 [INFO] [stderr] Checking ct-logs v0.2.0 [INFO] [stderr] Checking rustls v0.11.0 [INFO] [stderr] Checking webpki-roots v0.13.0 [INFO] [stderr] Checking tokio-rustls v0.4.0 [INFO] [stderr] Checking hyper-rustls v0.11.0 [INFO] [stderr] Checking github-gql-rs v0.0.1 [INFO] [stderr] Checking fw v1.16.1-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:365:57 [INFO] [stderr] | [INFO] [stderr] 365 | let resolved = config.resolve_after_workon(&logger, config.projects.get("test1").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test1"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:372:57 [INFO] [stderr] | [INFO] [stderr] 372 | let resolved = config.resolve_after_workon(&logger, config.projects.get("test5").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test5"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:379:56 [INFO] [stderr] | [INFO] [stderr] 379 | let resolved = config.resolve_after_clone(&logger, config.projects.get("test1").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:386:56 [INFO] [stderr] | [INFO] [stderr] 386 | let resolved = config.resolve_after_clone(&logger, config.projects.get("test5").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test5"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:393:57 [INFO] [stderr] | [INFO] [stderr] 393 | let resolved = config.resolve_after_workon(&logger, config.projects.get("test2").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:400:57 [INFO] [stderr] | [INFO] [stderr] 400 | let resolved = config.resolve_after_workon(&logger, config.projects.get("test4").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test4"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:407:56 [INFO] [stderr] | [INFO] [stderr] 407 | let resolved = config.resolve_after_clone(&logger, config.projects.get("test4").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test4"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:414:56 [INFO] [stderr] | [INFO] [stderr] 414 | let resolved = config.resolve_after_clone(&logger, config.projects.get("test2").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:421:57 [INFO] [stderr] | [INFO] [stderr] 421 | let resolved = config.resolve_after_workon(&logger, config.projects.get("test3").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:428:56 [INFO] [stderr] | [INFO] [stderr] 428 | let resolved = config.resolve_after_clone(&logger, config.projects.get("test3").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test3"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/export/mod.rs:114:66 [INFO] [stderr] | [INFO] [stderr] 114 | let exported_command = projects_to_shell_commands(&config, &[config.projects.get("test1").unwrap()]).expect("Should work"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.projects["test1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `"docker" "inspect" "6c2bf366a5e301d19b0c98e3d25cdce9e4bbb1d1791389bac8851c9626035c6a"` [INFO] running `"docker" "rm" "-f" "6c2bf366a5e301d19b0c98e3d25cdce9e4bbb1d1791389bac8851c9626035c6a"` [INFO] [stdout] 6c2bf366a5e301d19b0c98e3d25cdce9e4bbb1d1791389bac8851c9626035c6a