[INFO] updating cached repository brkydnc/trajectory-of-a-projectile [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brkydnc/trajectory-of-a-projectile [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brkydnc/trajectory-of-a-projectile" "work/ex/clippy-test-run/sources/stable/gh/brkydnc/trajectory-of-a-projectile"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brkydnc/trajectory-of-a-projectile'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brkydnc/trajectory-of-a-projectile" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brkydnc/trajectory-of-a-projectile"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brkydnc/trajectory-of-a-projectile'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da8e9a4f4dad26f7f4589fc2a530f059b1df25eb [INFO] sha for GitHub repo brkydnc/trajectory-of-a-projectile: da8e9a4f4dad26f7f4589fc2a530f059b1df25eb [INFO] validating manifest of brkydnc/trajectory-of-a-projectile on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brkydnc/trajectory-of-a-projectile on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brkydnc/trajectory-of-a-projectile [INFO] finished frobbing brkydnc/trajectory-of-a-projectile [INFO] frobbed toml for brkydnc/trajectory-of-a-projectile written to work/ex/clippy-test-run/sources/stable/gh/brkydnc/trajectory-of-a-projectile/Cargo.toml [INFO] started frobbing brkydnc/trajectory-of-a-projectile [INFO] finished frobbing brkydnc/trajectory-of-a-projectile [INFO] frobbed toml for brkydnc/trajectory-of-a-projectile written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brkydnc/trajectory-of-a-projectile/Cargo.toml [INFO] crate brkydnc/trajectory-of-a-projectile has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brkydnc/trajectory-of-a-projectile against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brkydnc/trajectory-of-a-projectile:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90cefaf7c1a0e589c1bc0c4d8716566671380c52865f6d7d10aa4833c7188240 [INFO] running `"docker" "start" "-a" "90cefaf7c1a0e589c1bc0c4d8716566671380c52865f6d7d10aa4833c7188240"` [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking trajectory-of-a-projectile v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | self.window.size().width as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window.size().width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | self.window.size().height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | for t in 1..self.trajectory_dot_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.trajectory_dot_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:36 [INFO] [stderr] | [INFO] [stderr] 128 | let x = velocity_mag * t as f64 * launch_angle.cos(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | let y = velocity_mag * t as f64 * launch_angle.sin() [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:46 [INFO] [stderr] | [INFO] [stderr] 130 | - 0.5 * (-self.gravity[1]) * (t as f64).powf(2.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | self.window.size().width as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window.size().width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | self.window.size().height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | for t in 1..self.trajectory_dot_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.trajectory_dot_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:36 [INFO] [stderr] | [INFO] [stderr] 128 | let x = velocity_mag * t as f64 * launch_angle.cos(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | let y = velocity_mag * t as f64 * launch_angle.sin() [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:46 [INFO] [stderr] | [INFO] [stderr] 130 | - 0.5 * (-self.gravity[1]) * (t as f64).powf(2.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "90cefaf7c1a0e589c1bc0c4d8716566671380c52865f6d7d10aa4833c7188240"` [INFO] running `"docker" "rm" "-f" "90cefaf7c1a0e589c1bc0c4d8716566671380c52865f6d7d10aa4833c7188240"` [INFO] [stdout] 90cefaf7c1a0e589c1bc0c4d8716566671380c52865f6d7d10aa4833c7188240