[INFO] updating cached repository brick-codes/palace-ai [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brick-codes/palace-ai [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brick-codes/palace-ai" "work/ex/clippy-test-run/sources/stable/gh/brick-codes/palace-ai"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brick-codes/palace-ai'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brick-codes/palace-ai" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brick-codes/palace-ai"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brick-codes/palace-ai'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1357d6f8c51a581c155f8789b3c2f489404e6406 [INFO] sha for GitHub repo brick-codes/palace-ai: 1357d6f8c51a581c155f8789b3c2f489404e6406 [INFO] validating manifest of brick-codes/palace-ai on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brick-codes/palace-ai on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brick-codes/palace-ai [INFO] finished frobbing brick-codes/palace-ai [INFO] frobbed toml for brick-codes/palace-ai written to work/ex/clippy-test-run/sources/stable/gh/brick-codes/palace-ai/Cargo.toml [INFO] started frobbing brick-codes/palace-ai [INFO] finished frobbing brick-codes/palace-ai [INFO] frobbed toml for brick-codes/palace-ai written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brick-codes/palace-ai/Cargo.toml [INFO] crate brick-codes/palace-ai has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brick-codes/palace-ai against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brick-codes/palace-ai:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae8a7c87fb3cd84665f56c0bd4f7ee17fe6a8d27638b9663e838330b0063b739 [INFO] running `"docker" "start" "-a" "ae8a7c87fb3cd84665f56c0bd4f7ee17fe6a8d27638b9663e838330b0063b739"` [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking ws v0.7.6 [INFO] [stderr] Checking palace-ai v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `CloseCode` [INFO] [stderr] --> src/main.rs:13:56 [INFO] [stderr] | [INFO] [stderr] 13 | use ws::{connect, Handler, Sender, Handshake, Message, CloseCode}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | use serde::{Deserialize, Serialize, Deserializer, Serializer}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `CloseCode` [INFO] [stderr] --> src/main.rs:13:56 [INFO] [stderr] | [INFO] [stderr] 13 | use ws::{connect, Handler, Sender, Handshake, Message, CloseCode}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `Serialize`, `Serializer` [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | use serde::{Deserialize, Serialize, Deserializer, Serializer}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reconnect_response` [INFO] [stderr] --> src/main.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | let reconnect_response = received_message.expect("Failed to reconnect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_reconnect_response` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `hand_response` [INFO] [stderr] --> src/main.rs:395:21 [INFO] [stderr] | [INFO] [stderr] 395 | let hand_response = received_message.expect("probably played an invalid card for faceup"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_hand_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `temp_hand` [INFO] [stderr] --> src/main.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | let temp_hand = self.hand.clone().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_temp_hand` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reconnect_response` [INFO] [stderr] --> src/main.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | let reconnect_response = received_message.expect("Failed to reconnect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_reconnect_response` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `hand_response` [INFO] [stderr] --> src/main.rs:395:21 [INFO] [stderr] | [INFO] [stderr] 395 | let hand_response = received_message.expect("probably played an invalid card for faceup"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_hand_response` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `temp_hand` [INFO] [stderr] --> src/main.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | let temp_hand = self.hand.clone().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_temp_hand` instead [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `HAND_SIZE` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const HAND_SIZE: usize = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: constant item is never used: `HAND_SIZE` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const HAND_SIZE: usize = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SUITS` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / const SUITS: [CardSuit; 4] = [ [INFO] [stderr] 28 | | CardSuit::Clubs, [INFO] [stderr] 29 | | CardSuit::Diamonds, [INFO] [stderr] 30 | | CardSuit::Hearts, [INFO] [stderr] 31 | | CardSuit::Spades, [INFO] [stderr] 32 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VALUES` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / const VALUES: [CardValue; 13] = [ [INFO] [stderr] 52 | | CardValue::Two, [INFO] [stderr] 53 | | CardValue::Three, [INFO] [stderr] 54 | | CardValue::Four, [INFO] [stderr] ... | [INFO] [stderr] 64 | | CardValue::Ace, [INFO] [stderr] 65 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ListLobbies` [INFO] [stderr] --> src/main.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | ListLobbies, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Reconnect` [INFO] [stderr] --> src/main.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | Reconnect(ReconnectMessage), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SUITS` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / const SUITS: [CardSuit; 4] = [ [INFO] [stderr] 28 | | CardSuit::Clubs, [INFO] [stderr] 29 | | CardSuit::Diamonds, [INFO] [stderr] 30 | | CardSuit::Hearts, [INFO] [stderr] 31 | | CardSuit::Spades, [INFO] [stderr] 32 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VALUES` [INFO] [stderr] --> src/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / const VALUES: [CardValue; 13] = [ [INFO] [stderr] 52 | | CardValue::Two, [INFO] [stderr] 53 | | CardValue::Three, [INFO] [stderr] 54 | | CardValue::Four, [INFO] [stderr] ... | [INFO] [stderr] 64 | | CardValue::Ace, [INFO] [stderr] 65 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ListLobbies` [INFO] [stderr] --> src/main.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | ListLobbies, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Reconnect` [INFO] [stderr] --> src/main.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | Reconnect(ReconnectMessage), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:300:21 [INFO] [stderr] | [INFO] [stderr] 300 | self.out.send(message_lobby); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:313:21 [INFO] [stderr] | [INFO] [stderr] 313 | self.out.send(json_join_lobby_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:353:43 [INFO] [stderr] | [INFO] [stderr] 353 | self.num_face_down = Some(received_message.face_down_three[self.player_index.unwrap() as usize].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `received_message.face_down_three[self.player_index.unwrap() as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:368:29 [INFO] [stderr] | [INFO] [stderr] 368 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let reconnect_response =` [INFO] [stderr] --> src/main.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | let reconnect_response = received_message.expect("Failed to reconnect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:431:12 [INFO] [stderr] | [INFO] [stderr] 431 | if (*self.hand.clone().unwrap()).len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using (*self.hand.clone().unwrap()).len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | if (*self.face_up_three.clone().unwrap()).len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using (*self.face_up_three.clone().unwrap()).len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if self.num_face_down.clone().unwrap() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.num_face_down.clone().unwrap() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:300:21 [INFO] [stderr] | [INFO] [stderr] 300 | self.out.send(message_lobby); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if self.num_face_down.clone().unwrap() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.num_face_down` [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:313:21 [INFO] [stderr] | [INFO] [stderr] 313 | self.out.send(json_join_lobby_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:448:21 [INFO] [stderr] | [INFO] [stderr] 448 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:465:17 [INFO] [stderr] | [INFO] [stderr] 465 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:353:43 [INFO] [stderr] | [INFO] [stderr] 353 | self.num_face_down = Some(received_message.face_down_three[self.player_index.unwrap() as usize].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `received_message.face_down_three[self.player_index.unwrap() as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable `NUM_PLAYERS` should have a snake case name such as `num_players` [INFO] [stderr] --> src/main.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let NUM_PLAYERS = 4; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:510:16 [INFO] [stderr] | [INFO] [stderr] 510 | }).expect(&format!("could not connect thread {} to server", i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not connect thread {} to server", i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:368:29 [INFO] [stderr] | [INFO] [stderr] 368 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let reconnect_response =` [INFO] [stderr] --> src/main.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | let reconnect_response = received_message.expect("Failed to reconnect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:431:12 [INFO] [stderr] | [INFO] [stderr] 431 | if (*self.hand.clone().unwrap()).len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using (*self.hand.clone().unwrap()).len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | if (*self.face_up_three.clone().unwrap()).len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using (*self.face_up_three.clone().unwrap()).len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if self.num_face_down.clone().unwrap() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.num_face_down.clone().unwrap() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if self.num_face_down.clone().unwrap() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.num_face_down` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:448:21 [INFO] [stderr] | [INFO] [stderr] 448 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:465:17 [INFO] [stderr] | [INFO] [stderr] 465 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | self.out.send(json_message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: Could not compile `palace-ai`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable `NUM_PLAYERS` should have a snake case name such as `num_players` [INFO] [stderr] --> src/main.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let NUM_PLAYERS = 4; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:510:16 [INFO] [stderr] | [INFO] [stderr] 510 | }).expect(&format!("could not connect thread {} to server", i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not connect thread {} to server", i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `palace-ai`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ae8a7c87fb3cd84665f56c0bd4f7ee17fe6a8d27638b9663e838330b0063b739"` [INFO] running `"docker" "rm" "-f" "ae8a7c87fb3cd84665f56c0bd4f7ee17fe6a8d27638b9663e838330b0063b739"` [INFO] [stdout] ae8a7c87fb3cd84665f56c0bd4f7ee17fe6a8d27638b9663e838330b0063b739