[INFO] updating cached repository briansteffens/blaunch2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/briansteffens/blaunch2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/briansteffens/blaunch2" "work/ex/clippy-test-run/sources/stable/gh/briansteffens/blaunch2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/briansteffens/blaunch2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/briansteffens/blaunch2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/briansteffens/blaunch2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/briansteffens/blaunch2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b9c3554ec60313fc9474cc7d42dab76de185f015 [INFO] sha for GitHub repo briansteffens/blaunch2: b9c3554ec60313fc9474cc7d42dab76de185f015 [INFO] validating manifest of briansteffens/blaunch2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of briansteffens/blaunch2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing briansteffens/blaunch2 [INFO] finished frobbing briansteffens/blaunch2 [INFO] frobbed toml for briansteffens/blaunch2 written to work/ex/clippy-test-run/sources/stable/gh/briansteffens/blaunch2/Cargo.toml [INFO] started frobbing briansteffens/blaunch2 [INFO] finished frobbing briansteffens/blaunch2 [INFO] frobbed toml for briansteffens/blaunch2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/briansteffens/blaunch2/Cargo.toml [INFO] crate briansteffens/blaunch2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting briansteffens/blaunch2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/briansteffens/blaunch2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71d04e043c946379df79cadfc2ee8044f8789cb46ce42db690ebec572f07cdde [INFO] running `"docker" "start" "-a" "71d04e043c946379df79cadfc2ee8044f8789cb46ce42db690ebec572f07cdde"` [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking glib-sys v0.3.4 [INFO] [stderr] Checking cairo-sys-rs v0.3.4 [INFO] [stderr] Checking gobject-sys v0.3.4 [INFO] [stderr] Checking gio-sys v0.3.4 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking pango-sys v0.3.4 [INFO] [stderr] Checking atk-sys v0.3.4 [INFO] [stderr] Checking cairo-rs v0.1.3 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Checking gio v0.1.3 [INFO] [stderr] Checking gdk-sys v0.3.4 [INFO] [stderr] Checking gdk-pixbuf v0.1.3 [INFO] [stderr] Checking gtk-sys v0.3.4 [INFO] [stderr] Checking gdk v0.5.3 [INFO] [stderr] Checking gtk v0.1.3 [INFO] [stderr] Checking blaunch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn borrow_nodes(nodes: &Vec) -> Vec<&Node> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if remaining.len() == 0 && n.children == None { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if remaining.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:166:34 [INFO] [stderr] | [INFO] [stderr] 166 | let value = c.get_text().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | let value = c.get_text().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn borrow_nodes(nodes: &Vec) -> Vec<&Node> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | if remaining.len() == 0 && n.children == None { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if remaining.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:166:34 [INFO] [stderr] | [INFO] [stderr] 166 | let value = c.get_text().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | let value = c.get_text().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:265:12 [INFO] [stderr] | [INFO] [stderr] 265 | if expected.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.56s [INFO] running `"docker" "inspect" "71d04e043c946379df79cadfc2ee8044f8789cb46ce42db690ebec572f07cdde"` [INFO] running `"docker" "rm" "-f" "71d04e043c946379df79cadfc2ee8044f8789cb46ce42db690ebec572f07cdde"` [INFO] [stdout] 71d04e043c946379df79cadfc2ee8044f8789cb46ce42db690ebec572f07cdde