[INFO] updating cached repository brettcannon/python-launcher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brettcannon/python-launcher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brettcannon/python-launcher" "work/ex/clippy-test-run/sources/stable/gh/brettcannon/python-launcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brettcannon/python-launcher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brettcannon/python-launcher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/python-launcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/python-launcher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 974fe8e11b39f7aeb4f9b80970bca21d3a8cb6af [INFO] sha for GitHub repo brettcannon/python-launcher: 974fe8e11b39f7aeb4f9b80970bca21d3a8cb6af [INFO] validating manifest of brettcannon/python-launcher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brettcannon/python-launcher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brettcannon/python-launcher [INFO] finished frobbing brettcannon/python-launcher [INFO] frobbed toml for brettcannon/python-launcher written to work/ex/clippy-test-run/sources/stable/gh/brettcannon/python-launcher/Cargo.toml [INFO] started frobbing brettcannon/python-launcher [INFO] finished frobbing brettcannon/python-launcher [INFO] frobbed toml for brettcannon/python-launcher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brettcannon/python-launcher/Cargo.toml [INFO] crate brettcannon/python-launcher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brettcannon/python-launcher against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brettcannon/python-launcher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8c31e24e692a5f7e7bb0ec1c73131e3d24f73dd0aa33735e906de3f5ce80d6c [INFO] running `"docker" "start" "-a" "f8c31e24e692a5f7e7bb0ec1c73131e3d24f73dd0aa33735e906de3f5ce80d6c"` [INFO] [stderr] Checking python-launcher v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:335:26 [INFO] [stderr] | [INFO] [stderr] 335 | .map(|p| path::PathBuf::from(p)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `path::PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:497:33 [INFO] [stderr] | [INFO] [stderr] 497 | assert_eq!(find_shebang("print('Hello!')".as_bytes()), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"print('Hello!')"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:507:26 [INFO] [stderr] | [INFO] [stderr] 507 | find_shebang("#! /usr/bin/env python -S".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#! /usr/bin/env python -S"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:519:26 [INFO] [stderr] | [INFO] [stderr] 519 | find_shebang("#! /usr/bin/python".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#! /usr/bin/python"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "f8c31e24e692a5f7e7bb0ec1c73131e3d24f73dd0aa33735e906de3f5ce80d6c"` [INFO] running `"docker" "rm" "-f" "f8c31e24e692a5f7e7bb0ec1c73131e3d24f73dd0aa33735e906de3f5ce80d6c"` [INFO] [stdout] f8c31e24e692a5f7e7bb0ec1c73131e3d24f73dd0aa33735e906de3f5ce80d6c