[INFO] updating cached repository brentongunning/parallel_ttor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brentongunning/parallel_ttor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brentongunning/parallel_ttor" "work/ex/clippy-test-run/sources/stable/gh/brentongunning/parallel_ttor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brentongunning/parallel_ttor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brentongunning/parallel_ttor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brentongunning/parallel_ttor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brentongunning/parallel_ttor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8c54ac82727f14bed7cda51f8ea2df02e98da5f [INFO] sha for GitHub repo brentongunning/parallel_ttor: b8c54ac82727f14bed7cda51f8ea2df02e98da5f [INFO] validating manifest of brentongunning/parallel_ttor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brentongunning/parallel_ttor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brentongunning/parallel_ttor [INFO] finished frobbing brentongunning/parallel_ttor [INFO] frobbed toml for brentongunning/parallel_ttor written to work/ex/clippy-test-run/sources/stable/gh/brentongunning/parallel_ttor/Cargo.toml [INFO] started frobbing brentongunning/parallel_ttor [INFO] finished frobbing brentongunning/parallel_ttor [INFO] frobbed toml for brentongunning/parallel_ttor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brentongunning/parallel_ttor/Cargo.toml [INFO] crate brentongunning/parallel_ttor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brentongunning/parallel_ttor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brentongunning/parallel_ttor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22768fd194d5f9401bb444ec31590776fc411331a391e842fb49321a3ba423de [INFO] running `"docker" "start" "-a" "22768fd194d5f9401bb444ec31590776fc411331a391e842fb49321a3ba423de"` [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking parallel_ttor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | if tx_input != &[0; 32] { [INFO] [stderr] | ^^^^^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:145:26 [INFO] [stderr] | [INFO] [stderr] 145 | for i in (0..tid + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=tid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | if tx_input != &[0; 32] { [INFO] [stderr] | ^^^^^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:145:26 [INFO] [stderr] | [INFO] [stderr] 145 | for i in (0..tid + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=tid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.08s [INFO] running `"docker" "inspect" "22768fd194d5f9401bb444ec31590776fc411331a391e842fb49321a3ba423de"` [INFO] running `"docker" "rm" "-f" "22768fd194d5f9401bb444ec31590776fc411331a391e842fb49321a3ba423de"` [INFO] [stdout] 22768fd194d5f9401bb444ec31590776fc411331a391e842fb49321a3ba423de