[INFO] updating cached repository brennie/metabrowser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brennie/metabrowser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brennie/metabrowser" "work/ex/clippy-test-run/sources/stable/gh/brennie/metabrowser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brennie/metabrowser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brennie/metabrowser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brennie/metabrowser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brennie/metabrowser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6e64ef0e8fb214a76a8814f6c538455345f3b88 [INFO] sha for GitHub repo brennie/metabrowser: f6e64ef0e8fb214a76a8814f6c538455345f3b88 [INFO] validating manifest of brennie/metabrowser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brennie/metabrowser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brennie/metabrowser [INFO] finished frobbing brennie/metabrowser [INFO] frobbed toml for brennie/metabrowser written to work/ex/clippy-test-run/sources/stable/gh/brennie/metabrowser/Cargo.toml [INFO] started frobbing brennie/metabrowser [INFO] finished frobbing brennie/metabrowser [INFO] frobbed toml for brennie/metabrowser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brennie/metabrowser/Cargo.toml [INFO] crate brennie/metabrowser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brennie/metabrowser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brennie/metabrowser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a4e6ec690f92855909a2d99e5e059fa31ccd9c69111e45f82a1ee5d81b30c87 [INFO] running `"docker" "start" "-a" "6a4e6ec690f92855909a2d99e5e059fa31ccd9c69111e45f82a1ee5d81b30c87"` [INFO] [stderr] Checking dtoa v0.3.1 [INFO] [stderr] Checking backtrace-sys v0.1.5 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking serde_yaml v0.5.1 [INFO] [stderr] Checking metabrowser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | let result = home_dir() [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | let result = home_dir() [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/config.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | fn urls_to_regex(urls: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .ok_or(Error::from(ErrorKind::NoHomeError)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoHomeError))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/config.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | fn urls_to_regex(urls: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .ok_or(Error::from(ErrorKind::NoHomeError)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoHomeError))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.39s [INFO] running `"docker" "inspect" "6a4e6ec690f92855909a2d99e5e059fa31ccd9c69111e45f82a1ee5d81b30c87"` [INFO] running `"docker" "rm" "-f" "6a4e6ec690f92855909a2d99e5e059fa31ccd9c69111e45f82a1ee5d81b30c87"` [INFO] [stdout] 6a4e6ec690f92855909a2d99e5e059fa31ccd9c69111e45f82a1ee5d81b30c87