[INFO] updating cached repository breander/Rust_Advent_Code_2017_Day_02 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/breander/Rust_Advent_Code_2017_Day_02 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/breander/Rust_Advent_Code_2017_Day_02" "work/ex/clippy-test-run/sources/stable/gh/breander/Rust_Advent_Code_2017_Day_02"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/breander/Rust_Advent_Code_2017_Day_02'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/breander/Rust_Advent_Code_2017_Day_02" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/breander/Rust_Advent_Code_2017_Day_02"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/breander/Rust_Advent_Code_2017_Day_02'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b9d257f3c6f7c961d4955c9d597b01deb6f3f36a [INFO] sha for GitHub repo breander/Rust_Advent_Code_2017_Day_02: b9d257f3c6f7c961d4955c9d597b01deb6f3f36a [INFO] validating manifest of breander/Rust_Advent_Code_2017_Day_02 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of breander/Rust_Advent_Code_2017_Day_02 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing breander/Rust_Advent_Code_2017_Day_02 [INFO] finished frobbing breander/Rust_Advent_Code_2017_Day_02 [INFO] frobbed toml for breander/Rust_Advent_Code_2017_Day_02 written to work/ex/clippy-test-run/sources/stable/gh/breander/Rust_Advent_Code_2017_Day_02/Cargo.toml [INFO] started frobbing breander/Rust_Advent_Code_2017_Day_02 [INFO] finished frobbing breander/Rust_Advent_Code_2017_Day_02 [INFO] frobbed toml for breander/Rust_Advent_Code_2017_Day_02 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/breander/Rust_Advent_Code_2017_Day_02/Cargo.toml [INFO] crate breander/Rust_Advent_Code_2017_Day_02 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting breander/Rust_Advent_Code_2017_Day_02 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/breander/Rust_Advent_Code_2017_Day_02:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9682da650e401009823b86643a5f403331d643bec09e14768b805730102c4932 [INFO] running `"docker" "start" "-a" "9682da650e401009823b86643a5f403331d643bec09e14768b805730102c4932"` [INFO] [stderr] Checking day2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | / if current > current2 { [INFO] [stderr] 58 | | if current % current2 == 0 { [INFO] [stderr] 59 | | sum += current / current2; [INFO] [stderr] 60 | | found = true; [INFO] [stderr] 61 | | break; [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | if current > current2 && current % current2 == 0 { [INFO] [stderr] 58 | sum += current / current2; [INFO] [stderr] 59 | found = true; [INFO] [stderr] 60 | break; [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:10:42 [INFO] [stderr] | [INFO] [stderr] 10 | let rows: Vec<&str> = contents.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | fn part1(rows: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | let numbers: Vec<&str> = row.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | fn part2(rows: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | / if current > current2 { [INFO] [stderr] 58 | | if current % current2 == 0 { [INFO] [stderr] 59 | | sum += current / current2; [INFO] [stderr] 60 | | found = true; [INFO] [stderr] 61 | | break; [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | if current > current2 && current % current2 == 0 { [INFO] [stderr] 58 | sum += current / current2; [INFO] [stderr] 59 | found = true; [INFO] [stderr] 60 | break; [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | let numbers: Vec<&str> = row.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `numbers` [INFO] [stderr] --> src/main.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | for y in 0..numbers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (y, ) in numbers.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:10:42 [INFO] [stderr] | [INFO] [stderr] 10 | let rows: Vec<&str> = contents.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | fn part1(rows: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | let numbers: Vec<&str> = row.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | fn part2(rows: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | let numbers: Vec<&str> = row.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `numbers` [INFO] [stderr] --> src/main.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | for y in 0..numbers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (y, ) in numbers.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "9682da650e401009823b86643a5f403331d643bec09e14768b805730102c4932"` [INFO] running `"docker" "rm" "-f" "9682da650e401009823b86643a5f403331d643bec09e14768b805730102c4932"` [INFO] [stdout] 9682da650e401009823b86643a5f403331d643bec09e14768b805730102c4932