[INFO] updating cached repository brandonio21/wallers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brandonio21/wallers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brandonio21/wallers" "work/ex/clippy-test-run/sources/stable/gh/brandonio21/wallers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brandonio21/wallers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brandonio21/wallers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandonio21/wallers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandonio21/wallers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 271dcf877918ba155cc5ee252bd103e0d25b7a88 [INFO] sha for GitHub repo brandonio21/wallers: 271dcf877918ba155cc5ee252bd103e0d25b7a88 [INFO] validating manifest of brandonio21/wallers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brandonio21/wallers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brandonio21/wallers [INFO] finished frobbing brandonio21/wallers [INFO] frobbed toml for brandonio21/wallers written to work/ex/clippy-test-run/sources/stable/gh/brandonio21/wallers/Cargo.toml [INFO] started frobbing brandonio21/wallers [INFO] finished frobbing brandonio21/wallers [INFO] frobbed toml for brandonio21/wallers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandonio21/wallers/Cargo.toml [INFO] crate brandonio21/wallers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brandonio21/wallers against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brandonio21/wallers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41f5dab3904cd39326db41a985c4c517872f89866c75c5b3f524aeb9af73f8bb [INFO] running `"docker" "start" "-a" "41f5dab3904cd39326db41a985c4c517872f89866c75c5b3f524aeb9af73f8bb"` [INFO] [stderr] Compiling curl-sys v0.3.13 [INFO] [stderr] Checking generic-array v0.6.0 [INFO] [stderr] Checking digest v0.4.0 [INFO] [stderr] Checking digest-buffer v0.2.0 [INFO] [stderr] Checking sha2 v0.4.2 [INFO] [stderr] Checking easy-hash v0.1.0 [INFO] [stderr] Checking curl v0.4.7 [INFO] [stderr] Checking wallers v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | let home_dir = std::env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | let home_dir = std::env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | / match ext_os_str.to_str() { [INFO] [stderr] 50 | | Some("download") => { [INFO] [stderr] 51 | | remove_file(entry.path().as_path())?; [INFO] [stderr] 52 | | continue; [INFO] [stderr] 53 | | }, [INFO] [stderr] 54 | | _ => {} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some("download") = ext_os_str.to_str() { [INFO] [stderr] 50 | remove_file(entry.path().as_path())?; [INFO] [stderr] 51 | continue; [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(_) = create_dir_all(dir.as_path()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 81 | | return None; [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________________- help: try this: `if create_dir_all(dir.as_path()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | if let Err(_) = create_dir_all(dir.as_path()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 89 | | return None; [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________- help: try this: `if create_dir_all(dir.as_path()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | / match dir.as_path().exists() { [INFO] [stderr] 94 | | false => None, [INFO] [stderr] 95 | | true => Some(dir) [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if dir.as_path().exists() { Some(dir) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match result { [INFO] [stderr] 164 | | true => Ok(()), [INFO] [stderr] 165 | | false => Err(Error::new(ErrorKind::Other, "Failed to set non-Windows wallpaper")) [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if result { Ok(()) } else { Err(Error::new(ErrorKind::Other, "Failed to set non-Windows wallpaper")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | / match ext_os_str.to_str() { [INFO] [stderr] 50 | | Some("download") => { [INFO] [stderr] 51 | | remove_file(entry.path().as_path())?; [INFO] [stderr] 52 | | continue; [INFO] [stderr] 53 | | }, [INFO] [stderr] 54 | | _ => {} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Some("download") = ext_os_str.to_str() { [INFO] [stderr] 50 | remove_file(entry.path().as_path())?; [INFO] [stderr] 51 | continue; [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(_) = create_dir_all(dir.as_path()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 81 | | return None; [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________________- help: try this: `if create_dir_all(dir.as_path()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | if let Err(_) = create_dir_all(dir.as_path()) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 89 | | return None; [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________- help: try this: `if create_dir_all(dir.as_path()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | / match dir.as_path().exists() { [INFO] [stderr] 94 | | false => None, [INFO] [stderr] 95 | | true => Some(dir) [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if dir.as_path().exists() { Some(dir) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match result { [INFO] [stderr] 164 | | true => Ok(()), [INFO] [stderr] 165 | | false => Err(Error::new(ErrorKind::Other, "Failed to set non-Windows wallpaper")) [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if result { Ok(()) } else { Err(Error::new(ErrorKind::Other, "Failed to set non-Windows wallpaper")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 14s [INFO] running `"docker" "inspect" "41f5dab3904cd39326db41a985c4c517872f89866c75c5b3f524aeb9af73f8bb"` [INFO] running `"docker" "rm" "-f" "41f5dab3904cd39326db41a985c4c517872f89866c75c5b3f524aeb9af73f8bb"` [INFO] [stdout] 41f5dab3904cd39326db41a985c4c517872f89866c75c5b3f524aeb9af73f8bb