[INFO] updating cached repository brandon515/rusty_irc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brandon515/rusty_irc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brandon515/rusty_irc" "work/ex/clippy-test-run/sources/stable/gh/brandon515/rusty_irc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brandon515/rusty_irc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brandon515/rusty_irc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandon515/rusty_irc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandon515/rusty_irc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 882eb357a4bdcac2e66fda73200e3705898b5152 [INFO] sha for GitHub repo brandon515/rusty_irc: 882eb357a4bdcac2e66fda73200e3705898b5152 [INFO] validating manifest of brandon515/rusty_irc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brandon515/rusty_irc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brandon515/rusty_irc [INFO] finished frobbing brandon515/rusty_irc [INFO] frobbed toml for brandon515/rusty_irc written to work/ex/clippy-test-run/sources/stable/gh/brandon515/rusty_irc/Cargo.toml [INFO] started frobbing brandon515/rusty_irc [INFO] finished frobbing brandon515/rusty_irc [INFO] frobbed toml for brandon515/rusty_irc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brandon515/rusty_irc/Cargo.toml [INFO] crate brandon515/rusty_irc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting brandon515/rusty_irc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brandon515/rusty_irc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b86decfeadb8ad7b0648607312dfe41cf62609b112624b1209f054403876fdaf [INFO] running `"docker" "start" "-a" "b86decfeadb8ad7b0648607312dfe41cf62609b112624b1209f054403876fdaf"` [INFO] [stderr] Checking libc v0.2.14 [INFO] [stderr] Checking rust-ini v0.9.8 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking rusty_irc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/user.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc/user.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/network_interface/handler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/network_interface/handler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/irc/command.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/irc/command.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chan` [INFO] [stderr] --> src/irc/command.rs:8:47 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^ help: consider using `_chan` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user` [INFO] [stderr] --> src/network_interface/handler.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | let user = x.remove(place); [INFO] [stderr] | ^^^^ help: consider using `_user` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chan_name` [INFO] [stderr] --> src/network_interface/handler.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | 'search: for (chan_name, user_list) in self.channels.iter_mut(){ [INFO] [stderr] | ^^^^^^^^^ help: consider using `_chan_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg_stream` [INFO] [stderr] --> src/network_interface/handler.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let msg_stream = event_loop.channel(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_msg_stream` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `in_str` [INFO] [stderr] --> src/network_interface/handler.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | let in_str = match String::from_utf8(input_bytes){ [INFO] [stderr] | ^^^^^^ help: consider using `_in_str` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/network_interface/handler.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let mut cli = match self.client_list.get_mut(&reciever){ [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | return Some(tok.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*tok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:69:112 [INFO] [stderr] | [INFO] [stderr] 69 | return Err(format!("Tried to send data to client with Token {:?} but the client doesnt exist", reciever.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reciever` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/network_interface/handler.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let ent_chan = self.channels.entry(chan).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:183:65 [INFO] [stderr] | [INFO] [stderr] 183 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network_interface/handler.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:207:61 [INFO] [stderr] | [INFO] [stderr] 207 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:215:114 [INFO] [stderr] | [INFO] [stderr] 215 | logging::log(logging::Level::DEBUG, &(format!("Message: {}\nReciever: {}", what.clone(), who.clone()))); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:218:61 [INFO] [stderr] | [INFO] [stderr] 218 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/irc/command.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/irc/command.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chan` [INFO] [stderr] --> src/irc/command.rs:8:47 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn handle(message: Message, sender: User, chan: Sender){ [INFO] [stderr] | ^^^^ help: consider using `_chan` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user` [INFO] [stderr] --> src/network_interface/handler.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | let user = x.remove(place); [INFO] [stderr] | ^^^^ help: consider using `_user` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chan_name` [INFO] [stderr] --> src/network_interface/handler.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | 'search: for (chan_name, user_list) in self.channels.iter_mut(){ [INFO] [stderr] | ^^^^^^^^^ help: consider using `_chan_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg_stream` [INFO] [stderr] --> src/network_interface/handler.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let msg_stream = event_loop.channel(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_msg_stream` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `in_str` [INFO] [stderr] --> src/network_interface/handler.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | let in_str = match String::from_utf8(input_bytes){ [INFO] [stderr] | ^^^^^^ help: consider using `_in_str` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/network_interface/handler.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | self.token_counter = self.token_counter+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.token_counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:263:47 [INFO] [stderr] | [INFO] [stderr] 263 | match self.client_list.insert(new_token.clone(), user::Client::new(sock, ip.to_string())){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network_interface/handler.rs:284:44 [INFO] [stderr] | [INFO] [stderr] 284 | match event_loop.register(&self.client_list.get(&new_token).unwrap().socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.client_list[&new_token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/network_interface/handler.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | let ref mut stream = self.client_list.get_mut(&client_token).unwrap().socket; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let stream = &mut self.client_list.get_mut(&client_token).unwrap().socket;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/network_interface/handler.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let mut cli = match self.client_list.get_mut(&reciever){ [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/irc/message.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str((&s).clone()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str(&(*(&s)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str(&std::string::String::clone((&s))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_irc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | return Some(tok.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*tok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:69:112 [INFO] [stderr] | [INFO] [stderr] 69 | return Err(format!("Tried to send data to client with Token {:?} but the client doesnt exist", reciever.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reciever` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/network_interface/handler.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let ent_chan = self.channels.entry(chan).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:183:65 [INFO] [stderr] | [INFO] [stderr] 183 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/network_interface/handler.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | msg_stream.send(irc::message::ServerMessage::USERTOKENMSG(user_token.as_usize(), what.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:207:61 [INFO] [stderr] | [INFO] [stderr] 207 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:215:114 [INFO] [stderr] | [INFO] [stderr] 215 | logging::log(logging::Level::DEBUG, &(format!("Message: {}\nReciever: {}", what.clone(), who.clone()))); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `who` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/network_interface/handler.rs:218:61 [INFO] [stderr] | [INFO] [stderr] 218 | logging::log(logging::Level::ERR, &(format!("{}", x))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/network_interface/handler.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | self.token_counter = self.token_counter+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.token_counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network_interface/handler.rs:263:47 [INFO] [stderr] | [INFO] [stderr] 263 | match self.client_list.insert(new_token.clone(), user::Client::new(sock, ip.to_string())){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/network_interface/handler.rs:284:44 [INFO] [stderr] | [INFO] [stderr] 284 | match event_loop.register(&self.client_list.get(&new_token).unwrap().socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.client_list[&new_token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/network_interface/handler.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | let ref mut stream = self.client_list.get_mut(&client_token).unwrap().socket; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------------------------------------- help: try: `let stream = &mut self.client_list.get_mut(&client_token).unwrap().socket;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/irc/message.rs:119:33 [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str((&s).clone()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str(&(*(&s)).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 119 | acc_string.push_str(&std::string::String::clone((&s))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_irc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b86decfeadb8ad7b0648607312dfe41cf62609b112624b1209f054403876fdaf"` [INFO] running `"docker" "rm" "-f" "b86decfeadb8ad7b0648607312dfe41cf62609b112624b1209f054403876fdaf"` [INFO] [stdout] b86decfeadb8ad7b0648607312dfe41cf62609b112624b1209f054403876fdaf