[INFO] updating cached repository brain-lang/brain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brain-lang/brain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brain-lang/brain" "work/ex/clippy-test-run/sources/stable/gh/brain-lang/brain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brain-lang/brain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brain-lang/brain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brain-lang/brain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brain-lang/brain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 234eccd8f5a71818704fe79d32c5c3eb73bce5d4 [INFO] sha for GitHub repo brain-lang/brain: 234eccd8f5a71818704fe79d32c5c3eb73bce5d4 [INFO] validating manifest of brain-lang/brain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brain-lang/brain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brain-lang/brain [INFO] finished frobbing brain-lang/brain [INFO] frobbed toml for brain-lang/brain written to work/ex/clippy-test-run/sources/stable/gh/brain-lang/brain/Cargo.toml [INFO] started frobbing brain-lang/brain [INFO] finished frobbing brain-lang/brain [INFO] frobbed toml for brain-lang/brain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brain-lang/brain/Cargo.toml [INFO] crate brain-lang/brain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brain-lang/brain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brain-lang/brain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c756c90b2a9586fb8d1b72f3d05a4d9480315e35a9d472644f29381c02a01e5a [INFO] running `"docker" "start" "-a" "c756c90b2a9586fb8d1b72f3d05a4d9480315e35a9d472644f29381c02a01e5a"` [INFO] [stderr] Checking brain v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/declaration.rs:60:46 [INFO] [stderr] | [INFO] [stderr] 60 | Err(Error::UnsupportedArrayType {name: name}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/expression/call.rs:63:60 [INFO] [stderr] | [INFO] [stderr] 63 | ScopeItem::Array {item, ..} => FuncArgType::Array {item: item, size: None}, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/static_allocator.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/scope.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/declaration.rs:60:46 [INFO] [stderr] | [INFO] [stderr] 60 | Err(Error::UnsupportedArrayType {name: name}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/expression/call.rs:63:60 [INFO] [stderr] | [INFO] [stderr] 63 | ScopeItem::Array {item, ..} => FuncArgType::Array {item: item, size: None}, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/static_allocator.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parser/grammar.rs:548:32 [INFO] [stderr] | [INFO] [stderr] 548 | Expression::Number(1_000_000_) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parser/grammar.rs:552:32 [INFO] [stderr] | [INFO] [stderr] 552 | Expression::Number(1____0_0__0______000____) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/operations/scope.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | type_id [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/operations/scope.rs:231:23 [INFO] [stderr] | [INFO] [stderr] 231 | let type_id = self.insert_type(name, typ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/operations/scope.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | type_id [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/operations/scope.rs:231:23 [INFO] [stderr] | [INFO] [stderr] 231 | let type_id = self.insert_type(name, typ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:513:17 [INFO] [stderr] | [INFO] [stderr] 513 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:513:17 [INFO] [stderr] | [INFO] [stderr] 513 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/core/primitives/boolean.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | /// Thanks to certain properties of booleans, we can evaluate certain things during [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::scope::Scope` [INFO] [stderr] --> src/operations/scope.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn new() -> Scope { [INFO] [stderr] 118 | | Scope { [INFO] [stderr] 119 | | types: HashMap::new(), [INFO] [stderr] 120 | | items: HashMap::new(), [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `operations::scope::ScopeStack` [INFO] [stderr] --> src/operations/scope.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> ScopeStack { [INFO] [stderr] 145 | | ScopeStack { [INFO] [stderr] 146 | | stack: { [INFO] [stderr] 147 | | let mut queue = VecDeque::new(); [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | impl Default for operations::scope::ScopeStack { [INFO] [stderr] 144 | fn default() -> Self { [INFO] [stderr] 145 | Self::new() [INFO] [stderr] 146 | } [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operations/item_type.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn matches_signature(&self, expected_args: &Vec, expected_return_type: TypeId) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[FuncArgType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/operations/item_type.rs:137:45 [INFO] [stderr] | [INFO] [stderr] 137 | while let Some(_) = expected_args.next() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in expected_args { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/operations/declaration.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let name = match pattern { [INFO] [stderr] 15 | | Pattern::Identifier(name) => name, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |______^ help: try this: `let Pattern::Identifier(name) = pattern;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::primitives::Primitives` [INFO] [stderr] --> src/operations/primitives.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Primitives { [INFO] [stderr] 22 | | $name { [INFO] [stderr] 23 | | $($field_name: None,)* [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 66 | / impl_primitives! { [INFO] [stderr] 67 | | pub struct Primitives { [INFO] [stderr] 68 | | unit: Option, [INFO] [stderr] 69 | | array: Option, [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] 17 | pub struct $name { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::static_allocator::StaticAllocator` [INFO] [stderr] --> src/memory/static_allocator.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> StaticAllocator { [INFO] [stderr] 94 | | StaticAllocator { [INFO] [stderr] 95 | | next_id: 1, [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::layout::MemoryLayout` [INFO] [stderr] --> src/memory/layout.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> MemoryLayout { [INFO] [stderr] 43 | | MemoryLayout { [INFO] [stderr] 44 | | table: HashMap::new(), [INFO] [stderr] 45 | | size: 0, [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory/layout.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.table.get(&mem.id()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[&mem.id()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/memory/layout.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / if self.table.contains_key(&key) { [INFO] [stderr] 110 | | // Invariant: the previously stored size should [INFO] [stderr] 111 | | // be the same as the current one [INFO] [stderr] 112 | | debug_assert!(self.table.get(&key).unwrap().size() == mem.size()); [INFO] [stderr] ... | [INFO] [stderr] 118 | | self.table.insert(key, Cells {position, size}); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory/layout.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | debug_assert!(self.table.get(&key).unwrap().size() == mem.size()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | / match x || y { [INFO] [stderr] 205 | | false => Vec::new(), [INFO] [stderr] 206 | | true => vec![Operation::Increment { [INFO] [stderr] 207 | | target: target.position(), [INFO] [stderr] 208 | | amount: 1, [INFO] [stderr] 209 | | }], [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 204 | if x || y { vec![Operation::Increment { [INFO] [stderr] 205 | target: target.position(), [INFO] [stderr] 206 | amount: 1, [INFO] [stderr] 207 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | / match x && y { [INFO] [stderr] 352 | | false => Vec::new(), [INFO] [stderr] 353 | | true => vec![Operation::Increment { [INFO] [stderr] 354 | | target: target.position(), [INFO] [stderr] 355 | | amount: 1, [INFO] [stderr] 356 | | }], [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 351 | if x && y { vec![Operation::Increment { [INFO] [stderr] 352 | target: target.position(), [INFO] [stderr] 353 | amount: 1, [INFO] [stderr] 354 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:505:21 [INFO] [stderr] | [INFO] [stderr] 505 | / match x == y { [INFO] [stderr] 506 | | false => Vec::new(), [INFO] [stderr] 507 | | true => vec![Operation::Increment { [INFO] [stderr] 508 | | target: target.position(), [INFO] [stderr] 509 | | amount: 1, [INFO] [stderr] 510 | | }], [INFO] [stderr] 511 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 505 | if x == y { vec![Operation::Increment { [INFO] [stderr] 506 | target: target.position(), [INFO] [stderr] 507 | amount: 1, [INFO] [stderr] 508 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | / match x != y { [INFO] [stderr] 634 | | false => Vec::new(), [INFO] [stderr] 635 | | true => vec![Operation::Increment { [INFO] [stderr] 636 | | target: target.position(), [INFO] [stderr] 637 | | amount: 1, [INFO] [stderr] 638 | | }], [INFO] [stderr] 639 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 633 | if x != y { vec![Operation::Increment { [INFO] [stderr] 634 | target: target.position(), [INFO] [stderr] 635 | amount: 1, [INFO] [stderr] 636 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `codegen::instruction::Instructions` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/codegen/instruction.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl Instructions { [INFO] [stderr] 12 | | pub fn len(&self) -> usize { [INFO] [stderr] 13 | | self.0.len() [INFO] [stderr] 14 | | } [INFO] [stderr] ... | [INFO] [stderr] 39 | | [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl_rdp! { [INFO] [stderr] 9 | | grammar! { [INFO] [stderr] 10 | | module = _{ soi ~ statement* ~ eoi } [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 392 | | } [INFO] [stderr] 393 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::scope::Scope` [INFO] [stderr] --> src/operations/scope.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / pub fn new() -> Scope { [INFO] [stderr] 118 | | Scope { [INFO] [stderr] 119 | | types: HashMap::new(), [INFO] [stderr] 120 | | items: HashMap::new(), [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `operations::scope::ScopeStack` [INFO] [stderr] --> src/operations/scope.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> ScopeStack { [INFO] [stderr] 145 | | ScopeStack { [INFO] [stderr] 146 | | stack: { [INFO] [stderr] 147 | | let mut queue = VecDeque::new(); [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | impl Default for operations::scope::ScopeStack { [INFO] [stderr] 144 | fn default() -> Self { [INFO] [stderr] 145 | Self::new() [INFO] [stderr] 146 | } [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operations/item_type.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn matches_signature(&self, expected_args: &Vec, expected_return_type: TypeId) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[FuncArgType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/operations/item_type.rs:137:45 [INFO] [stderr] | [INFO] [stderr] 137 | while let Some(_) = expected_args.next() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in expected_args { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/operations/item_type.rs:292:24 [INFO] [stderr] | [INFO] [stderr] 292 | expected_args: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[FuncArgType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/operations/declaration.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let name = match pattern { [INFO] [stderr] 15 | | Pattern::Identifier(name) => name, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |______^ help: try this: `let Pattern::Identifier(name) = pattern;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::primitives::Primitives` [INFO] [stderr] --> src/operations/primitives.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Primitives { [INFO] [stderr] 22 | | $name { [INFO] [stderr] 23 | | $($field_name: None,)* [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 66 | / impl_primitives! { [INFO] [stderr] 67 | | pub struct Primitives { [INFO] [stderr] 68 | | unit: Option, [INFO] [stderr] 69 | | array: Option, [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] 17 | pub struct $name { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::static_allocator::StaticAllocator` [INFO] [stderr] --> src/memory/static_allocator.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> StaticAllocator { [INFO] [stderr] 94 | | StaticAllocator { [INFO] [stderr] 95 | | next_id: 1, [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::layout::MemoryLayout` [INFO] [stderr] --> src/memory/layout.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> MemoryLayout { [INFO] [stderr] 43 | | MemoryLayout { [INFO] [stderr] 44 | | table: HashMap::new(), [INFO] [stderr] 45 | | size: 0, [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory/layout.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.table.get(&mem.id()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[&mem.id()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/memory/layout.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / if self.table.contains_key(&key) { [INFO] [stderr] 110 | | // Invariant: the previously stored size should [INFO] [stderr] 111 | | // be the same as the current one [INFO] [stderr] 112 | | debug_assert!(self.table.get(&key).unwrap().size() == mem.size()); [INFO] [stderr] ... | [INFO] [stderr] 118 | | self.table.insert(key, Cells {position, size}); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/memory/layout.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | debug_assert!(self.table.get(&key).unwrap().size() == mem.size()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/core/primitives/array.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / let array_type_id = match **scope.lookup_type(&Identifier::from("[T; N]")).first().unwrap() { [INFO] [stderr] 32 | | ScopeType::Type(id) => id, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |__________^ help: try this: `let ScopeType::Type(array_type_id) = **scope.lookup_type(&Identifier::from("[T; N]")).first().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | / match x || y { [INFO] [stderr] 205 | | false => Vec::new(), [INFO] [stderr] 206 | | true => vec![Operation::Increment { [INFO] [stderr] 207 | | target: target.position(), [INFO] [stderr] 208 | | amount: 1, [INFO] [stderr] 209 | | }], [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 204 | if x || y { vec![Operation::Increment { [INFO] [stderr] 205 | target: target.position(), [INFO] [stderr] 206 | amount: 1, [INFO] [stderr] 207 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | / match x && y { [INFO] [stderr] 352 | | false => Vec::new(), [INFO] [stderr] 353 | | true => vec![Operation::Increment { [INFO] [stderr] 354 | | target: target.position(), [INFO] [stderr] 355 | | amount: 1, [INFO] [stderr] 356 | | }], [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 351 | if x && y { vec![Operation::Increment { [INFO] [stderr] 352 | target: target.position(), [INFO] [stderr] 353 | amount: 1, [INFO] [stderr] 354 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:505:21 [INFO] [stderr] | [INFO] [stderr] 505 | / match x == y { [INFO] [stderr] 506 | | false => Vec::new(), [INFO] [stderr] 507 | | true => vec![Operation::Increment { [INFO] [stderr] 508 | | target: target.position(), [INFO] [stderr] 509 | | amount: 1, [INFO] [stderr] 510 | | }], [INFO] [stderr] 511 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 505 | if x == y { vec![Operation::Increment { [INFO] [stderr] 506 | target: target.position(), [INFO] [stderr] 507 | amount: 1, [INFO] [stderr] 508 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/primitives/boolean.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | / match x != y { [INFO] [stderr] 634 | | false => Vec::new(), [INFO] [stderr] 635 | | true => vec![Operation::Increment { [INFO] [stderr] 636 | | target: target.position(), [INFO] [stderr] 637 | | amount: 1, [INFO] [stderr] 638 | | }], [INFO] [stderr] 639 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 633 | if x != y { vec![Operation::Increment { [INFO] [stderr] 634 | target: target.position(), [INFO] [stderr] 635 | amount: 1, [INFO] [stderr] 636 | }] } else { Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/core/primitives/boolean.rs:723:9 [INFO] [stderr] | [INFO] [stderr] 723 | / let bool_type_id = match **scope.lookup_type(&Identifier::from("bool")).first().unwrap() { [INFO] [stderr] 724 | | ScopeType::Type(id) => id, [INFO] [stderr] 725 | | }; [INFO] [stderr] | |__________^ help: try this: `let ScopeType::Type(bool_type_id) = **scope.lookup_type(&Identifier::from("bool")).first().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/core/primitives/boolean.rs:734:9 [INFO] [stderr] | [INFO] [stderr] 734 | / let bool_type_id = match **scope.lookup_type(&Identifier::from("bool")).first().unwrap() { [INFO] [stderr] 735 | | ScopeType::Type(id) => id, [INFO] [stderr] 736 | | }; [INFO] [stderr] | |__________^ help: try this: `let ScopeType::Type(bool_type_id) = **scope.lookup_type(&Identifier::from("bool")).first().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> src/core/primitives/u8.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / let u8_type_id = match **scope.lookup_type(&Identifier::from("u8")).first().unwrap() { [INFO] [stderr] 344 | | ScopeType::Type(id) => id, [INFO] [stderr] 345 | | }; [INFO] [stderr] | |__________^ help: try this: `let ScopeType::Type(u8_type_id) = **scope.lookup_type(&Identifier::from("u8")).first().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] warning: item `codegen::instruction::Instructions` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/codegen/instruction.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl Instructions { [INFO] [stderr] 12 | | pub fn len(&self) -> usize { [INFO] [stderr] 13 | | self.0.len() [INFO] [stderr] 14 | | } [INFO] [stderr] ... | [INFO] [stderr] 39 | | [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/brain.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | }, |s| PathBuf::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/brain.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | output_file.write(&['\n' as u8]) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/brain.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | }, |s| PathBuf::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/brain.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | output_file.write(&['\n' as u8]) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.29s [INFO] running `"docker" "inspect" "c756c90b2a9586fb8d1b72f3d05a4d9480315e35a9d472644f29381c02a01e5a"` [INFO] running `"docker" "rm" "-f" "c756c90b2a9586fb8d1b72f3d05a4d9480315e35a9d472644f29381c02a01e5a"` [INFO] [stdout] c756c90b2a9586fb8d1b72f3d05a4d9480315e35a9d472644f29381c02a01e5a