[INFO] updating cached repository braidchat/giphybot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/braidchat/giphybot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/braidchat/giphybot" "work/ex/clippy-test-run/sources/stable/gh/braidchat/giphybot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/braidchat/giphybot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/braidchat/giphybot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/braidchat/giphybot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/braidchat/giphybot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04eff7044a8c135e8dddaae3c9536bfe022f87f9 [INFO] sha for GitHub repo braidchat/giphybot: 04eff7044a8c135e8dddaae3c9536bfe022f87f9 [INFO] validating manifest of braidchat/giphybot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of braidchat/giphybot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing braidchat/giphybot [INFO] finished frobbing braidchat/giphybot [INFO] frobbed toml for braidchat/giphybot written to work/ex/clippy-test-run/sources/stable/gh/braidchat/giphybot/Cargo.toml [INFO] started frobbing braidchat/giphybot [INFO] finished frobbing braidchat/giphybot [INFO] frobbed toml for braidchat/giphybot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/braidchat/giphybot/Cargo.toml [INFO] crate braidchat/giphybot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting braidchat/giphybot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/braidchat/giphybot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07d412ec3ec2335b09af26fe519a17128b18fd2096701bad9e82110f07650b69 [INFO] running `"docker" "start" "-a" "07d412ec3ec2335b09af26fe519a17128b18fd2096701bad9e82110f07650b69"` [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking string v0.1.1 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Checking urlencoding v1.0.0 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Checking hyper v0.10.14 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking giphybot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/conf.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | toml::de::from_str(&contents).or(Err("Couldn't parse TOML".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err("Couldn't parse TOML".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/conf.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | conf.get(group).and_then(|v| v.as_table()).map(|t| t.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `conf.get(group).and_then(|v| v.as_table()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/message.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..wrtr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `bytes[..wrtr.len()].clone_from_slice(&wrtr[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | fn serialize_transit_uuid_seq(uuids: &Vec, se: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Uuid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/message.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | let transit_uuids: Vec = uuids.into_iter().map(uuid_to_transit).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/giphy.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | / match data { [INFO] [stderr] 49 | | &JsonValue::Array(ref vals) => vals.first(), [INFO] [stderr] 50 | | _ => None [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *data { [INFO] [stderr] 49 | JsonValue::Array(ref vals) => vals.first(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/giphy.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | / match gif_info.get("url").unwrap() { [INFO] [stderr] 61 | | &JsonValue::String(ref s) => Some(s), [INFO] [stderr] 62 | | _ => None [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *gif_info.get("url").unwrap() { [INFO] [stderr] 61 | JsonValue::String(ref s) => Some(s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let ref conf_filename = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^----------- help: try: `let conf_filename = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `keys`. [INFO] [stderr] --> src/main.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..keys.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for in &keys { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | println!("Bot {:?} starting", braid_conf.get("name").unwrap().as_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&braid_conf["name"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or(IronError::new(routing::MissingMac, [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 107 | | status::Unauthorized))); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or_else(|| IronError::new(routing::MissingMac, [INFO] [stderr] 107 | status::Unauthorized))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/conf.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | toml::de::from_str(&contents).or(Err("Couldn't parse TOML".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err("Couldn't parse TOML".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/conf.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | conf.get(group).and_then(|v| v.as_table()).map(|t| t.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `conf.get(group).and_then(|v| v.as_table()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/message.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..wrtr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `bytes[..wrtr.len()].clone_from_slice(&wrtr[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/message.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | fn serialize_transit_uuid_seq(uuids: &Vec, se: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Uuid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/message.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | let transit_uuids: Vec = uuids.into_iter().map(uuid_to_transit).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/giphy.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | / match data { [INFO] [stderr] 49 | | &JsonValue::Array(ref vals) => vals.first(), [INFO] [stderr] 50 | | _ => None [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *data { [INFO] [stderr] 49 | JsonValue::Array(ref vals) => vals.first(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/giphy.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | / match gif_info.get("url").unwrap() { [INFO] [stderr] 61 | | &JsonValue::String(ref s) => Some(s), [INFO] [stderr] 62 | | _ => None [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *gif_info.get("url").unwrap() { [INFO] [stderr] 61 | JsonValue::String(ref s) => Some(s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let ref conf_filename = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^----------- help: try: `let conf_filename = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `keys`. [INFO] [stderr] --> src/main.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..keys.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for in &keys { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | println!("Bot {:?} starting", braid_conf.get("name").unwrap().as_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&braid_conf["name"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or(IronError::new(routing::MissingMac, [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 107 | | status::Unauthorized))); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or_else(|| IronError::new(routing::MissingMac, [INFO] [stderr] 107 | status::Unauthorized))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.72s [INFO] running `"docker" "inspect" "07d412ec3ec2335b09af26fe519a17128b18fd2096701bad9e82110f07650b69"` [INFO] running `"docker" "rm" "-f" "07d412ec3ec2335b09af26fe519a17128b18fd2096701bad9e82110f07650b69"` [INFO] [stdout] 07d412ec3ec2335b09af26fe519a17128b18fd2096701bad9e82110f07650b69