[INFO] updating cached repository bradfordboyle/git-housekeeping [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bradfordboyle/git-housekeeping [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bradfordboyle/git-housekeeping" "work/ex/clippy-test-run/sources/stable/gh/bradfordboyle/git-housekeeping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bradfordboyle/git-housekeeping'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bradfordboyle/git-housekeeping" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradfordboyle/git-housekeeping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradfordboyle/git-housekeeping'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1dc7e9789ccd8ad3811e4559af89c4c9d153eb06 [INFO] sha for GitHub repo bradfordboyle/git-housekeeping: 1dc7e9789ccd8ad3811e4559af89c4c9d153eb06 [INFO] validating manifest of bradfordboyle/git-housekeeping on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bradfordboyle/git-housekeeping on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bradfordboyle/git-housekeeping [INFO] finished frobbing bradfordboyle/git-housekeeping [INFO] frobbed toml for bradfordboyle/git-housekeeping written to work/ex/clippy-test-run/sources/stable/gh/bradfordboyle/git-housekeeping/Cargo.toml [INFO] started frobbing bradfordboyle/git-housekeeping [INFO] finished frobbing bradfordboyle/git-housekeeping [INFO] frobbed toml for bradfordboyle/git-housekeeping written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bradfordboyle/git-housekeeping/Cargo.toml [INFO] crate bradfordboyle/git-housekeeping has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bradfordboyle/git-housekeeping against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bradfordboyle/git-housekeeping:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fd36477574b9a437e4b8d312be8d9984c539b63d3ab66bb14a3fee625c2ef3d [INFO] running `"docker" "start" "-a" "2fd36477574b9a437e4b8d312be8d9984c539b63d3ab66bb14a3fee625c2ef3d"` [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling curl-sys v0.4.13 [INFO] [stderr] Compiling structopt-derive v0.2.12 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking structopt v0.2.12 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git-housekeeping v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or(failure::err_msg("no reference_shorthand"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("no reference_shorthand"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | let author_name = author.name().ok_or(failure::err_msg("no author name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("no author name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or(failure::err_msg("no reference_shorthand"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("no reference_shorthand"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | let author_name = author.name().ok_or(failure::err_msg("no author name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("no author name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.06s [INFO] running `"docker" "inspect" "2fd36477574b9a437e4b8d312be8d9984c539b63d3ab66bb14a3fee625c2ef3d"` [INFO] running `"docker" "rm" "-f" "2fd36477574b9a437e4b8d312be8d9984c539b63d3ab66bb14a3fee625c2ef3d"` [INFO] [stdout] 2fd36477574b9a437e4b8d312be8d9984c539b63d3ab66bb14a3fee625c2ef3d